OpenLP

version 2889 song edit window 'save and preview' button only saves

Bug #1840092 reported by Johnthan
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenLP
Fix Committed
High
Tim Bentley
OpenLP 2.9.1

Bug Description

Windown 10 32 bit
Version 2889 of Trunk

To recreate this;
1. select a song in the song plugin
2. select the edit button in the song library
3. modify a verse
4. select the 'save and preview' button
5. the edit window will close, but the preview never happens.

Related branches

lp:~trb143/openlp/latest-fixes
Raoul Snyman: Approve
Diff: 350 lines (+154/-27)
7 files modified
openlp/core/display/render.py (+21/-1)
openlp/core/lib/serviceitem.py (+7/-1)
openlp/core/ui/mainwindow.py (+2/-1)
openlp/core/ui/servicemanager.py (+11/-18)
openlp/plugins/presentations/lib/maclocontroller.py (+2/-1)
openlp/plugins/songs/forms/editsongdialog.py (+0/-2)
tests/functional/openlp_core/display/test_render.py (+111/-3)
Revision history for this message
Johnthan (johnmfl) wrote :

This has been verified to still happen on trunk 2892 with a clean install.

Revision history for this message
Tim Bentley (trb143) wrote :

Incorrect Fix applied earlier.
Not Save has moved from the right to left side of Cancel since 2.4. This is a QT thing.

The correct behavior is this:

From Song plugin you get Save and that saves and exits.

From Service Manager you get Save and that Saves and Exits

From Preview you get Save and "Save & Preview". Save saves and exits. "Save and Preview" saves the song and reloads the preview.

Changed in openlp:
status: New → In Progress
assignee: nobody → Tim Bentley (trb143)
importance: Undecided → High
Tim Bentley (trb143)
Changed in openlp:
status: In Progress → Fix Committed
milestone: none → 2.9.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.