PluginManager still has plugin list
Bug #1823575 reported by
Simon Hanna
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| OpenLP |
In Progress
|
High
|
Tim Bentley | ||
Bug Description
It appears as if the PluginManager was refactored to not keep state about the plugins. Instead State was introduced.
But during initialization of the PluginManager the list of plugins is still initialized to the empty list. This needs to be removed.
There is no other code using the list atm. But there are tests using it.
The tests don't break, because they only compare the lists to themselves, which of course works when the lists are empty.
Related branches
lp:~trb143/openlp/media_state
- Raoul Snyman: Approve
-
Diff: 3097 lines (+560/-1663)22 files modified.bzrignore (+1/-0)
openlp/core/common/settings.py (+10/-4)
openlp/core/lib/theme.py (+5/-0)
openlp/core/ui/media/__init__.py (+1/-0)
openlp/core/ui/media/mediacontroller.py (+71/-169)
openlp/core/ui/media/mediaplayer.py (+5/-3)
openlp/core/ui/media/mediatab.py (+148/-0)
openlp/core/ui/media/playertab.py (+0/-269)
openlp/core/ui/media/systemplayer.py (+0/-332)
openlp/core/ui/media/vlcplayer.py (+115/-114)
openlp/core/ui/screenstab.py (+1/-1)
openlp/core/ui/settingsform.py (+8/-5)
openlp/core/ui/slidecontroller.py (+97/-8)
openlp/core/ui/themeform.py (+2/-0)
openlp/core/ui/themewizard.py (+3/-1)
openlp/core/widgets/views.py (+4/-1)
openlp/plugins/media/lib/mediaitem.py (+4/-1)
openlp/plugins/media/lib/mediatab.py (+0/-73)
openlp/plugins/media/mediaplugin.py (+0/-13)
tests/functional/openlp_core/common/test_common.py (+2/-2)
tests/functional/openlp_core/ui/media/test_systemplayer.py (+0/-567)
tests/functional/openlp_core/ui/media/test_vlcplayer.py (+83/-100)
Revision history for this message
| Tim Bentley (trb143) wrote | #1 |
| Changed in openlp: | |
| status: | New → In Progress |
| milestone: | none → 2.9.1 |
| assignee: | nobody → Tim Bentley (trb143) |
| importance: | Undecided → High |
To post a comment you must log in.
This was missing code for this release.
Will be finished in 3.1