Exception importing Words of Worship songs

Bug #1746350 reported by Raoul Snyman on 2018-01-30
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenLP
Medium
Unassigned

Bug Description

A user is having a problem with importing his Words of Worship songs. Here's a traceback I was able to reproduce with his songs:

Traceback (most recent call last):
  File "openlp/core/widgets/wizard.py", line 228, in on_current_id_changed
    self.perform_wizard()
  File "openlp/plugins/songs/forms/songimportform.py", line 331, in perform_wizard
    importer.do_import()
  File "openlp/plugins/songs/lib/importers/wordsofworship.py", line 142, in do_import
    block_type = BLOCK_TYPES[ord(song_data.read(4)[:1])]
IndexError: tuple index out of range

You can get the songs from https://support.openlp.org/scp/tickets.php?id=4485

itskieran (itskieran) wrote :

I have been having this same issue - it appears to be related to minor words (which show as different coloured text on the display screen, and non-bold text on the operator screen) as all other files are importing properly.

This is obviously a commonly used feature in WoW for songs where men & women sing different lines, or for instructions like (repeat) for the congregation.

Phill (phill-ridout) wrote :

Hey,
I wrote the WoW importer, but unfortunately I no longer have access to WoW anymore! Would you be able to send several songs without any of the mentioned formatting, and then modify the songs to include the formatting. Do not change anything else, do not edit the text in any way, just add the formatting to some of the lyrics. I'll take a look to see what I can do.

itskieran (itskieran) wrote :
itskieran (itskieran) wrote :
itskieran (itskieran) wrote :

I have attached a sample to this issue. The minor lines are the lines at the end of some of the verses which just contain (repeat). The major/minor text option is on a per-line basis, rather than formatting specific parts of text, meaning either the whole line is in the main colour or the alternative colour.

WoW changes formatting of minor lines by using a different font colour that can be specified in the display options. I am unsure what the best method of preserving those formatting differences are, if it is even possible.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers