MediaInfo's XML output has changed

Bug #1732348 reported by Raoul Snyman on 2017-11-15
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenLP
High
Phill

Bug Description

As of version 17.10, MediaInfo's XML output has changed, causing tests to fail (and no doubt OpenLP as well). Unfortunately while the changelog says that you can still use the old XML, the command line utility itself does not seem to support that option (I can't figure out how to give it the option).

Changelog: https://mediaarea.net/MediaInfo/ChangeLog

Test output:

======================================================================
ERROR: test_media_length (tests.interfaces.openlp_core.ui.media.vendor.test_mediainfoWrapper.TestMediainfoWrapper)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "OpenLP/tests/interfaces/openlp_core/ui/media/vendor/test_mediainfoWrapper.py", line 48, in test_media_length
    self.assertEqual(results.tracks[0].duration, test_data[1], 'The correct duration is returned for ' +
  File "OpenLP/openlp/core/ui/media/vendor/mediainfoWrapper.py", line 130, in tracks
    self._populate_tracks()
  File "OpenLP/openlp/core/ui/media/vendor/mediainfoWrapper.py", line 122, in _populate_tracks
    for xml_track in self.xml_dom.Mediainfo.File.find_all("track"):
AttributeError: 'NoneType' object has no attribute 'File'

----------------------------------------------------------------------

description: updated
Phill (phill-ridout) wrote :

I haven't looked at the code but the change log states 'Use Option("Inform", "OLDXML") for keeping previous behaviour'

Perhaps we should use this until we can be sure all systems have received the update, then in the future switch to the json interface (introduced in 7.99)

Tim Bentley (trb143) wrote :

I'll take a look as I added this

Changed in openlp:
assignee: nobody → Tim Bentley (trb143)
Tim Bentley (trb143) on 2017-11-16
Changed in openlp:
milestone: none → 2.5.1
assignee: Tim Bentley (trb143) → nobody
status: New → Fix Committed
Tim Bentley (trb143) on 2017-11-21
Changed in openlp:
assignee: nobody → Phill (phill-ridout)
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers