Entire Song doesn't search Song Number

Bug #1695587 reported by Johannes Thomas Meyer on 2017-06-03
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenLP
Wishlist
Johannes Thomas Meyer

Bug Description

Related: Bug #1000729

When searching in "Entire Song" the field "Song Number" isn't searched.

Related branches

Changed in openlp:
assignee: nobody → Johannes Thomas Meyer (samothjtm)
status: New → In Progress
Samuel Mehrbrodt (sam92) on 2017-06-03
Changed in openlp:
importance: Undecided → Wishlist
Azaziah (suutari-olli) wrote :

Not sure about this, but it's possible that "entire song" only
searches for titles and lyrics.

Performance vice adding search items should be tested on a database with at least 2000 songs to make sure it does not effect performance too much.

Could be better to just rename "Entire song" to "Title or lyrics", or whatever is being searched.

Well, there already are the two separated searches for "Title" and for "Lyrics". And as most titles should be included in the lyrics as well I don't see a valid point for "Title or Lyrics" to exist.

So in my opinion, an "Entire Song" search is useful... but maybe some configuration options should be added what the user wants to include. As when you have a CCLI Number you'd most likely don't want to search for it but rather for a song number only as a lot of many digets numbers will result in way too many results and you can't distinguish anymore why all these are shown to you. But when this behaviour is adaptable the users wishes this will really add some value.

Considering the performance this is a valid point - I already did an implementation which operates with a single query.

Raoul Snyman (raoul-snyman) wrote :

"Entire Song" searches most attributes on the song, not just the title and the lyrics. I can't remember exactly which attributes, I'd have to go back and look at the code.

The actual code to search in "Entire Song" does only do a indirect database call over the plugin manager to search for a match in either of song.search_title, song.search_lyrics and song.comments. That's not searching in all possible attributes but only in three (admittedly the main ones).

I adapted the database call to be a little more direct and to search for a match in the songbooks name, the SongBookEntry (being the songs number) and the alternate_title as well. Only three lines of code have been adapted to seven.

Tim Bentley (trb143) on 2017-06-11
Changed in openlp:
milestone: none → 2.5.1
status: In Progress → Fix Committed
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers