Entire Song doesn't search Song Number
Bug #1695587 reported by
Johannes Thomas Meyer
This bug affects 2 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenLP |
Fix Committed
|
Wishlist
|
Johannes Thomas Meyer |
Bug Description
Related: Bug #1000729
When searching in "Entire Song" the field "Song Number" isn't searched.
Related branches
lp:~samothjtm/openlp/bug-1695587
- Tim Bentley: Approve
- Samuel Mehrbrodt (community): Approve
- Tomas Groth: Approve
- Raoul Snyman: Pending requested
-
Diff: 73 lines (+42/-4)2 files modifiedopenlp/plugins/songs/lib/mediaitem.py (+8/-3)
tests/functional/openlp_plugins/songs/test_mediaitem.py (+34/-1)
Changed in openlp: | |
assignee: | nobody → Johannes Thomas Meyer (samothjtm) |
status: | New → In Progress |
Changed in openlp: | |
importance: | Undecided → Wishlist |
Changed in openlp: | |
milestone: | none → 2.5.1 |
status: | In Progress → Fix Committed |
To post a comment you must log in.
Not sure about this, but it's possible that "entire song" only
searches for titles and lyrics.
Performance vice adding search items should be tested on a database with at least 2000 songs to make sure it does not effect performance too much.
Could be better to just rename "Entire song" to "Title or lyrics", or whatever is being searched.