Space after Bible book name auto-completion is missing

Bug #1678292 reported by Azaziah on 2017-03-31
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenLP
Low
Azaziah

Bug Description

If the user uses Bible book name auto-completion in
the Bible search, the space after the book name is missing.

Example of searching Psalms 23:
Ps > Psalm23

Thus the user needs to add the space manually.
(The search works without the space as well but it would be better visually)
this works as intended in 2.4.6 but not in trunk rev 2730.

The added space should not be visible in the book name on footer.

Edit: Something broke it in rev 2722 (Bible media item
refactors), it works in 2721.
http://bazaar.launchpad.net/~openlp-core/openlp/trunk/revision/2722?start_revid=2722

Trunk revision 2730, Windows 10
(Works in 2.4.6)

Related branches

Azaziah (suutari-olli) on 2017-03-31
description: updated
description: updated
Azaziah (suutari-olli) on 2017-03-31
Changed in openlp:
importance: Undecided → Wishlist
Azaziah (suutari-olli) on 2017-03-31
Changed in openlp:
importance: Wishlist → Undecided
description: updated
Azaziah (suutari-olli) on 2017-03-31
description: updated
summary: - Add space after Bible book name auto-completion
+ Space after Bible book name auto-completion is missing
Changed in openlp:
importance: Undecided → Low
Phill (phill-ridout) wrote :

I would disagree that this is a bug. It works the same way as other auto completers do, just try few examples in OpenLP and Google. I think its best to emulate the way others do it from a usability point of view.

Azaziah (suutari-olli) wrote :

The added space is expected by the user because if
they use the auto completion they expect to be able
to just type in the numbers after that. It’s also faster.

Google is not a search engine for Bible verses, other
worship programs such as Easy Worship 2009 do this, I
think it’s the standard for searching Bible verses in
Worship software.

Besides, even if the user added a 2nd space it wouldn’t
have any effect to the search results, it's a win win situation.

It is a feature in 2.4.6 but it’s broken in trunk, thus it’s a bug.

Azaziah (suutari-olli) on 2017-04-01
description: updated
Azaziah (suutari-olli) on 2017-06-04
Changed in openlp:
status: New → In Progress
assignee: nobody → Azaziah (suutari-olli)
Tim Bentley (trb143) on 2017-06-08
Changed in openlp:
status: In Progress → Fix Committed
milestone: none → 2.5.1
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers