"Save & Preview" Button in Song Editor behaves in a strange way
Bug #1673113 reported by
Simon Hanna
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| OpenLP |
Fix Committed
|
Low
|
Phill | ||
Bug Description
When you get to the Song Editor by pressing the "edit and reload song preview" button in the Preview Section, you get three button to process the form "Save & Preview", "Save" and "Cancel".
My issue is with the first. Upon pressing it apparently nothing happens. The editor remains open.
In fact the "Save" button behaves in the way you would expect the "Save & Preview" button behaves. Upon clicking it, the editor closes and the preview is refreshed. (Note this does not happen if you press "Save" when accessing the Editor from any other place)
Can I remove the Save & Preview button and all related code?
Related branches
lp:~phill-ridout/openlp/fixes-IV
- Tim Bentley: Approve
-
Diff: 852 lines (+172/-161)25 files modifiedopenlp/core/common/__init__.py (+16/-1)
openlp/core/common/actions.py (+1/-1)
openlp/core/common/i18n.py (+4/-14)
openlp/core/common/registry.py (+2/-23)
openlp/core/display/html/display.js (+29/-22)
openlp/core/display/render.py (+1/-1)
openlp/core/display/screens.py (+2/-10)
openlp/core/lib/theme.py (+1/-0)
openlp/core/state.py (+2/-11)
openlp/core/ui/advancedtab.py (+1/-1)
openlp/core/ui/icons.py (+4/-14)
openlp/plugins/bibles/lib/__init__.py (+23/-29)
openlp/plugins/bibles/lib/db.py (+22/-25)
openlp/plugins/bibles/lib/manager.py (+4/-2)
openlp/plugins/custom/forms/editcustomdialog.py (+2/-0)
openlp/plugins/songs/forms/editsongdialog.py (+2/-0)
openlp/plugins/songs/lib/db.py (+3/-1)
openlp/plugins/songs/lib/importers/cclifile.py (+2/-0)
openlp/plugins/songs/lib/importers/dreambeam.py (+2/-1)
openlp/plugins/songs/lib/importers/easyslides.py (+2/-0)
openlp/plugins/songs/lib/importers/easyworship.py (+1/-1)
openlp/plugins/songs/lib/importers/songbeamer.py (+1/-1)
tests/functional/openlp_core/common/test_common.py (+43/-1)
tests/functional/openlp_core/lib/test_theme.py (+1/-1)
tests/functional/openlp_core/ui/test_icons.py (+1/-1)
Revision history for this message
| Phill (phill-ridout) wrote | #1 |
| Changed in openlp: | |
| status: | New → Confirmed |
| importance: | Undecided → Low |
Revision history for this message
| Tim Bentley (trb143) wrote | #2 |
Revision history for this message
| Raoul Snyman (raoul-snyman) wrote | #3 |
| Changed in openlp: | |
| status: | Confirmed → In Progress |
| assignee: | nobody → Phill (phill-ridout) |
| milestone: | none → 2.9.1 |
| Changed in openlp: | |
| status: | In Progress → Fix Committed |
To post a comment you must log in.
Simon,
I agree! Its almost like the "save and preview" button should be visible when you click edit from the song manager, and not from the "Edit and reload song preview" (the edit button under the preview).
I'd recommend posting a link to this bug on the mailing list to see what others think.