VideoPsalm import fails due to unexpected format
Bug #1652851 reported by
Tomas Groth
This bug affects 2 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenLP |
Fix Committed
|
Medium
|
Tomas Groth | ||
2.4 |
Fix Released
|
Medium
|
Tomas Groth |
Bug Description
VideoPsalm uses an invalid JSON format, which is first made valid for us to be able to load it, but a few things is currently not supported:
* Converting negative numbers to strings (matiching on "-").
* Verse object does not always contain a Text attribute.
Affects 2.4.x and trunk.
See http://
Related branches
lp:~tomasgroth/openlp/song-import-fixes25
- Tim Bentley: Approve
-
Diff: 311 lines (+130/-29)9 files modifiedopenlp/plugins/songs/lib/__init__.py (+2/-2)
openlp/plugins/songs/lib/importers/easyslides.py (+12/-12)
openlp/plugins/songs/lib/importers/songbeamer.py (+9/-6)
openlp/plugins/songs/lib/importers/videopsalm.py (+4/-2)
tests/functional/openlp_plugins/songs/test_easyslidesimport.py (+2/-0)
tests/resources/easyslidessongs/Amazing Grace.json (+6/-6)
tests/resources/easyslidessongs/Export_2017-01-12_BB.json (+44/-0)
tests/resources/easyslidessongs/Export_2017-01-12_BB.xml (+50/-0)
tests/resources/videopsalmsongs/videopsalm-as-safe-a-stronghold.json (+1/-1)
lp:~tomasgroth/openlp/song-import-fixes24
- Tim Bentley: Approve
-
Diff: 407 lines (+174/-29)12 files modifiedopenlp/core/__init__.py (+38/-2)
openlp/core/lib/treewidgetwithdnd.py (+6/-1)
openlp/core/ui/slidecontroller.py (+2/-0)
openlp/plugins/songs/lib/__init__.py (+2/-2)
openlp/plugins/songs/lib/importers/easyslides.py (+12/-12)
openlp/plugins/songs/lib/importers/songbeamer.py (+7/-3)
openlp/plugins/songs/lib/importers/videopsalm.py (+4/-2)
tests/functional/openlp_plugins/songs/test_easyslidesimport.py (+2/-0)
tests/resources/easyslidessongs/Amazing Grace.json (+6/-6)
tests/resources/easyslidessongs/Export_2017-01-12_BB.json (+44/-0)
tests/resources/easyslidessongs/Export_2017-01-12_BB.xml (+50/-0)
tests/resources/videopsalmsongs/videopsalm-as-safe-a-stronghold.json (+1/-1)
Changed in openlp: | |
status: | Confirmed → In Progress |
Changed in openlp: | |
milestone: | none → 2.5.1 |
status: | In Progress → Fix Committed |
To post a comment you must log in.