If Bible search results are locked, duplicated results are listed
Bug #1625681 reported by
Azaziah
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| OpenLP |
Fix Committed
|
Low
|
Phill | ||
Bug Description
If Bible search results are locked, duplicated results are listed.
This is linked to def build_display_
and def display_
in \plugins\
I tried to fix this but couldn't get around QListWidgetItem,
which pops tracebacks like:
TypeError: unhashable type: 'QListWidgetItem'
for items = items(set(items))
or literal errors for other attempted solutions.
Win 10 / trunk 2696
Related branches
lp:~phill-ridout/openlp/saved_bible_verses
- Tomas Groth: Approve
- Tim Bentley: Pending requested
-
Diff: 1076 lines (+324/-202)12 files modifiedopenlp/core/ui/lib/listwidgetwithdnd.py (+10/-4)
openlp/core/ui/lib/pathedit.py (+4/-4)
openlp/plugins/bibles/lib/__init__.py (+3/-3)
openlp/plugins/bibles/lib/db.py (+13/-0)
openlp/plugins/bibles/lib/manager.py (+15/-43)
openlp/plugins/bibles/lib/mediaitem.py (+178/-63)
openlp/plugins/presentations/presentationplugin.py (+1/-1)
openlp/plugins/songusage/forms/songusagedetaildialog.py (+1/-1)
resources/images/openlp-2.qrc (+2/-4)
tests/functional/openlp_core_ui_lib/test_listwidgetwithdnd.py (+33/-31)
tests/functional/openlp_plugins/bibles/test_mediaitem.py (+63/-47)
tests/interfaces/openlp_plugins/bibles/test_lib_parse_reference.py (+1/-1)
| Changed in openlp: | |
| importance: | Undecided → Low |
| Changed in openlp: | |
| status: | New → In Progress |
| assignee: | nobody → Phill (phill-ridout) |
| Changed in openlp: | |
| milestone: | none → 2.5.1 |
| status: | In Progress → Fix Committed |
To post a comment you must log in.
