Changing shortcut to a key that is already used produces traceback
Bug #1612187 reported by
Azaziah
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenLP |
Fix Committed
|
Low
|
Azaziah |
Bug Description
Changing shortcut to a key that is already used produces traceback.
Traceback (most recent call last):
File "E:\bzr\
if self._validiate
File "E:\bzr\
text, for_display=True)
TypeError: warning_message() got an unexpected keyword argument 'for_display'
Trunk rev 2690 | Win 10
Related branches
lp:~suutari-olli/openlp/change-blank-to-desktop-hotkey-to-esc
- Tomas Groth: Approve
- Tim Bentley: Approve
-
Diff: 438 lines (+89/-102)12 files modifiedopenlp/core/common/settings.py (+6/-4)
openlp/core/ui/exceptiondialog.py (+1/-1)
openlp/core/ui/exceptionform.py (+1/-1)
openlp/core/ui/mainwindow.py (+16/-32)
openlp/core/ui/shortcutlistform.py (+3/-3)
openlp/core/ui/slidecontroller.py (+35/-30)
openlp/plugins/custom/lib/mediaitem.py (+1/-1)
openlp/plugins/songs/forms/editsongform.py (+1/-1)
resources/images/openlp-2.qrc (+0/-1)
tests/functional/openlp_core_ui/test_slidecontroller.py (+2/-25)
tests/functional/openlp_plugins/bibles/test_mediaitem.py (+21/-0)
tests/functional/openlp_plugins/bibles/test_swordimport.py (+2/-3)
Changed in openlp: | |
status: | New → In Progress |
Changed in openlp: | |
importance: | Undecided → Low |
Changed in openlp: | |
status: | In Progress → Fix Committed |
milestone: | none → 2.5.1 |
To post a comment you must log in.
if not is_valid: 'OpenLP. ShortcutListDia log',
'The shortcut "{key}" is already assigned to another action, please'
' use a different shortcut.'
).format( key=self. get_shortcut_ string( key_sequence) )
self. main_window. warning_ message( translate( 'OpenLP. ShortcutListDia log', 'Duplicate Shortcut'),
text, for_display=True) <<<< THIS = TRACEBACK
self. dialog_ was_shown = True
text = translate(
return is_valid
if not is_valid: 'OpenLP. ShortcutListDia log',
'The shortcut "{key}" is already assigned to another action, please'
' use a different shortcut.'
).format( key=self. get_shortcut_ string( key_sequence) )
self. main_window. warning_ message( translate( 'OpenLP. ShortcutListDia log', 'Duplicate Shortcut'),
text)
for_ display = True < FIX?
self. dialog_ was_shown = True
text = translate(
return is_valid