VideoPsalm import with control chars or escaped quotes causes traceback
Bug #1594945 reported by
Tomas Groth
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| OpenLP |
Fix Committed
|
Medium
|
Tomas Groth | ||
| 2.4 |
Fix Released
|
Undecided
|
Tomas Groth | ||
Bug Description
Original report + sample file here: https:/
In 2.4.1 when trying to import a songbook with control chars or escaped quotes a traceback is thrown, like this:
Traceback (most recent call last):
File "openlp\
in do_import File "json\__init__.py", line 318, in loads File "json\decoder.py",
line 343, in decode File "json\decoder.py", line 359,
in raw_decode ValueError: Expecting ',' delimiter: line 1 column 21627 (char 21626)
Related branches
lp:~tomasgroth/openlp/videopsalm-fix-24
- Raoul Snyman: Approve
- Tim Bentley: Approve
-
Diff: 120 lines (+92/-0)4 files modifiedopenlp/plugins/songs/lib/importers/videopsalm.py (+8/-0)
tests/functional/openlp_plugins/songs/test_videopsalm.py (+2/-0)
tests/resources/videopsalmsongs/as-safe-a-stronghold2.json (+35/-0)
tests/resources/videopsalmsongs/videopsalm-as-safe-a-stronghold2.json (+47/-0)
lp:~tomasgroth/openlp/25bugfixes4
- Raoul Snyman: Approve
-
Diff: 316 lines (+132/-31)7 files modifiedopenlp/plugins/bibles/lib/http.py (+28/-22)
openlp/plugins/songs/lib/importers/easyslides.py (+1/-1)
openlp/plugins/songs/lib/importers/videopsalm.py (+8/-0)
tests/functional/openlp_plugins/songs/test_videopsalm.py (+2/-0)
tests/interfaces/openlp_plugins/bibles/test_lib_http.py (+11/-8)
tests/resources/videopsalmsongs/as-safe-a-stronghold2.json (+35/-0)
tests/resources/videopsalmsongs/videopsalm-as-safe-a-stronghold2.json (+47/-0)
| Changed in openlp: | |
| status: | In Progress → Fix Committed |
| Changed in openlp: | |
| milestone: | none → 2.5.1 |
To post a comment you must log in.
