Moving Song in Service Manager, Hover Text says "Service Manager"

Bug #1544260 reported by Raoul Snyman
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenLP
Fix Committed
Wishlist
Tim Bentley

Bug Description

When changing the order of songs in Service Manager, the hover text says "Service Manager", rather than the title of the song.

See this function in core/ui/servicemanager.py:

    def mouseMoveEvent(self, event):
        """
        Drag and drop event does not care what data is selected as the recipient will use events to request the data
        move just tell it what plugin to call
        :param event:
        """
        if event.buttons() != QtCore.Qt.LeftButton:
            event.ignore()
            return
        if not self.itemAt(self.mapFromGlobal(QtGui.QCursor.pos())):
            event.ignore()
            return
        drag = QtGui.QDrag(self)
        mime_data = QtCore.QMimeData()
        drag.setMimeData(mime_data)
        mime_data.setText('ServiceManager')
        drag.exec(QtCore.Qt.CopyAction)

Related branches

Revision history for this message
Raoul Snyman (raoul-snyman) wrote :

I don't see any hover text?

Revision history for this message
Raoul Snyman (raoul-snyman) wrote :

If I change that text, drag and drop no longer works. I think that text *has* to be that.

Revision history for this message
David Wales (daviewales) wrote :

It's possible that the problem is somewhere else.

I'm sure I remember that in a previous release, you could drag items around, and you could see their name when you were dragging them.

But since 2.2, the name has been replaced with "ServiceManager".

Revision history for this message
David Wales (daviewales) wrote :

I just checked 2.0.5, and it happened back then, so maybe I'm just imagining that it used to be different.

Revision history for this message
David Wales (daviewales) wrote :

Ideally, I think one day it would be nice if it worked like this:

Phill (phill-ridout)
Changed in openlp:
importance: Low → Wishlist
Revision history for this message
Tim Bentley (trb143) wrote :

The mousemove event mime needs to be set to the window you want to play with.
ServiceManager now has detailed hover text for songs so this resolves the initial issue.

Changed in openlp:
assignee: nobody → Tim Bentley (trb143)
status: New → In Progress
Tim Bentley (trb143)
Changed in openlp:
status: In Progress → Fix Committed
milestone: none → 2.9.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.