Activity log for bug #1534306

Date Who What changed Old value New value Message
2016-01-14 21:03:19 Tomas Groth bug added bug
2016-01-14 21:33:14 Tomas Groth description Empty song-titles causes tracebacks on update from 2.0 to 2.2. This basically prevents users from using songs OpenLP 2.2 after upgrading. The traceback: Traceback (most recent call last): File "C:\Program Files (x86)\OpenLP\plugins\songs\songsplugin.py", line 206, in on_song_import_item_clicked self.media_item.on_import_click() File "D:\OpenLP_Development\OpenLP_Code\2.2\openlp\plugins\songs\lib\mediaitem.py", line 298, in on_import_click File "D:\OpenLP_Development\OpenLP_Code\2.2\openlp\core\common\registry.py", line 137, in execute File "D:\OpenLP_Development\OpenLP_Code\2.2\openlp\plugins\songs\lib\mediaitem.py", line 219, in on_song_list_load File "D:\OpenLP_Development\OpenLP_Code\2.2\openlp\plugins\songs\lib\mediaitem.py", line 165, in on_search_text_button_clicked File "D:\OpenLP_Development\OpenLP_Code\2.2\openlp\plugins\songs\lib\mediaitem.py", line 206, in search_entire File "D:\OpenLP_Development\OpenLP_Code\2.2\openlp\core\lib\db.py", line 372, in get_all_objects File "c:\Python33\lib\site-packages\sqlalchemy\orm\query.py", line 2292, in all File "c:\Python33\lib\site-packages\sqlalchemy\orm\loading.py", line 72, in instances File "c:\Python33\lib\site-packages\sqlalchemy\orm\loading.py", line 72, in <listcomp> File "c:\Python33\lib\site-packages\sqlalchemy\orm\loading.py", line 455, in _instance File "c:\Python33\lib\site-packages\sqlalchemy\event\attr.py", line 257, in __call__ File "c:\Python33\lib\site-packages\sqlalchemy\orm\mapper.py", line 2650, in _event_on_load File "D:\OpenLP_Development\OpenLP_Code\2.2\openlp\plugins\songs\lib\db.py", line 134, in init_on_load File "D:\OpenLP_Development\OpenLP_Code\2.2\openlp\core\utils\__init__.py", line 532, in get_natural_key IndexError: string index out of range Empty song-titles causes tracebacks on update from 2.0 to 2.2. This basically prevents users from using songs OpenLP 2.2 after upgrading. The traceback: Traceback (most recent call last): File "C:\Program Files (x86)\OpenLP\plugins\songs\songsplugin.py", line 206, in on_song_import_item_clicked self.media_item.on_import_click() File "D:\OpenLP_Development\OpenLP_Code\2.2\openlp\plugins\songs\lib\mediaitem.py", line 298, in on_import_click File "D:\OpenLP_Development\OpenLP_Code\2.2\openlp\core\common\registry.py", line 137, in execute File "D:\OpenLP_Development\OpenLP_Code\2.2\openlp\plugins\songs\lib\mediaitem.py", line 219, in on_song_list_load File "D:\OpenLP_Development\OpenLP_Code\2.2\openlp\plugins\songs\lib\mediaitem.py", line 165, in on_search_text_button_clicked File "D:\OpenLP_Development\OpenLP_Code\2.2\openlp\plugins\songs\lib\mediaitem.py", line 206, in search_entire File "D:\OpenLP_Development\OpenLP_Code\2.2\openlp\core\lib\db.py", line 372, in get_all_objects File "c:\Python33\lib\site-packages\sqlalchemy\orm\query.py", line 2292, in all File "c:\Python33\lib\site-packages\sqlalchemy\orm\loading.py", line 72, in instances File "c:\Python33\lib\site-packages\sqlalchemy\orm\loading.py", line 72, in <listcomp> File "c:\Python33\lib\site-packages\sqlalchemy\orm\loading.py", line 455, in _instance File "c:\Python33\lib\site-packages\sqlalchemy\event\attr.py", line 257, in __call__ File "c:\Python33\lib\site-packages\sqlalchemy\orm\mapper.py", line 2650, in _event_on_load File "D:\OpenLP_Development\OpenLP_Code\2.2\openlp\plugins\songs\lib\db.py", line 134, in init_on_load File "D:\OpenLP_Development\OpenLP_Code\2.2\openlp\core\utils\__init__.py", line 532, in get_natural_key IndexError: string index out of range An example DB can be found attached to this support ticket: http://support.openlp.org/scp/tickets.php?id=3250
2016-01-15 20:03:40 Launchpad Janitor branch linked lp:~sam92/openlp/bug-1533081
2016-01-15 20:25:23 Samuel Mehrbrodt openlp: assignee Samuel Mehrbrodt (sam92)
2016-01-15 20:25:26 Samuel Mehrbrodt openlp: milestone 2.4.0
2016-01-15 20:25:54 Samuel Mehrbrodt openlp: status Confirmed In Progress
2016-01-15 20:36:11 Tim Bentley openlp: milestone 2.4.0
2016-01-16 20:13:46 Launchpad Janitor branch linked lp:openlp
2016-01-17 11:52:02 Samuel Mehrbrodt openlp: status In Progress Fix Committed
2016-01-17 13:43:32 Tim Bentley openlp: milestone 2.4.0
2016-02-05 19:09:05 Tim Bentley openlp: milestone 2.4.0 2.3.3
2016-02-06 21:35:18 Tim Bentley openlp: status Fix Committed Fix Released