Expanding or Collapsing a Song in ServiceManager raises an Exception
Bug #1532169 reported by
Simon Hanna
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| OpenLP |
Fix Released
|
High
|
Tomas Groth | ||
Bug Description
When expanding or Collapsing a Song in ServiceManager a IndexError occurs.
This only happens when using the buttons in the Service Manager.
I guess the error occurs because of the -1 when accessing the items.
However the -1 is being used 5 times all over the class.
I'm not sure about the reason behind the -1 in the first place
Related branches
lp:~tomasgroth/openlp/presentation-fixes24
- Tim Bentley: Approve
- Raoul Snyman: Approve
-
Diff: 214 lines (+51/-29)9 files modifiedopenlp/core/ui/servicemanager.py (+6/-2)
openlp/core/ui/slidecontroller.py (+13/-12)
openlp/plugins/presentations/lib/messagelistener.py (+7/-6)
openlp/plugins/songs/forms/editsongform.py (+1/-1)
openlp/plugins/songs/lib/mediaitem.py (+3/-3)
tests/functional/openlp_core_lib/test_htmlbuilder.py (+1/-2)
tests/functional/openlp_core_ui/test_mainwindow.py (+0/-2)
tests/functional/openlp_plugins/presentations/test_messagelistener.py (+20/-0)
tests/resources/projector/data.py (+0/-1)
| Changed in openlp: | |
| importance: | Undecided → High |
| status: | New → Confirmed |
| Changed in openlp: | |
| assignee: | nobody → Tomas Groth (tomasgroth) |
| status: | Confirmed → In Progress |
Revision history for this message
| Tim Bentley (trb143) wrote | #1 |
Revision history for this message
| Tomas Groth (tomasgroth) wrote | #2 |
| Changed in openlp: | |
| milestone: | none → 2.4.0 |
| status: | In Progress → Fix Committed |
| Changed in openlp: | |
| milestone: | 2.4.0 → 2.3.3 |
| Changed in openlp: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
-1 I think meant no set or something like that!