import openlyrics xml - KeyError: 'temporary'

[Tomasss]

windows 7, Portable OpenLP 2.2.1
I wanted to import lyric (see attachment), that was exported from version OpenLP 2.1.4
There was an error:
Traceback (most recent call last):
  File "D:\OpenLP_Development\OpenLP_Code\2.2\openlp\core\ui\wizard.py", line 216, in on_current_id_changed
  File "D:\OpenLP_Development\OpenLP_Code\2.2\openlp\plugins\songs\forms\songimportform.py", line 348, in perform_wizard
  File "D:\OpenLP_Development\OpenLP_Code\2.2\openlp\plugins\songs\lib\importers\openlyrics.py", line 67, in do_import
  File "D:\OpenLP_Development\OpenLP_Code\2.2\openlp\plugins\songs\lib\openlyricsxml.py", line 389, in xml_to_song
  File "D:\OpenLP_Development\OpenLP_Code\2.2\openlp\plugins\songs\lib\openlyricsxml.py", line 602, in _process_formatting_tags
  File "D:\OpenLP_Development\OpenLP_Code\2.2\openlp\plugins\songs\lib\openlyricsxml.py", line 603, in <listcomp>
KeyError: 'temporary'

[Tomas Groth (tomasgroth)]

I can't reproduce this on linux with python3.5. Maybe a windows issue.

[Tomas Groth (tomasgroth)]

I cannot reproduce this on windows either running OpenLP 2.2.1.
Can you reproduce this in 2.2.1?

[Tomasss (tomas-spam)]

I tried to import this file on Openlp 2.3.2 (windows 7 32bit), but the same result:

Traceback (most recent call last):
  File "openlp\core\ui\wizard.py", line 216, in on_current_id_changed
  File "openlp\plugins\songs\forms\songimportform.py", line 351, in perform_wizard
  File "openlp\plugins\songs\lib\importers\openlyrics.py", line 67, in do_import
  File "openlp\plugins\songs\lib\openlyricsxml.py", line 378, in xml_to_song
  File "openlp\plugins\songs\lib\openlyricsxml.py", line 591, in _process_formatting_tags
  File "openlp\plugins\songs\lib\openlyricsxml.py", line 592, in <listcomp>
KeyError: 'temporary'

and after cancel, there is second problem:
Traceback (most recent call last):
  File "R:\OpenLPPortable221\App\OpenLP\plugins\songs\songsplugin.py", line 205, in on_song_import_item_clicked
    self.media_item.on_import_click()
  File "openlp\plugins\songs\lib\mediaitem.py", line 301, in on_import_click
  File "openlp\core\common\registry.py", line 137, in execute
  File "openlp\plugins\songs\lib\mediaitem.py", line 212, in on_song_list_load
  File "openlp\core\lib\mediamanageritem.py", line 618, in build_service_item
  File "openlp\plugins\songs\lib\mediaitem.py", line 421, in generate_slide_data
  File "openlp\core\lib\mediamanageritem.py", line 662, in _get_id_of_item_to_generate
RuntimeError: wrapped C/C++ object of type QListWidgetItem has been deleted

[Tomas Groth (tomasgroth)]

I just had a quick look at the code again, and I'm pretty sure it is related to some broken settings related to your formatting tags...
You should be able to fix this cleaning your custom formatting tags, though I realize that might not a attractive route...

[Tomasss (tomas-spam)]

I tried on just downloaded OpenLP v2.4 windows 7 32bit and it's ok.
Thanks

[Tomas Groth (tomasgroth)]

I'm marking this as invalid, since it does not seem to be an OpenLP bug.

[Raoul Snyman (raoul-snyman)]

It would be nice to handle the error in a friendlier manner though.

[Tomasss (tomas-spam)]

OK, I will try to do it better next time.
Thanks for your good job. God bless you.

[Raoul Snyman (raoul-snyman)]

Tomasss, I'm just talking about how OpenLP handles errors, not you :)

[Tomasss (tomas-spam)]

OK :D