Double click on the preview duplicated the element in the service manger

Bug #1462420 reported by Wolodja Moros on 2015-06-05
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenLP
Fix Committed
Low
Azaziah

Bug Description

Hello
I use OpenLP 2.1.5 on Windwos 7 and when i double click on a picture or a custom slide or a verse of a song, the song /slide / picture is duplicated in the service manager.
This occur every time you double click on a slide / song /picture.

Thanks you guys for theis great software and sorry for my bad english.

Regards

Related branches

Daniel Borges (danielborges93) wrote :

I don't know if that is really a bug...

In some occasions this is necessary, for example, if the same song will play in the start and the finish of the service (if you have a good planning about your services). To duplicate the song is necessary.

The same for slides/pictures/presentations.

Raoul Snyman (raoul-snyman) wrote :

I can't reproduce this. Please send us your settings, a debug log file, and a more accurate, step-by-step guide on how to reproduce this.

Raoul Snyman (raoul-snyman) wrote :

(like, where are you double-clicking? in the service manage? in the slide controller? in the media manager?)

Wolodja Moros (wolodja-moros) wrote :

Hello
"(like, where are you double-clicking? in the service manage? in the slide controller? in the media manager?)"
I double-click in the preview ( right clik on the song - show preview) and then I double-click on a the song verse or on the picture (which is shown in the preview).

"I can't reproduce this. Please send us your settings, a debug log file, and a more accurate, step-by-step guide on how to reproduce this."

Is the guide below accurate enough? I attach my settings but the log file is not generated . (I use the portable version of OpenLP).
I will try to make a video of this ubug maybe this video can better explain what i mean.

Thanks for your quick help.

Regards

Daniel Borges (danielborges93) wrote :

I tryed to reproduce it. Here are the results:

+ Using Mac OS 10.10:
    1. In OpenLP 2.0.5 this doesn't happens.

+ Using Ubuntu Studio 14.04:
    1. In OpenLP 2.1.5 this happens partially;
    2. Double-clicking in a verse (in preview panel), the song is added to service;
    3. Double-clicking in the preview image (in preview panel, below of the song verses), nothing happens.

Tim Bentley (trb143) wrote :

Interesting.

In slideController (depending on your double click live setting) the preview either goes to live or the service.
The bug is that there is no check in servicemanager to see if the serviceitem is already loaded before it adds a second copy.
This is old code.

The other question is why not on Mac but that may be because of the setting can you check that.

Daniel Borges (danielborges93) wrote :

This is my Mac OS settings (attached) with OpenLP 2.0.5.
I have the same settings in Ubuntu Studio with OpenLP 2.1.5.

Phill (phill-ridout) on 2015-10-14
Changed in openlp:
status: New → Confirmed
importance: Undecided → Low
Azaziah (suutari-olli) wrote :

    def on_preview_double_click(self, field=None):
        """
        Triggered when a preview slide item is doubleclicked
        """
        if self.service_item:
            if Settings().value('advanced/double click live'):
                # Live and Preview have issues if we have video or presentations
                # playing in both at the same time.
                if self.service_item.is_command():
                    Registry().execute('%s_stop' % self.service_item.name.lower(), [self.service_item, self.is_live])
                if self.service_item.is_media():
                    self.on_media_close()
                self.on_go_live()
            else:
                self.on_preview_add_to_service()

As TRB143 pointed out, this code is based on double click to go to live setting.
It would be very easy to "fix" this by removing the: else: self.on_preview_add_to_service(),
but this functionality would be then lost. A better solution would be to have it chek if item is
already in Service.

Azaziah (suutari-olli) on 2016-05-10
Changed in openlp:
assignee: nobody → Azaziah (suutari-olli)
Tim Bentley (trb143) on 2016-08-10
Changed in openlp:
milestone: none → 2.5.1
status: Confirmed → Fix Committed
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers