Remove old upgrade code

Bug #1420276 reported by Phill on 2015-02-10
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenLP
High
Tim Bentley

Bug Description

Added as a bug to remember things to do after 2.2, please add additional tasks:

In plugin/songs/lib/openlyricsxml.py:get_verses there is an if statement with the following comment:

"This is an old style song, without XML. Let's handle it correctly by iterating through the verses, and then recreating the internal xml object as well."

This code should be removed as we do not support upgrade paths < 2.0.5

-----------------------------------------------------------------------------

In core/common/settings.py:Settings __obsolete_settings__ has four settings commented with:

"Changed during 1.9.x development."

This code should be removed as we do not support upgrade paths < 2.0.5

Related branches

Phill (phill-ridout) on 2015-02-10
Changed in openlp:
importance: Undecided → Low
description: updated
description: updated
Phill (phill-ridout) on 2015-02-14
description: updated
Tim Bentley (trb143) wrote :

There are a number of other places as well.

ServiceItem ,
ImagePlugin.

Most are tagged with TODOs

summary: - Remove old upgrade code in plugin/songs/lib/openlyricsxml.py:get_verses
+ Remove old upgrade code
Phill (phill-ridout) wrote :

Done:
In openlp.plugins.bibles.lib.db.BibleDB#is_old_database there is the following comment:

"Returns ``True`` if it is a bible database, which has been created prior to 1.9.6."

This code should be removed as we do not support upgrade paths < 2.0.5

description: updated
Tomas Groth (tomasgroth) on 2015-03-24
Changed in openlp:
importance: Low → Wishlist
status: New → Confirmed
Tim Bentley (trb143) on 2015-06-02
Changed in openlp:
assignee: nobody → Tim Bentley (trb143)
Tim Bentley (trb143) on 2015-06-02
Changed in openlp:
status: Confirmed → In Progress
importance: Wishlist → High
Tim Bentley (trb143) on 2015-11-05
Changed in openlp:
milestone: none → 2.3.0
status: In Progress → Fix Committed
Tim Bentley (trb143) on 2015-12-28
Changed in openlp:
milestone: 2.3.0 → 2.3.1
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers