check_latest_version in core.utils.__init__.py duplicates code to download and retry on failure of the version check file. This code is similar to the code in get_webpage. We could reduce duplication by using get_webpage
Duplicate code:
retries = 0
while True:
try:
remote_version = str(urllib.request.urlopen(req, None,
timeout=CONNECTION_TIMEOUT).read().decode()).strip()
except ConnectionException:
if retries > CONNECTION_RETRIES:
log.exception('Failed to download the latest OpenLP version file')
else:
retries += 1
time.sleep(0.1)
continue
break
Working on network stack refactoring. Will be fixed then.