"Escape Item" needs focus on the live controller verse list
Bug #1294111 reported by
Phill
This bug affects 2 people
| Affects | Status | Importance | Assigned to | Milestone | ||
|---|---|---|---|---|---|---|
| OpenLP | Status tracked in Trunk | |||||
| 2.0 |
Won't Fix
|
Low
|
Unassigned | |||
| Trunk |
Fix Committed
|
Low
|
Azaziah | |||
Bug Description
http://
Pressing esc hides the main display. However this only happens when the focus is on the live controller's verse list.
Looking in the "Configure Shortcuts" dialog I found esc is mapped to the "Escape Item" action.
Related branches
lp:~suutari-olli/openlp/escape-fixes-1294111-1497637
- Tim Bentley: Pending requested
-
Diff: 128 lines (+44/-23)2 files modifiedopenlp/core/ui/slidecontroller.py (+31/-18)
tests/functional/openlp_core_ui/test_slidecontroller.py (+13/-5)
lp:~suutari-olli/openlp/change-blank-to-desktop-hotkey-to-esc
- Tomas Groth: Approve
- Tim Bentley: Approve
-
Diff: 438 lines (+89/-102)12 files modifiedopenlp/core/common/settings.py (+6/-4)
openlp/core/ui/exceptiondialog.py (+1/-1)
openlp/core/ui/exceptionform.py (+1/-1)
openlp/core/ui/mainwindow.py (+16/-32)
openlp/core/ui/shortcutlistform.py (+3/-3)
openlp/core/ui/slidecontroller.py (+35/-30)
openlp/plugins/custom/lib/mediaitem.py (+1/-1)
openlp/plugins/songs/forms/editsongform.py (+1/-1)
resources/images/openlp-2.qrc (+0/-1)
tests/functional/openlp_core_ui/test_slidecontroller.py (+2/-25)
tests/functional/openlp_plugins/bibles/test_mediaitem.py (+21/-0)
tests/functional/openlp_plugins/bibles/test_swordimport.py (+2/-3)
Revision history for this message
| MACC Sound Desk (sd1) wrote | #1 |
Revision history for this message
| Azaziah (suutari-olli) wrote | #2 |
To post a comment you must log in.
Would be nice if this coule be looked at with greater than low priority, it's a pretty confusing bug if you are not aware of it's cause...
To expand on the above, you can reproduce the issue by configuring OpenLP to bypass X11 windows manager in the settings. With that done add one song to the service, press enter to have it display on the second desktop, press ESC to quit that song, select the song again and press enter to have it display again, now you are unable press ESC to exit the song although pressing 'D' to display the desktop still works. With bypass X11 windows manager disabled you are always able to exit the song with ESC.
You will notice there is a difference in behaviour the second time you press enter to display the song on the second desktop. The first time, focus passes to the live verse list, the second time it does not and for this reason you cannot escape out of the song.
Note also that as X11 is being bypassed switching to desktop using 'D' is not an acceptable solution as this causes other windows to render incorrectly due to X11 still being bypassed.
a
Essentially 'Escape Item' needs to be configured to work all of the time, not just when the live verse list has the focus.