Saving with ctrl+s changes service order song selection

[Brian Henderson]

OS: Windows 7 Home Premium

OpenLP: 2.0.4

When I save using Ctrl+S the selected song in the Service Manager changes, and if I then switch songs using the right arrow key it jumps to an unexpected song or fails to switch if it deselected all songs.

Expected behavior: Saving with Ctrl+S would save, and I would be able to continue as if I had not saved.

[Phill (phill-ridout)]

Hi Brian,

That is strange behaviour. Unfortunately I cannot replicate it with 2.0.4 on Windows XP.

Could you just check that Ctrl + S is assigned to "Save" and nothing else in the "Configure Shortcuts" dialogue on the settings menu.

[Brian Henderson (theinitialsarebh)]

It does not appear to be assigned to anything else. I don't think I've
changed any shortcuts.

Brian Henderson
On Apr 11, 2014 7:26 AM, "Phill" <email address hidden> wrote:

> Hi Brian,
>
> That is strange behaviour. Unfortunately I cannot replicate it with
> 2.0.4 on Windows XP.
>
> Could you just check that Ctrl + S is assigned to "Save" and nothing
> else in the "Configure Shortcuts" dialogue on the settings menu.
>
> ** Changed in: openlp
> Assignee: (unassigned) => Phill (phill-ridout)
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1291786
>
> Title:
> Saving with ctrl+s changes service order song selection
>
> Status in OpenLP - Worship Presentation Software:
> New
>
> Bug description:
> OS: Windows 7 Home Premium
>
> OpenLP: 2.0.4
>
>
> When I save using Ctrl+S the selected song in the Service Manager
> changes, and if I then switch songs using the right arrow key it jumps to
> an unexpected song or fails to switch if it deselected all songs.
>
>
> Expected behavior: Saving with Ctrl+S would save, and I would be able to
> continue as if I had not saved.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/openlp/+bug/1291786/+subscriptions
>

[Brian Henderson (theinitialsarebh)]

Also, I just saw it shift the selection when I clicked the save button

Brian Henderson
On Apr 13, 2014 9:31 AM, "Brian Henderson" <email address hidden>
wrote:

> It does not appear to be assigned to anything else. I don't think I've
> changed any shortcuts.
>
> Brian Henderson
> On Apr 11, 2014 7:26 AM, "Phill" <email address hidden> wrote:
>
>> Hi Brian,
>>
>> That is strange behaviour. Unfortunately I cannot replicate it with
>> 2.0.4 on Windows XP.
>>
>> Could you just check that Ctrl + S is assigned to "Save" and nothing
>> else in the "Configure Shortcuts" dialogue on the settings menu.
>>
>> ** Changed in: openlp
>> Assignee: (unassigned) => Phill (phill-ridout)
>>
>> --
>> You received this bug notification because you are subscribed to the bug
>> report.
>> https://bugs.launchpad.net/bugs/1291786
>>
>> Title:
>> Saving with ctrl+s changes service order song selection
>>
>> Status in OpenLP - Worship Presentation Software:
>> New
>>
>> Bug description:
>> OS: Windows 7 Home Premium
>>
>> OpenLP: 2.0.4
>>
>>
>> When I save using Ctrl+S the selected song in the Service Manager
>> changes, and if I then switch songs using the right arrow key it jumps to
>> an unexpected song or fails to switch if it deselected all songs.
>>
>>
>> Expected behavior: Saving with Ctrl+S would save, and I would be able
>> to continue as if I had not saved.
>>
>> To manage notifications about this bug go to:
>> https://bugs.launchpad.net/openlp/+bug/1291786/+subscriptions
>>
>

[Jasper van Nieuwenhuizen (jasperge)]

I tried to reproduce the bug and this is what happens (running OpenLP on OSX Yosemite 10.10.4):

- If the Preview and Live Panels are empty: focus is lost after saving and pressing the arrow keys does nothing.
- If I have something in the Live Panel: focus is switched to Live panel and only up/down arrow work to go through the slides of the live item. Left/right arrows don't do anything.
- If I have something in the Preview and Live Panels: focus is switched to Live Panel if this had focus before changing to Service Manager (same as previous). If the focus was on the Preview Panel before switching to the Service Manager, focus is lost and arrow keys don't do anything.

[Timothy Cooper (timothycooper)]

Platform:
OS: Windows 10 Home
OpenLP: 2.4.4

This affects me too. It often happens after having edited or moved an item in the Service Manager. It is *NOT* triggered by clicking the "Save this service" icon in the Service Manager. It is only triggered by pressing Ctrl+S or clicking File -> Save. I haven't tested if Save As is affected by this behavior. This can be very problematic if it happens during a live service.

[Lars Woodhouse (larsalonian)]

OS: Windows 10 Home, and Mac OS X 10.9.5
OpenLP: 2.4.6

Same problem here. Hitting Ctrl+S or Cmd+S while Live causes the Live pane to lose focus and shortcut keys don't behave as expected. With Windows the up/down arrows still work, but left/right/./T/D do not. On the Mac, nothing works after a save. Clicking on a verse in the song pane doesn't re-enable the shortcut keys.

My workaround is to double-click an item in the Service Manager to give focus back to the Live pane.