Post SIP merge Presentation Tab fails to work
Bug #1094340 reported by
Tim Bentley
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| OpenLP |
Fix Released
|
Critical
|
Unassigned | ||
Bug Description
Presentation Tab Save has a call to Settings.value without a default value.
This fails post the SIP migration
Add NONE as the default value and handle a return of None meaning not found.
Related branches
lp:~googol-deactivatedaccount/openlp/bug-779201-2
- Raoul Snyman: Approve
- Tim Bentley: Approve
- Jonathan Corwin (community): Approve
-
Diff: 7208 lines (+1200/-1498)92 files modifiedopenlp.pyw (+9/-0)
openlp/core/__init__.py (+7/-10)
openlp/core/lib/__init__.py (+76/-9)
openlp/core/lib/db.py (+11/-14)
openlp/core/lib/formattingtags.py (+3/-6)
openlp/core/lib/listwidgetwithdnd.py (+1/-1)
openlp/core/lib/mediamanageritem.py (+19/-22)
openlp/core/lib/plugin.py (+3/-6)
openlp/core/lib/searchedit.py (+3/-3)
openlp/core/lib/serviceitem.py (+4/-4)
openlp/core/lib/settings.py (+0/-68)
openlp/core/lib/settingsmanager.py (+8/-15)
openlp/core/lib/spelltextedit.py (+2/-3)
openlp/core/lib/toolbar.py (+1/-1)
openlp/core/lib/ui.py (+4/-4)
openlp/core/ui/aboutdialog.py (+4/-4)
openlp/core/ui/aboutform.py (+1/-1)
openlp/core/ui/advancedtab.py (+36/-52)
openlp/core/ui/exceptionform.py (+11/-12)
openlp/core/ui/firsttimeform.py (+21/-27)
openlp/core/ui/formattingtagform.py (+6/-6)
openlp/core/ui/generaltab.py (+42/-63)
openlp/core/ui/maindisplay.py (+11/-20)
openlp/core/ui/mainwindow.py (+81/-102)
openlp/core/ui/media/__init__.py (+6/-9)
openlp/core/ui/media/mediacontroller.py (+7/-8)
openlp/core/ui/media/phononplayer.py (+3/-5)
openlp/core/ui/media/playertab.py (+4/-5)
openlp/core/ui/media/vlcplayer.py (+5/-6)
openlp/core/ui/media/webkitplayer.py (+8/-10)
openlp/core/ui/pluginform.py (+8/-15)
openlp/core/ui/printserviceform.py (+14/-19)
openlp/core/ui/screen.py (+8/-15)
openlp/core/ui/servicemanager.py (+58/-63)
openlp/core/ui/shortcutlistform.py (+7/-10)
openlp/core/ui/slidecontroller.py (+20/-24)
openlp/core/ui/themeform.py (+55/-86)
openlp/core/ui/thememanager.py (+45/-54)
openlp/core/ui/themestab.py (+8/-12)
openlp/core/ui/wizard.py (+12/-12)
openlp/core/utils/__init__.py (+11/-12)
openlp/core/utils/actions.py (+8/-8)
openlp/core/utils/languagemanager.py (+12/-16)
openlp/plugins/alerts/alertsplugin.py (+4/-4)
openlp/plugins/alerts/forms/alertform.py (+17/-17)
openlp/plugins/alerts/lib/alertstab.py (+14/-20)
openlp/plugins/bibles/bibleplugin.py (+6/-9)
openlp/plugins/bibles/forms/bibleimportform.py (+42/-52)
openlp/plugins/bibles/forms/bibleupgradeform.py (+24/-26)
openlp/plugins/bibles/forms/booknameform.py (+1/-1)
openlp/plugins/bibles/forms/editbibleform.py (+11/-11)
openlp/plugins/bibles/lib/__init__.py (+7/-8)
openlp/plugins/bibles/lib/biblestab.py (+24/-38)
openlp/plugins/bibles/lib/csvbible.py (+4/-4)
openlp/plugins/bibles/lib/http.py (+6/-6)
openlp/plugins/bibles/lib/manager.py (+8/-11)
openlp/plugins/bibles/lib/mediaitem.py (+66/-76)
openlp/plugins/bibles/lib/opensong.py (+5/-5)
openlp/plugins/bibles/lib/osis.py (+3/-3)
openlp/plugins/custom/forms/editcustomform.py (+4/-4)
openlp/plugins/custom/lib/customtab.py (+3/-5)
openlp/plugins/custom/lib/mediaitem.py (+8/-12)
openlp/plugins/images/imageplugin.py (+2/-3)
openlp/plugins/images/lib/imagetab.py (+3/-5)
openlp/plugins/images/lib/mediaitem.py (+14/-17)
openlp/plugins/media/lib/mediaitem.py (+12/-14)
openlp/plugins/media/lib/mediatab.py (+8/-9)
openlp/plugins/media/mediaplugin.py (+4/-4)
openlp/plugins/presentations/lib/mediaitem.py (+14/-17)
openlp/plugins/presentations/lib/presentationcontroller.py (+3/-6)
openlp/plugins/presentations/lib/presentationtab.py (+9/-12)
openlp/plugins/remotes/lib/httpserver.py (+9/-15)
openlp/plugins/remotes/lib/remotetab.py (+11/-16)
openlp/plugins/songs/forms/editsongform.py (+44/-51)
openlp/plugins/songs/forms/editverseform.py (+4/-3)
openlp/plugins/songs/forms/mediafilesform.py (+1/-1)
openlp/plugins/songs/forms/songexportform.py (+8/-10)
openlp/plugins/songs/forms/songimportform.py (+8/-10)
openlp/plugins/songs/forms/songmaintenanceform.py (+22/-22)
openlp/plugins/songs/lib/__init__.py (+14/-13)
openlp/plugins/songs/lib/db.py (+7/-3)
openlp/plugins/songs/lib/ewimport.py (+2/-2)
openlp/plugins/songs/lib/mediaitem.py (+15/-23)
openlp/plugins/songs/lib/openlyricsexport.py (+2/-3)
openlp/plugins/songs/lib/powersongimport.py (+4/-4)
openlp/plugins/songs/lib/songimport.py (+1/-2)
openlp/plugins/songs/lib/songstab.py (+10/-16)
openlp/plugins/songs/lib/xml.py (+4/-4)
openlp/plugins/songs/lib/zionworximport.py (+11/-12)
openlp/plugins/songs/songsplugin.py (+6/-10)
openlp/plugins/songusage/forms/songusagedetailform.py (+15/-19)
openlp/plugins/songusage/songusageplugin.py (+13/-18)
| Changed in openlp: | |
| status: | Confirmed → Fix Committed |
| assignee: | nobody → Andreas Preikschat (googol) |
| Changed in openlp: | |
| status: | Fix Committed → Fix Released |
| Changed in openlp: | |
| status: | Fix Released → Fix Committed |
| Changed in openlp: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
