Corrupted databases stop OpenLP from starting

[Phill]

Corrupt databases stop OpenLP from properly loading with no indication that this is the cause.

We should either start and ignore the corrupt database (by not loading it) or at the minimum display an error message stating that the database is not valid.

Most recently caused by the corrupted ASV bible, but this has happened before with other database issues.

http://support.openlp.org/issues/1659

[Raoul Snyman (raoul-snyman)]

I've fixed the ASV by the way.

[Phill (phill-ridout)]

Thanks Raoul, but obviously this still stands.

[Raoul Snyman (raoul-snyman)]

Got another support request about this, see http://support.openlp.org/scp/tickets.php?id=2222

*OpenLP Bug Report*
Version: {u'full': u'2.0.4', u'version': u'2.0.4', u'build': None}

--- Details of the Exception. ---

cancelling setup download

--- Exception Traceback ---
Traceback (most recent call last):
File "/Users/martin/Projects/openlp/OpenLP-2.0.4/build/pyi.darwin/OpenLP/out00-PYZ.pyz/openlp.plugins.bibles.lib.mediaitem", line 571, in onEditClick
File "/Users/martin/Projects/openlp/OpenLP-2.0.4/build/pyi.darwin/OpenLP/out00-PYZ.pyz/openlp.plugins.bibles.forms.editbibleform", line 94, in loadBible
File "/Users/martin/Projects/openlp/OpenLP-2.0.4/build/pyi.darwin/OpenLP/out00-PYZ.pyz/openlp.plugins.bibles.lib.manager", line 258, in get_book_by_id
File "/Users/martin/Projects/openlp/OpenLP-2.0.4/build/pyi.darwin/OpenLP/out00-PYZ.pyz/openlp.plugins.bibles.lib.db", line 344, in get_book_by_book_ref_id
File "/Users/martin/Projects/openlp/OpenLP-2.0.4/build/pyi.darwin/OpenLP/out00-PYZ.pyz/openlp.core.lib.db", line 346, in get_object_filtered
File "/Users/martin/Projects/openlp/OpenLP-2.0.4/build/pyi.darwin/OpenLP/out00-PYZ.pyz/sqlalchemy.orm.query", line 2156, in first
File "/Users/martin/Projects/openlp/OpenLP-2.0.4/build/pyi.darwin/OpenLP/out00-PYZ.pyz/sqlalchemy.orm.query", line 2023, in __getitem__
File "/Users/martin/Projects/openlp/OpenLP-2.0.4/build/pyi.darwin/OpenLP/out00-PYZ.pyz/sqlalchemy.orm.query", line 2227, in __iter__
File "/Users/martin/Projects/openlp/OpenLP-2.0.4/build/pyi.darwin/OpenLP/out00-PYZ.pyz/sqlalchemy.orm.query", line 2242, in _execute_and_instances
File "/Users/martin/Projects/openlp/OpenLP-2.0.4/build/pyi.darwin/OpenLP/out00-PYZ.pyz/sqlalchemy.engine.base", line 1449, in execute
File "/Users/martin/Projects/openlp/OpenLP-2.0.4/build/pyi.darwin/OpenLP/out00-PYZ.pyz/sqlalchemy.engine.base", line 1584, in _execute_clauseelement
File "/Users/martin/Projects/openlp/OpenLP-2.0.4/build/pyi.darwin/OpenLP/out00-PYZ.pyz/sqlalchemy.engine.base", line 1698, in _execute_context
File "/Users/martin/Projects/openlp/OpenLP-2.0.4/build/pyi.darwin/OpenLP/out00-PYZ.pyz/sqlalchemy.engine.base", line 1691, in _execute_context
File "/Users/martin/Projects/openlp/OpenLP-2.0.4/build/pyi.darwin/OpenLP/out00-PYZ.pyz/sqlalchemy.engine.default", line 331, in do_execute
DatabaseError: (DatabaseError) database disk image is malformed u'SELECT book.id AS book_id, book.book_reference_id AS book_book_reference_id, book.testament_reference_id AS book_testament_reference_id, book.name AS book_name \nFROM book \nWHERE book.book_reference_id LIKE ?\n LIMIT ? OFFSET ?' (1, 1, 0)

--- System information ---
Platform: Darwin-10.8.0-i386-32bit

--- Library Versions ---
Python: 2.7.3
Qt4: 4.8.3
Phonon: 4.4.0
PyQt4: 4.9.4
QtWebkit: 534.34
SQLAlchemy: 0.7.9
SQLAlchemy Migrate: 0.7.2
BeautifulSoup: 3.2.1
lxml: 2.3.2
Chardet: 2.0.1
PyEnchant: -
PySQLite: -
Mako: 0.7.2
pyUNO bridge: -