Fix vlc.py

Bug #1070356 reported by Andreas Preikschat
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenLP
Fix Released
Low
Tim Bentley

Bug Description

Hello,

the vlc.py with the build date "Fri Oct 5 21:46:31 2012". Any newer versions don't. This is because we use some methods which were only provided for backward compatibility and have now been removed.

See the commitdiff: http://git.videolan.org/?p=vlc/bindings/python.git;a=commitdiff;h=f20079a3403042442033a05429900b0add575cb7

Traceback attempting to show an video live:
Traceback (most recent call last):
  File "/home/andreas/Projects/OpenLP/vlc/openlp/core/lib/mediamanageritem.py", line 510, in onLiveClick
    self.goLive()
  File "/home/andreas/Projects/OpenLP/vlc/openlp/core/lib/mediamanageritem.py", line 517, in goLive
    serviceItem = self.buildServiceItem(item, remote=remote)
  File "/home/andreas/Projects/OpenLP/vlc/openlp/core/lib/mediamanageritem.py", line 587, in buildServiceItem
    if self.generateSlideData(serviceItem, item, xmlVersion, remote):
  File "/home/andreas/Projects/OpenLP/vlc/openlp/plugins/media/lib/mediaitem.py", line 208, in generateSlideData
    self.mediaController, filename, False, False):
  File "/home/andreas/Projects/OpenLP/vlc/openlp/core/ui/media/mediacontroller.py", line 331, in video
    isValid = self.check_file_type(controller, display)
  File "/home/andreas/Projects/OpenLP/vlc/openlp/core/ui/media/mediacontroller.py", line 383, in check_file_type
    if player.load(display):
  File "/home/andreas/Projects/OpenLP/vlc/openlp/core/ui/media/vlcplayer.py", line 153, in load
    display.vlcMediaPlayer.set_media(display.vlcMedia)
AttributeError: 'Display' object has no attribute 'vlcMediaPlayer'

Revision history for this message
Andreas Preikschat (googol-deactivatedaccount) wrote :
Revision history for this message
Jonathan Corwin (j-corwin) wrote :

So is this a problem with the current vlc.py in trunk, or will it just be a problem next time we update vlc?

Revision history for this message
Andreas Preikschat (googol-deactivatedaccount) wrote : Re: [Bug 1070356] Re: Fix vlc.py

> So is this a problem with the current vlc.py in trunk, or will it just
> be a problem next time we update vlc?
trunk works fine. (that's why I tagged it 2.1.1 and posted my (broken)
branch here)

Revision history for this message
Tim Bentley (trb143) wrote :

I will take this and add into the media re-write as it is API Changes otherwise it will have to wait till I finish!

Changed in openlp:
assignee: nobody → Tim Bentley (trb143)
status: New → In Progress
Phill (phill-ridout)
Changed in openlp:
importance: Undecided → Low
Revision history for this message
Andreas Preikschat (googol-deactivatedaccount) wrote :

Seems to be fixed.

Changed in openlp:
status: In Progress → Fix Committed
Tim Bentley (trb143)
Changed in openlp:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.