SundayPlus importer could handle information better

[Phill]

The SundayPlus importer could handle Authors and copyrights better.
In the sample files at http://support.openlp.org/issues/1223#change-2289 the "footer information" is only partially imported. The other information is left in the song as a slide.

It shouldn't be too difficult, but would require a larger set of songs, as well as more work than we call a bug fix (for release of v2)

[Carl (carl-fischer)]

Good point but the sample files I provided were manually edited. I don't know their exact history but a number of the ones we use have had the copyright notice added by me, so there's not much consistency between them.

The best I can suggest is to identify blocks of text that are in a smaller font, or that contain a 4 digit number, or the copyright symbol or (c), or the letters CCL, or the word licence, or some combination of the above, and delete that block of text. That would at least make the songs presentable even if they're not entirely legal.

[Phill (phill-ridout)]

> Good point but the sample files I provided were manually edited. I don't
> know their exact history but a number of the ones we use have had the
> copyright notice added by me, so there's not much consistency between
> them.

In SundayPlus is the copyright stored separately? Or did you add them to
the slides automatically?

[Carl (carl-fischer)]

Honestly, I don't understand how the SundayPlus format works. Looking at the source of the .ptf (SundayPlus) files, there seems to be an #author, #title, and #copyright field in the header. In most of our files, these are empty strings "". A few have valid content, and others have a bunch of encoded symbols with no visible meaning.

I have never added explicit copyright or author info to the files and wasn't aware that it was possible. Apparently the SundayPlus format allows this but I never noticed anywhere in the software to modify the values and never saw any options to configure how they are displayed. We have only ever added copyright and author details in a small font at the end of the lyrics.

Much as I would like the importer to deal perfectly with *our* song database, it's probably not representative of other former SundayPlus users. I've imported a few more songs and they seem to work ok with build bzr2088. A few have garbled titles (eg. {\cr\loch\af1\dbch\af4\...) but the lyrics are there.

The current importer correctly deletes the line containing "CCLI licence no ...." from the lyrics but it assumes the number is the CCLI number of the song. In our case, it is actually our church's licence number, but it's ambiguous so probably not worth changing the behaviour.

[Jonathan Corwin (j-corwin)]

OK, thanks Carl. Since this is specific to your database I'm going to set Invalid.

[Phill (phill-ridout)]

On Oct 15, 2012 10:15 PM, "Carl" <email address hidden> wrote:
> The current importer correctly deletes the line containing "CCLI licence
> no ...." from the lyrics but it assumes the number is the CCLI number of
> the song. In our case, it is actually our church's licence number, but
> it's ambiguous so probably not worth changing the behaviour.

According to CCLI the Church licence number should be projected. There are
no requirements for the CCLI song number to be projected.