Open Library

Don't delete physical_dimensions and other_title

Bug #570476 reported by Edward Betts
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Open Library
Confirmed
Medium
Anand Chitipothu
Open Library general-bucket

Bug Description

When I fixed the IA identifier in a book book the physical_dimensions and other_title were deleted:

http://upstream.openlibrary.org/books/OL16261225M/Faery_Tales_from_Hans_Andersen?b=6&m=diff

Edward Betts (edwardbetts)
Changed in openlibrary:
importance: Undecided → Critical
assignee: nobody → Anand Chitipothu (anandology)
milestone: none → upstream-to-www
status: New → Confirmed
Revision history for this message
George (george-archive) wrote :

Anand - this is marked critical, and it's over a month old. Seems like we're losing data, which is a problem!

Changed in openlibrary:
milestone: upstream-to-www → general-bucket
Edward Betts (edwardbetts)
tags: added: ariel
Edward Betts (edwardbetts)
Changed in openlibrary:
assignee: Anand Chitipothu (anandology) → Ariel Backenroth (ariel-archive)
tags: removed: ariel
Revision history for this message
Anand Chitipothu (anandology) wrote :

This happens when there are multiple other_titles and when physical_dimensions is not in the expected format.

The physical_dimensions issue was already fixed and the other_titles issue is fixed now.

http://openlibrary.org/upstream/templates/books/edit/edition.tmpl?b=115&a=113&m=diff

The physical_dimensions parser doesn't understand "12 cm" as a valid value, it expects the value to be in the format "d x d x d inches". Filed a new bug to improve the parser.

https://bugs.launchpad.net/openlibrary/+bug/661029

Revision history for this message
Anand Chitipothu (anandology) wrote :

The issue is now fixed. We now need to identify the edits involving loss of data due to this bug and fix them.

Reduced the priority of this issue to medium.

Changed in openlibrary:
assignee: arielb (ariel-archive) → Anand Chitipothu (anandology)
importance: Critical → Medium
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.