v6.1 database backup - keyword "token" passed twice in call

[Willow IT's Code Repository Admin]

I have created a database with not much data in it, but with a number of modules installed.

From MANAGE DATABASES at the login screen, I clicked on BACKUP, chose the database to backup, typed in the password.

The client displayed the following:

Client Traceback (most recent call last):
  File "/home/openerp/openerp/trunk/new-web/addons/web/common/http.py", line 260, in dispatch
    r = method(controller, self, **self.params)
TypeError: backup() got an unexpected keyword argument ''

examining the client, I have found that the call to the backup method in database class received a kwarg for backup_db, backup_pwd, req. However, the kwarg for "token" was there twice, once with a blank value and once with a valid (looking) numerical token.

[Olivier Dony (Odoo) (odo-openerp)]

Hello,
You are reporting this bug in the project of the 6.0 web client, but it looks like you meant it for 6.1 - which uses the new "openerp-web" project. Re-assigning it.
For what it's worth, using the latest code from the 6.1 branch I can backup and restore a database just fine with the web client, so perhaps the bug was already fixed some time ago?
Could you mention the specific version of OpenERP where you can reproduce this (e.g. RC1 or specific bzr revisions), and perhaps double-check with the latest code?

Thanks!

[Xavier (Open ERP) (xmo-deactivatedaccount)]

I'd also be interested in the browser you tested this in.

[Xavier (Open ERP) (xmo-deactivatedaccount)]

In any case, I was able to observe the cause (but not the symptoms): the token field was indeed duplicated in e.g. Safari (without anything breaking) because it was present in the original form and added again in the process of fetching the db dump file.

I fixed the code so the existing field is correctly reused and set if it's already in the base form, instead of adding a new field.

This issue should be resolved in the 6.1 branch as of revision <email address hidden>

[Willow IT's Code Repository Admin (code-repository)]

My testing was in Firefox 3.6.22 for Ubuntu.

[Rüdiger Könen (ruediger-koenen)]

Hi Gents,

Please can you provide the changes which needs to be done, because I still having this error message.
Python 2.6
Ubuntu 10.04
openERP 6.1-20121008-233119

Many thanks and best regards,

Ruediger

[Olivier Dony (Odoo) (odo-openerp)]

On 10/10/2012 12:56 AM, Rüdiger Könen wrote:
> Please can you provide the changes which needs to be done, because I still having this error message.
> Python 2.6
> Ubuntu 10.04
> openERP 6.1-20121008-233119

Could you please provide some more details on how you can reproduce this, as we
were never able to really reproduced it. What exact version of which browser
are you using? Have you tried multiple browsers? Can you reproduce it on
several computers?
For the record I still cannot reproduce it (with Chrome v22) on the latest 6.1
version on runbot, which is running Ubuntu 12.04.1 and Python 2.7.

Can you try to reproduce it on runbot, by doing the following:
- go to http://runbot.openerp.com
- choose the leftmost build for the 6.1 branch (second sticky branch at the top)
- click on Connect
- try to backup the first database, using "admin" as the password

Thanks!

[Rüdiger Könen (ruediger-koenen)]

Hi Olivier,

- Yes, I could reproduce it on several WIN7 clients with and without today’s MS patches.
- IE 9 Version 9.0.8112.16421 Updateversion: 9.0.10(KB2744842)
- Firefox 13.0
- Client pc's and browsers are in German language

The only differenz on IE and Firefox is the last line
- IE: TypeError: backup() got an unexpected keyword argument ''
- Ff: TypeError: backup() got an unexpected keyword argument 'token'

When using the runbot-version, the same error is coming up with IE as well as with Ff.

Update:
After updating Firefox to version 15.0.1 I was able to backup both dbs, runbot and my server. However, with IE the problem still exists, but as workaround I will use Ff on the admin pc(s).

Many thanks and best regards,

Ruediger