on change must be fired (again) after m2o returns with/after changes

Bug #919723 reported by Ferdinand
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Odoo Web (MOVED TO GITHUB)
Confirmed
Wishlist
OpenERP Publisher's Warranty Team

Bug Description

example
create SO
select product (without defined Sale VAT )
open product, add vat + save
IMHO now the VAT should show up in the sale form, but it does not

workaround , change product or delete and recreate line - not user for users

Tags: maintenance

Related branches

Revision history for this message
Xavier (Open ERP) (xmo-deactivatedaccount) wrote :

This is not a bug, the semantics of onchange are that the field's *value* changing triggers the call. Not the value of something somehow linked through the field.

Changed in openerp-web:
status: New → Invalid
Revision history for this message
Ferdinand (office-chricar) wrote :

this is a regression
version 6 and prior caused the on change trigger to be fired ALSO after returning from a (modified) m2o

Changed in openerp-web:
status: Invalid → New
Revision history for this message
Xavier (Open ERP) (xmo-deactivatedaccount) wrote :

It was never part of the field's semantics, and was rejected as a common-law feature.

Changed in openerp-web:
status: New → Invalid
Revision history for this message
Ferdinand (office-chricar) wrote :

As I said the behavior is different from 6.0 (GTK)
Example
Sales order
* select partner - this copies the payment terms into SO
* open partner - change payment term -
** in v6 and prior - the new payment term is copied
** in trunk the new payment term is not copied.

IMHO this change will cause major problems.

BTW the GTK trunk fires the on change also in v61
for this I reopen the bug again

Changed in openerp-web:
status: Invalid → New
Revision history for this message
Antony Lesuisse (OpenERP) (al-openerp) wrote :

Yes this is a common-law feature. But i think it should be implemented as there are no drawback to triggering an onchange a second time. And i agree that the use case presented by ferdinand should work.

Changed in openerp-web:
importance: Undecided → Wishlist
status: New → Confirmed
Amit Parik (amit-parik)
Changed in openerp-web:
assignee: nobody → OpenERP R&D Web Team (openerp-dev-web)
Changed in openerp-web:
assignee: OpenERP R&D Web Team (openerp-dev-web) → OpenERP Publisher's Warranty Team (openerp-opw)
tags: added: maintenance
Revision history for this message
Raphaël Valyi - http://www.akretion.com (rvalyi) wrote :

Hello I confirm that the last commit of https://code.launchpad.net/~openerp-dev/openerp-web/6.1-opw-577376-bth
fixed the bug for us. I'm not too sure if it introduces any regression yet, but at least it fixed the bug, so think about merging it please.

I will confirm here it introduces no regression. Regards.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.