[6.1][7.0][trunk] Default report filename is useless in daily use
Bug #1261322 reported by
Yann Papouin
This bug affects 2 people
Affects | Status | Importance | Assigned to | Milestone | ||
---|---|---|---|---|---|---|
Odoo Web (MOVED TO GITHUB) |
New
|
Undecided
|
Unassigned | |||
OpenERP Community Backports (Web) | Status tracked in 7.0 | |||||
6.1 |
Fix Released
|
Medium
|
Yann Papouin | |||
7.0 |
Fix Released
|
Medium
|
Ronald Portier (Therp) |
Bug Description
This bug report is related to a question asked [1] on stackoverflow.
The main idea is to allow the user to download its report with a reliable filename:
-"PO00006.pdf" instead of "Request For Quotation.pdf" for a single object report
-"PO00006-
My proposal is to use the object field name if exists and else to use the current behavior to create the report filename.
(Note that the browser will trim invalid filename data like slash, backslash, etc.)
[1] http://
Related branches
lp:~yann-papouin/ocb-web/6.1-bug-1261322-useful-report-filename
- Pedro Manuel Baeza: Approve (code review)
- Ronald Portier (Therp): Approve (code review and partial testing)
- Holger Brunn (Therp): Approve (code review)
- Yann Papouin: Needs Information
-
Diff: 37 lines (+19/-1)1 file modifiedaddons/web/controllers/main.py (+19/-1)
lp:~therp-nl/ocb-web/7.0_lp1261332_better_report_name
- Yannick Vaucher @ Camptocamp: Approve
- Lara (Therp) (community): Approve (test)
- Yann Papouin: Approve
- Pedro Manuel Baeza: Approve (code review and test)
-
Diff: 37 lines (+17/-9)1 file modifiedaddons/web/controllers/main.py (+17/-9)
lp:~therp-nl/openerp-web/7.0_lp1261322_better_report_name
Ready for review
for merging
into
lp:openerp-web/7.0
- OpenERP Core Team: Pending requested
-
Diff: 37 lines (+17/-9)1 file modifiedaddons/web/controllers/main.py (+17/-9)
tags: | added: 6.1 |
To post a comment you must log in.
I "adapted" (move the code a little bit further and remove 2 lines) the patch for OpenERP7 if it might interest anyone.