[trunk/7.0] kanban link not working proper after Group By.

Bug #1101840 reported by Nicolas JEUDY
150
This bug affects 25 people
Affects Status Importance Assigned to Milestone
Odoo Web (MOVED TO GITHUB)
Status tracked in Trunk
7.0
Fix Released
Medium
Unassigned
Trunk
Fix Released
Medium
Fabien Meghazi (OpenERP)
OpenERP Community Backports (Web)
Status tracked in 7.0
7.0
Fix Released
Undecided
Unassigned

Bug Description

version: runbot 7.0 / trunk
to reproduce:

- Go to project
- group by parent
- clic on task link on kanban view

see video.

Server Traceback (most recent call last):
  File "/home/odoo/runbot/static/openerp-dev-7-0-2004/server/openerp/addons/web/session.py", line 90, in send
    return openerp.netsvc.dispatch_rpc(service_name, method, args)
  File "/home/odoo/runbot/static/openerp-dev-7-0-2004/server/openerp/netsvc.py", line 289, in dispatch_rpc
    result = ExportService.getService(service_name).dispatch(method, params)
  File "/home/odoo/runbot/static/openerp-dev-7-0-2004/server/openerp/service/web_services.py", line 614, in dispatch
    res = fn(db, uid, *params)
  File "/home/odoo/runbot/static/openerp-dev-7-0-2004/server/openerp/osv/osv.py", line 169, in execute_kw
    return self.execute(db, uid, obj, method, *args, **kw or {})
  File "/home/odoo/runbot/static/openerp-dev-7-0-2004/server/openerp/osv/osv.py", line 123, in wrapper
    return f(self, dbname, *args, **kwargs)
  File "/home/odoo/runbot/static/openerp-dev-7-0-2004/server/openerp/osv/osv.py", line 179, in execute
    res = self.execute_cr(cr, uid, obj, method, *args, **kw)
  File "/home/odoo/runbot/static/openerp-dev-7-0-2004/server/openerp/addons/audittrail/audittrail.py", line 514, in execute_cr
    return fct_src(cr, uid, model, method, *args, **kw)
  File "/home/odoo/runbot/static/openerp-dev-7-0-2004/server/openerp/osv/osv.py", line 166, in execute_cr
    return getattr(object, method)(cr, uid, *args, **kw)
  File "/home/odoo/runbot/static/openerp-dev-7-0-2004/server/openerp/osv/orm.py", line 2632, in read_group
    assert groupby_def and groupby_def._classic_write, "Fields in 'groupby' must be regular database-persisted fields (no function or related fields), or function fields with store=True"
AssertionError: Fields in 'groupby' must be regular database-persisted fields (no function or related fields), or function fields with store=True

Tags: maintenance

Related branches

Revision history for this message
Nicolas JEUDY (njeudy) wrote :
Changed in openobject-addons:
assignee: nobody → OpenERP R&D Addons Team 1 (openerp-dev-addons1)
importance: Undecided → Medium
status: New → Confirmed
Revision history for this message
Nicolas JEUDY (njeudy) wrote :
summary: - [7.0] Traceback when accessing task when project group by parent_id
+ [trunk/7.0] kanban link not working proper after Group By.
affects: openobject-addons → openerp-web
Changed in openerp-web:
assignee: OpenERP R&D Addons Team 1 (openerp-dev-addons1) → OpenERP R&D Web Team (openerp-dev-web)
Revision history for this message
Bhumi Thakkar (Open ERP) (bth-openerp) wrote :

I checked patch of comment #2. I think this is right solution and this fixed problem. So I make a branch for trunk.

Changed in openerp-web:
status: Confirmed → Fix Committed
Changed in openerp-web:
assignee: OpenERP R&D Web Team (openerp-dev-web) → Fabien Meghazi (OpenERP) (fme)
Revision history for this message
vuong anh (anhdv) wrote :

After the bug is fix, I have an error when click "Save"

OpenErp Client Error

TypeError: self.ViewManager.ActionManager is undefined

http://113.160.16.218:8069/web/webclient/js?db=iErp4Postef:3455

(Very strange that it only happen with Centos 6.4, no matter with Windows)

Very appreciated if any help!

vuong anh (anhdv)
Changed in openerp-web:
status: Fix Committed → Incomplete
Changed in openerp-web:
status: Incomplete → Confirmed
Revision history for this message
Felix Schubert (input-fescon) wrote :

Still occurs and fix is not compatible with actual view.js

tags: added: maintenance
Revision history for this message
Mohammed Shekha(Open ERP) (msh-openerp) wrote :

Hello,

It has bee fixed and merged in revision 3888 for trunk version.

For stable 7.0 version it has been fixed in lp:~openerp-dev/openerp-web/7.0-opw-601491ContextGroupByPropagationIssue-msh.

Thanks.

Changed in ocb-web:
status: New → Incomplete
status: Incomplete → Confirmed
status: Confirmed → Fix Committed
Revision history for this message
siena (sienax) wrote :

tested given patch. now there is other issue with it lost all context.
Test scenario :
1 go to Sales/Customers
2 then in search area select group by country
3 click on any customer to open customer from
4 in customer form click on button Calls
expecting result should be calls for selected customer but shows all calls form all customers

im not an javascript developer but instead of :

context= _.reject(_.keys(context.eval()), function(key) {
   return key.match('group_by|group_by_no_leaf') !== null;
});

I added

 context.add({group_by:false});
 context.add({group_by_no_leaf:false});

and it helps

Revision history for this message
Martin Trigaux (OpenERP) (mat-openerp) wrote :

Hello,

We have backported in 7.0 a fix present in trunk.

revno: 4181 [merge]
revision-id: <email address hidden>

Regards

Revision history for this message
Bern Schneider (mia-11ngola) wrote :

Hi,

Thanks for this patch, this resolve the bug but all group by in dashbord are lost with this patch!!

Is there more solutions about that?

Thx,
Vitasoa

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.