l10n_es_bank_statement no reconcilia las remesas

Bug #838246 reported by Ignacio Ibeas (www.acysos.com)
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenERP Spanish Localization Project
Fix Released
High
Ignacio Ibeas (www.acysos.com)

Bug Description

Este bug afecta a dos módulos a l10n_es_bank_statement y nan_account_bank_statement.

En l10n_es_bank_statement hay que realizar un leve cambio en una línea. Este commit lo voy a realizar a continuación de este bug. Este commit no afecta al funcionamiento normal del módulo, pero es necesario para conciliar las remesas desde los extractos bancarios con norma 43, pero sin esta línea los cambios en el módulo de nan darán un error.

La parte que más afecta está en el módulo nan_account_bank_statement del que depende el primer módulo. Este módulo es de nan y no puedo modificarlo, pero adjunto aquí el patch que arregla el problema.
Este parche corrige la dependencia de objeto 'account.bank.statement.reconcile' de openerp 5.0 que ha sido cambiado a 'account_voucher' en openerp 6.0.

Saludos

Revision history for this message
Ignacio Ibeas (www.acysos.com) (ignacio-acysos) wrote :
Changed in openerp-spain:
assignee: nobody → Ignacio Ibeas (www.acysos.com) (ignacio-acysos)
importance: Undecided → High
Changed in openerp-spain:
status: New → In Progress
Revision history for this message
Ignacio Ibeas (www.acysos.com) (ignacio-acysos) wrote :
Revision history for this message
Jordi Esteve (www.zikzakmedia.com) (jesteve-zikzakmedia) wrote :

I also confirm the bug. I have checked the last patch of Ignacio and it works well.

I suggest to change these lines:

                    new_line_id = self.pool.get('account.bank.statement.line').copy(cr, uid, line.id, {
                        'account_id': reconcile_line.account_id.id,
                        'partner_id': reconcile_line.partner_id and reconcile_line.partner_id.id or None,
                        'amount': payment_order.type == 'receivable' and line_id.amount or -line_id.amount,
                        'voucher_id': voucher_id,
                    }, context)
                    self.write( cr, uid, [new_line_id], {
                        'voucher_id': voucher_id,
                        'account_id': reconcile_line.account_id.id,
                        'partner_id': reconcile_line.partner_id and reconcile_line.partner_id.id or False,
                        'type': account_type,
                    }, context )

to these ones because is more compact, we are copying and writing the same object:

                    new_line_id = self.copy(cr, uid, line.id, {
                        'account_id': reconcile_line.account_id.id,
                        'partner_id': reconcile_line.partner_id and reconcile_line.partner_id.id or False,
                        'amount': payment_order.type == 'receivable' and line_id.amount or -line_id.amount,
                        'voucher_id': voucher_id,
                        'type': account_type,
                    }, context)

I'll commit theses changes to nan_account_bank_statement if you agree.

Changed in openerp-spain:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.