Doesn't import orders because of "cod_fee = NULL"

Bug #1271537 reported by Jan-Philipp Fischer on 2014-01-22
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenERP Connector - Magento
Critical
Guewen Baconnier @ Camptocamp

Bug Description

There is a magento extention which is calles CashOnDelivery. This is done in Connector as well as far as I see.

But if no CashOnDelivery is selected the Magento API gives back a NULL Value.

Snippet from PHP API Request:
 ["cod_fee"]=> NULL ["base_cod_fee"]=> NULL ["cod_fee_invoiced"]=> NULL ["base_cod_fee_invoiced"]=> NULL ["cod_tax_amount"]=> NULL ["base_cod_tax_amount"]=> NULL ["cod_tax_amount_invoiced"]=> NULL ["base_cod_tax_amount_invoiced"]=> NULL

You can see: ["cod_fee"]=> NULL
but Connector expects a "float(record.get('cod_fee', 0.0)) TypeError: float() argument must be a
string or a number".

So I think there is the bug.

Revision Info of openerp-connector-magento: 952 launchpad_translations_on_behalf_of_openerp-connector-core-editors-20140117071004-k7rbd4qs9ih03f3p

Get all branches updated to newest version 3 hours ago.

Related branches

Changed in openerp-connector-magento:
status: New → Confirmed
importance: Undecided → Critical

Removing float funtion in Line 711,712 on sale.py seems to working. Can somebody confirm that?

On 01/22/2014 03:24 PM, Jan-Philipp Fischer wrote:
> Removing float funtion in Line 711,712 on sale.py seems to working. Can
> somebody confirm that?
>

Can you test my proposal?
https://code.launchpad.net/~camptocamp/openerp-connector-magento/7.0-cod-1271537/+merge/202680

Thanks!

- Guewen

Changed in openerp-connector-magento:
assignee: nobody → Guewen Baconnier @ Camptocamp (gbaconnier-c2c)

Tested. Looks good. Seems bug is fixed.

Thank you!

Released in 2.3.1

Changed in openerp-connector-magento:
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers