[PATCH] Add 'Local' to channel types (usecase described)

Bug #1180450 reported by Marcel van der Boom (HS-Development BV) on 2013-05-15
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenERP-Asterisk connector
Undecided
Unassigned

Bug Description

The channel type Local is missing from the list of possible types.

Patch is trivial:
=== modified file 'asterisk_click2dial/asterisk_click2dial.py'
--- asterisk_click2dial/asterisk_click2dial.py 2013-05-12 23:22:42 +0000
+++ asterisk_click2dial/asterisk_click2dial.py 2013-05-15 15:16:12 +0000
@@ -340,6 +340,7 @@
         'cdraccount': fields.char('CDR Account', size=50,
             help="Call Detail Record (CDR) account used for billing this user."),
         'asterisk_chan_type': fields.selection([
+ ('Local', 'Local'),
             ('SIP', 'SIP'),
             ('IAX2', 'IAX2'),
             ('DAHDI', 'DAHDI'),

The usecase we use this for is the following:

When using a dial button, I want all my devices to ring, let's say a desktop voip client and my desktop cisco phone.

The configuration I would want to use for that is to have in extension.conf a context such as:

[hsdev.com]
exten => marcel,1,Dial(SIP/824&SIP/825)

And configure OpenERP / User / Telephony as follows:

Channel: Local
Resource: <email address hidden>

The originate call will then ring both devices and I can choose which one to pick up from which to originate the call to the partner.

Is anything holding this back to be merged? The change is trivial.

Alexis de Lattre (alexis-via) wrote :

In fact, "Local" used to be available in the list of Channel types, but I removed it on 2013-04-15 in revno 80 following some tests I made on Asterisk 1.8 (it was not with OpenERP click2dial ; it was with a custom application). What I remember of these tests with "originate" request with "Local/phonenumber" is that I had very bad behavior when the user rejected the click2dial call.

But, if you are absolutely sure that "Local/phonenumber" works well in Originate requests, I can add it back.

It's certainly true that 'Local' is a bit special and, in general, needs special treatment in the dialplan. But I am sure it works, because we are using it in production now.

With 'reject' you mean just not pick up the phone, or actively issue a reject, in the form of a DND or something?

Do you recall what the bad behaviour was?

Alexis de Lattre (alexis-via) wrote :

I am some tests this afternoon and didn't experience any issue with Local/xx, so I just added it back.

But beware that it won't work for the feature "Open Calling partner".

Changed in openerp-asterisk-connector:
status: New → Fix Committed
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers