SCCP Patch

Bug #1007922 reported by daemon dog on 2012-06-02
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenERP-Asterisk connector
Wishlist
Alexis de Lattre

Bug Description

This adds code for SCCP, dial_postfix (SCCP auto answer) and makes some changes to the menus (I'm sure you can unpick them if you dont like them).

Add SCCP to selection list for asterisk channel types
Add dial_postfix support (aa=2wb for SCCP auto answer)
Strip (0) from phone numbers to prevent +CC (0).... becomming 00.... or 00CC0... (afaik all leading 0s (or national prefix) after CC should be stripped to properly follow current dial logic as national dial prefix automatically added back)
Move 'Sales/Address Book/Open calling partners' to 'Sales/Phone Calls/Open Calls'
Move 'Settings/Companies/Asterisk servers' to 'Settings/Configuration/Asterisk Servers/Asterisk Servers'

daemon dog (nodenet-1) wrote :
Alexis de Lattre (alexis-via) wrote :

Thanks for your interest in the OpenERP-Asterisk connector and thank you for your contribution !

I have a number of remarks/questions about your patch :

- line 8 / strip (0) from phone numbers : good idea, I'll take it

- line 19 : I would love to have more info about this dial_postfix ; could you point me to a web page that has some info about it ? Is it specific to SCCP ? Is it specific to a particular Cisco phone model ? Why do you name this parameter dial_postfix and not dial_suffix ?

- line 37 / add SCCP : OK

- line 48 : I am very much against starting every word with a capital letter. I know that OpenERP guys start every word with a capital letter, but my school lessons have always tought me to put a capital letter only on the first word. But I would love to get some pointers to a rule that say we should put a capital letter on every word in a software.

- line 57 / Move 'Settings/Companies/Asterisk servers' to 'Settings/Configuration/Asterisk Servers/Asterisk Servers' : you are right, it's more coherent to put it there.

- line 83 : why do you want to rename it ? I think that "Open calling partner" is more meaning full that "Open Calls". In fact, "Open Calls" in plural make me think "Open Call history"... it's misleading for me. Could you tell me why you would like such a change ?

- line 91 / Move 'Sales/Address Book/Open calling partners' to 'Sales/Phone Calls/Open Calls' : the "asterisk_click2dial" module only depends on "base", and the move you propose would make it depend on "crm" too ! I don't want the asterisk_click2dial module to depend on "crm"... only the module "asterisk_click2dial_crm" should depend on "crm".

I would love to get your feedback on my remarks.

Changed in openerp-asterisk-connector:
status: New → In Progress
importance: Undecided → Wishlist
assignee: nobody → Alexis de Lattre (alexis-via)
daemon dog (nodenet-1) wrote :

Thanks for your feedback.

- line 19

Unfortunately there isn't a great deal of information about this, you can see the original thread where I found this info at http://fonality.com/trixbox/forums/vendor-specific-unmoderated/linksys-cisco/sccp-and-paging

I believe this is specific to chan-sccp-b rather than a specific Cisco phone model, it may not be relevant to any other channel types (even skinny). I don't have enough experience of the other channel types to know for sure. It could be useful to apply this only for the relevant channel type(s) so it could be applied at the server level without unintentionally interfering with anything else.

afaik suffix and postfix are synonymous although to be honest it's really the extension suffix for the dial macro. You can put /aa=2wb after the extension number which will also cause the autodial to work for SCCP but it would break any exact matching of the extension such as performed by the Asterisk360 module. Of course my choice of naming is just whatever immediately sprang to mind at the time so may not necessarily be the best choice.

- line 48

I know sometimes there are style guides and similar documentation for layout / presentation etc. To be honest I didn't look for anything I was just trying to match the existing aesthetics. I think for the names of things such as headings that capitalising each word is acceptable. I've seen many inconsistencies in various documentation and software etc so can't really comment on whether it's definitely right or wrong though.

 - line 83 / 91

Please ignore this I'm also using the Asterisk 360 module which hides this menu item and when I forced an update on asterisk_click2dial module after adding the new fields above this menu option was restored. My patch included all the changes I made but I don't think this one is relevant.

Alexis de Lattre (alexis-via) wrote :

I just pushed your patch to the 6.1 branch, revno 54.

Changed in openerp-asterisk-connector:
status: In Progress → Fix Committed
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers