Bug #1800894 “Treat warning as errors on Windows” : Bugs : OpenContrail

Michał Cłapiński (michal.clapinski) on 2018-10-31

Changed in opencontrail:
assignee:	nobody → Michał Cłapiński (michal.clapinski)
status:	New → In Progress

Revision history for this message

OpenContrail Admin (ci-admin-f) wrote on 2018-10-31: [Review update] master

#1

Review in progress for https://review.opencontrail.org/47400
Submitter: Micha? C?api?ski (<email address hidden>)

Revision history for this message

OpenContrail Admin (ci-admin-f) wrote on 2018-10-31:

#2

Review in progress for https://review.opencontrail.org/47402
Submitter: Micha? C?api?ski (<email address hidden>)

Revision history for this message

OpenContrail Admin (ci-admin-f) wrote on 2018-10-31:

#3

Review in progress for https://review.opencontrail.org/47405
Submitter: Micha? C?api?ski (<email address hidden>)

Revision history for this message

OpenContrail Admin (ci-admin-f) wrote on 2018-10-31:

#4

Review in progress for https://review.opencontrail.org/47406
Submitter: Micha? C?api?ski (<email address hidden>)

Revision history for this message

OpenContrail Admin (ci-admin-f) wrote on 2018-11-02: A change has been merged

#7

Reviewed: https://review.opencontrail.org/47406
Committed: http://github.com/Juniper/contrail-windows/commit/e40146ee7322cc980d093520080092002e2ccef9
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit e40146ee7322cc980d093520080092002e2ccef9
Author: Michal Clapinski <email address hidden>
Date: Wed Oct 31 19:36:38 2018 +0100

Remove unused code

Change-Id: I034ef3b128f3a5ebece37ec903cb489c939fd1e5
Partial-Bug: #1800894

Revision history for this message

OpenContrail Admin (ci-admin-f) wrote on 2018-11-05:

#8

Reviewed: https://review.opencontrail.org/47400
Committed: http://github.com/Juniper/contrail-common/commit/f084fef6a738f0b320afa4ded8fea50c544fe87d
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit f084fef6a738f0b320afa4ded8fea50c544fe87d
Author: Michal Clapinski <email address hidden>
Date: Wed Oct 31 19:11:01 2018 +0100

Remove old leftover pragmas

Change-Id: Icadb1935596cf70c00614f75e2f112f8afa9d5de
Partial-Bug: #1800894

Revision history for this message

OpenContrail Admin (ci-admin-f) wrote on 2018-11-05:

#9

Reviewed: https://review.opencontrail.org/47402
Committed: http://github.com/Juniper/contrail-vrouter/commit/70383222ea7937219e9ba9bc68d0c577f783184a
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 70383222ea7937219e9ba9bc68d0c577f783184a
Author: Michal Clapinski <email address hidden>
Date: Wed Oct 31 19:14:10 2018 +0100

Fix warnings and treat warning as errors

Change-Id: I4ad042b1e82c5048193744223006ab26bd46688b
Partial-Bug: #1800894

Revision history for this message

OpenContrail Admin (ci-admin-f) wrote on 2018-11-06: [Review update] master

#10

Review in progress for https://review.opencontrail.org/47496
Submitter: Micha? C?api?ski (<email address hidden>)

Revision history for this message

OpenContrail Admin (ci-admin-f) wrote on 2018-11-06: A change has been merged

#11

Reviewed: https://review.opencontrail.org/47496
Committed: http://github.com/Juniper/contrail-windows/commit/d1ef3dc9fecfb817d9c63c6c485c459c70a3a2b5
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit d1ef3dc9fecfb817d9c63c6c485c459c70a3a2b5
Author: Michał Cłapiński <email address hidden>
Date: Tue Nov 6 10:40:24 2018 +0100

Fix undefined reference

Because of lack of a gate job, two changes merged that broke the master.
This change should fix it.

Change-Id: I6aadac70bc0c2fc1a48e0ec140c07af3322fc4d5
Partial-Bug: #1800894

Revision history for this message

OpenContrail Admin (ci-admin-f) wrote on 2018-12-07: [Review update] master

#12

Review in progress for https://review.opencontrail.org/48067
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message

OpenContrail Admin (ci-admin-f) wrote on 2018-12-10:

#14

Review in progress for https://review.opencontrail.org/48099
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message

OpenContrail Admin (ci-admin-f) wrote on 2018-12-13:

#15

Review in progress for https://review.opencontrail.org/48175
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message

OpenContrail Admin (ci-admin-f) wrote on 2018-12-20: A change has been merged

#17

Reviewed: https://review.opencontrail.org/48067
Committed: http://github.com/Juniper/contrail-common/commit/220c131c1fe48f9bb90cd9a1bfa4f3e2d02c4aa5
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 220c131c1fe48f9bb90cd9a1bfa4f3e2d02c4aa5
Author: Mateusz Jablonski <email address hidden>
Date: Fri Dec 7 10:46:40 2018 +0100

Fix compilation warnings for 'io' and 'sandesh'

- Add explicit casting where needed
- Change types
- Change friend function to templated function
- Fix whitespaces at end of lines

Change-Id: I3cb98e20e0d0bb7eb5fb14338a3954266f5762aa
Partial-Bug: #1800894

Revision history for this message

OpenContrail Admin (ci-admin-f) wrote on 2018-12-20:

#18

Reviewed: https://review.opencontrail.org/48099
Committed: http://github.com/Juniper/contrail-common/commit/a61610d3055fd14273d59b8c36b07a7a62bc6b7d
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit a61610d3055fd14273d59b8c36b07a7a62bc6b7d
Author: Mateusz Jablonski <email address hidden>
Date: Mon Dec 10 10:19:47 2018 +0100

Fix compilation warnings for 'base' directory

Change-Id: Id12cabee2bf52f3c99f82b994c100c41be1115f5
Partial-Bug: #1800894

Revision history for this message

OpenContrail Admin (ci-admin-f) wrote on 2018-12-21: [Review update] master

#19

Review in progress for https://review.opencontrail.org/48175
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message

OpenContrail Admin (ci-admin-f) wrote on 2018-12-21:

#20

Review in progress for https://review.opencontrail.org/48329
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message

OpenContrail Admin (ci-admin-f) wrote on 2018-12-21:

#21

Review in progress for https://review.opencontrail.org/48330
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message

OpenContrail Admin (ci-admin-f) wrote on 2018-12-21:

#22

Review in progress for https://review.opencontrail.org/48331
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message

OpenContrail Admin (ci-admin-f) wrote on 2018-12-21: A change has been merged

#23

Reviewed: https://review.opencontrail.org/48175
Committed: http://github.com/Juniper/contrail-controller/commit/4c1c07f1ac629167d8d02bf98d4f859f20fcf29d
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 4c1c07f1ac629167d8d02bf98d4f859f20fcf29d
Author: Mateusz Jablonski <email address hidden>
Date: Thu Dec 13 14:01:24 2018 +0100

Split flow management to multiple files

Change-Id: I7b9591584f9592571acbf2956296865efb530607
Partial-Bug: #1800894

Revision history for this message

OpenContrail Admin (ci-admin-f) wrote on 2018-12-23: [Review update] master

#24

Review in progress for https://review.opencontrail.org/48330
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message

OpenContrail Admin (ci-admin-f) wrote on 2018-12-23:

#25

Review in progress for https://review.opencontrail.org/48331
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message

OpenContrail Admin (ci-admin-f) wrote on 2019-01-02: A change has been merged

#26

Reviewed: https://review.opencontrail.org/48330
Committed: http://github.com/Juniper/contrail-controller/commit/5e87ecf2135a79ed493d29b6f20c498fd9ad7b0e
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 5e87ecf2135a79ed493d29b6f20c498fd9ad7b0e
Author: Mateusz Jablonski <email address hidden>
Date: Fri Dec 21 14:40:25 2018 +0100

Fix most of level 1 warnings on Windows

- Invalid escape sequence
- Invalid unused field and getter
- Invalid preprocessor usage
- Wrong type of field
- Missing return in non-void returning functions

Change-Id: Id54b649f32845130ea29f6663f98c1adf39d65da
Partial-Bug: #1800894

Revision history for this message

OpenContrail Admin (ci-admin-f) wrote on 2019-01-03: [Review update] master

#27

Review in progress for https://review.opencontrail.org/48429
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message

OpenContrail Admin (ci-admin-f) wrote on 2019-01-03:

#28

Review in progress for https://review.opencontrail.org/48430
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message

OpenContrail Admin (ci-admin-f) wrote on 2019-01-03:

#29

Review in progress for https://review.opencontrail.org/48435
Submitter: Michal Clapinski (<email address hidden>)

Revision history for this message

OpenContrail Admin (ci-admin-f) wrote on 2019-01-03:

#30

Review in progress for https://review.opencontrail.org/48441
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message

OpenContrail Admin (ci-admin-f) wrote on 2019-01-03:

#31

Review in progress for https://review.opencontrail.org/48361
Submitter: Michal Clapinski (<email address hidden>)

Revision history for this message

OpenContrail Admin (ci-admin-f) wrote on 2019-01-04:

#32

Review in progress for https://review.opencontrail.org/48441
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message

OpenContrail Admin (ci-admin-f) wrote on 2019-01-04:

#33

Review in progress for https://review.opencontrail.org/48464
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message

OpenContrail Admin (ci-admin-f) wrote on 2019-01-04:

#34

Review in progress for https://review.opencontrail.org/48467
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message

OpenContrail Admin (ci-admin-f) wrote on 2019-01-04:

#35

Review in progress for https://review.opencontrail.org/48468
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message

OpenContrail Admin (ci-admin-f) wrote on 2019-01-04:

#36

Review in progress for https://review.opencontrail.org/48469
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message

OpenContrail Admin (ci-admin-f) wrote on 2019-01-04: A change has been merged

#37

Reviewed: https://review.opencontrail.org/48331
Committed: http://github.com/Juniper/contrail-controller/commit/68241e3400d6092a35ec2f6b4441c00a6cf6cc4e
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 68241e3400d6092a35ec2f6b4441c00a6cf6cc4e
Author: Mateusz Jablonski <email address hidden>
Date: Fri Dec 21 14:52:56 2018 +0100

Fix warning related to not called destructor

Change-Id: Ic30b29e43ec7d1270cf90f0ba3387a22971ee05d
Partial-Bug: #1800894

Revision history for this message

OpenContrail Admin (ci-admin-f) wrote on 2019-01-07: [Review update] master

#38

Review in progress for https://review.opencontrail.org/48503
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message

OpenContrail Admin (ci-admin-f) wrote on 2019-01-07:

#39

Review in progress for https://review.opencontrail.org/48506
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message

OpenContrail Admin (ci-admin-f) wrote on 2019-01-07:

#40

Review in progress for https://review.opencontrail.org/48329
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message

OpenContrail Admin (ci-admin-f) wrote on 2019-01-07:

#41

Review in progress for https://review.opencontrail.org/48506
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message

OpenContrail Admin (ci-admin-f) wrote on 2019-01-07:

#42

Review in progress for https://review.opencontrail.org/48503
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message

OpenContrail Admin (ci-admin-f) wrote on 2019-01-08:

#43

Review in progress for https://review.opencontrail.org/48464
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message

OpenContrail Admin (ci-admin-f) wrote on 2019-01-08:

#44

Review in progress for https://review.opencontrail.org/48441
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message

OpenContrail Admin (ci-admin-f) wrote on 2019-01-08:

#45

Review in progress for https://review.opencontrail.org/48549
Submitter: Arun RS (<email address hidden>)

Revision history for this message

OpenContrail Admin (ci-admin-f) wrote on 2019-01-08:

#46

Review in progress for https://review.opencontrail.org/48506
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message

OpenContrail Admin (ci-admin-f) wrote on 2019-01-08:

#47

Review in progress for https://review.opencontrail.org/48556
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message

OpenContrail Admin (ci-admin-f) wrote on 2019-01-11:

#48

Review in progress for https://review.opencontrail.org/48329
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message

OpenContrail Admin (ci-admin-f) wrote on 2019-01-13:

#49

Review in progress for https://review.opencontrail.org/48506
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message

OpenContrail Admin (ci-admin-f) wrote on 2019-01-18: A change has been merged

#50

Reviewed: https://review.opencontrail.org/48435
Committed: http://github.com/Juniper/contrail-api-client/commit/659044fc0f635858224fff9b11cfa97188422dda
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 659044fc0f635858224fff9b11cfa97188422dda
Author: Michal Clapinski <email address hidden>
Date: Thu Jan 3 15:40:52 2019 +0000

Fix warning related to missing consts

Change-Id: I618e4c0d517aa4375a5f1fcdce23c8b20da45a9e
Partial-Bug: #1800894

Revision history for this message

OpenContrail Admin (ci-admin-f) wrote on 2019-01-18:

#51

Reviewed: https://review.opencontrail.org/48556
Committed: http://github.com/Juniper/contrail-common/commit/870474906715e142099d3d181cad6e74be35247d
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 870474906715e142099d3d181cad6e74be35247d
Author: Mateusz Jablonski <email address hidden>
Date: Tue Jan 8 17:06:16 2019 +0100

Fix warnings: comparison between signed and unsigned integer

Change-Id: I3758f57ac0fd6029728543e30eb52c974e34102e
Partial-Bug: #1800894

Revision history for this message

OpenContrail Admin (ci-admin-f) wrote on 2019-01-18: [Review update] master

#52

Review in progress for https://review.opencontrail.org/48329
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message

OpenContrail Admin (ci-admin-f) wrote on 2019-01-18:

#53

Review in progress for https://review.opencontrail.org/48430
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message

OpenContrail Admin (ci-admin-f) wrote on 2019-01-18:

#54

Review in progress for https://review.opencontrail.org/48429
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message

OpenContrail Admin (ci-admin-f) wrote on 2019-01-18: A change has been merged

#55

Reviewed: https://review.opencontrail.org/48361
Committed: http://github.com/Juniper/contrail-controller/commit/0dc3ef2f499d7d5320ecb418f2caf1a3a97cb029
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 0dc3ef2f499d7d5320ecb418f2caf1a3a97cb029
Author: Michal Clapinski <email address hidden>
Date: Mon Dec 24 21:52:09 2018 +0000

Remove unused variables

Change-Id: I49c5e50032038a603740a13aebcf71dd8e19693a
Partial-Bug: #1800894

Revision history for this message

OpenContrail Admin (ci-admin-f) wrote on 2019-01-18:

#56

Reviewed: https://review.opencontrail.org/48329
Committed: http://github.com/Juniper/contrail-common/commit/467acae273394e9810300397b24faa059874d8ed
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 467acae273394e9810300397b24faa059874d8ed
Author: Mateusz Jablonski <email address hidden>
Date: Fri Dec 21 13:31:08 2018 +0100

Fix warnings related to type conversion

Change-Id: I76babc1424808749ca4e0260c9d964f8c7becf59
Partial-Bug: #1800894

Revision history for this message

OpenContrail Admin (ci-admin-f) wrote on 2019-01-18:

#57

Reviewed: https://review.opencontrail.org/48429
Committed: http://github.com/Juniper/contrail-common/commit/f5905df29183fe83a068a2336a5cd6831b9841e7
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit f5905df29183fe83a068a2336a5cd6831b9841e7
Author: Mateusz Jablonski <email address hidden>
Date: Thu Jan 3 13:04:50 2019 +0100

Use semicolons properly with 'while(false)' in macros

Change-Id: I0578486b681c284ce66f8933e2d7fb5d875e2b08
Partial-Bug: #1800894

Revision history for this message

OpenContrail Admin (ci-admin-f) wrote on 2019-01-19:

#58

Reviewed: https://review.opencontrail.org/48430
Committed: http://github.com/Juniper/contrail-controller/commit/0abd60e850cfeb6fe0a47ad1647a6bfa459383e6
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 0abd60e850cfeb6fe0a47ad1647a6bfa459383e6
Author: Mateusz Jablonski <email address hidden>
Date: Thu Jan 3 13:21:53 2019 +0100

Use semicolons properly with 'while (false)' in macros

Change-Id: I7c51d830f210f1be0905be471e47b48891a5f0dc
Partial-Bug: #1800894

Revision history for this message

OpenContrail Admin (ci-admin-f) wrote on 2019-01-22: [Review update] master

#59

Review in progress for https://review.opencontrail.org/48825
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message

OpenContrail Admin (ci-admin-f) wrote on 2019-01-22: A change has been merged

#61

Reviewed: https://review.opencontrail.org/48441
Committed: http://github.com/Juniper/contrail-common/commit/4a75e5f8bd746f65da69a154312ef27286f9147f
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 4a75e5f8bd746f65da69a154312ef27286f9147f
Author: Mateusz Jablonski <email address hidden>
Date: Thu Jan 3 17:49:07 2019 +0100

Refactor base/timer*

- Remove support for old boost (<1.49)
- Remove usage of auto_ptr
- Remove friend declarations

Change-Id: Ibb1089d108be3eb2909869fe9936cccb2910868e
Partial-Bug: #1800894

Revision history for this message

OpenContrail Admin (ci-admin-f) wrote on 2019-01-22:

#62

Reviewed: https://review.opencontrail.org/48464
Committed: http://github.com/Juniper/contrail-common/commit/e922fdd98b877ee2d841de8e15acaaef70f9a178
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit e922fdd98b877ee2d841de8e15acaaef70f9a178
Author: Mateusz Jablonski <email address hidden>
Date: Fri Jan 4 10:34:10 2019 +0100

Fix type conversion related warnings in base/timer*

Change-Id: Id64e160aa728976749319f37939ee3ae709e8c08
Partial-Bug: #1800894

Revision history for this message

OpenContrail Admin (ci-admin-f) wrote on 2019-01-23: [Review update] master

#63

Review in progress for https://review.opencontrail.org/48506
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message

OpenContrail Admin (ci-admin-f) wrote on 2019-01-24:

#64

Review in progress for https://review.opencontrail.org/48877
Submitter: Arun RS (<email address hidden>)

Revision history for this message

OpenContrail Admin (ci-admin-f) wrote on 2019-01-24:

#65

Review in progress for https://review.opencontrail.org/48467
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message

OpenContrail Admin (ci-admin-f) wrote on 2019-01-28:

#66

Review in progress for https://review.opencontrail.org/48469
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message

OpenContrail Admin (ci-admin-f) wrote on 2019-01-29: A change has been merged

#67

Reviewed: https://review.opencontrail.org/48467
Committed: http://github.com/Juniper/contrail-common/commit/4d9961e43caa89ec08c907ac49ae6f5fa3bcc09d
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 4d9961e43caa89ec08c907ac49ae6f5fa3bcc09d
Author: Mateusz Jablonski <email address hidden>
Date: Fri Jan 4 11:32:11 2019 +0100

Fix type conversion related warnings in base/task*

Change-Id: I2b4ba7fbeccd4128e8b23d408fa999d15b245fcb
Partial-Bug: #1800894

Revision history for this message

OpenContrail Admin (ci-admin-f) wrote on 2019-01-29:

#68

Reviewed: https://review.opencontrail.org/48469
Committed: http://github.com/Juniper/contrail-controller/commit/553828ebafc447d571673cafdbb948ec35866425
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 553828ebafc447d571673cafdbb948ec35866425
Author: Mateusz Jablonski <email address hidden>
Date: Fri Jan 4 12:30:59 2019 +0100

Fix type conversion related warnings for common/base/task*

Change-Id: I5d05594649a71438204e231b222abe46ee8034b5
Depends-On: I2b4ba7fbeccd4128e8b23d408fa999d15b245fcb
Partial-Bug: #1800894

Revision history for this message

OpenContrail Admin (ci-admin-f) wrote on 2019-01-29:

#69

Reviewed: https://review.opencontrail.org/48825
Committed: http://github.com/Juniper/contrail-common/commit/9893a40550fe794cbf484669d6048fa745c916a7
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 9893a40550fe794cbf484669d6048fa745c916a7
Author: Mateusz Jablonski <email address hidden>
Date: Tue Jan 22 12:48:08 2019 +0100

Add comment about incorrect definition of __cplusplus in MSVC

Change-Id: I79420b57880b7a0a9827c17539ab0a541c5f5715
Partial-Bug: #1800894

Revision history for this message

OpenContrail Admin (ci-admin-f) wrote on 2019-01-30: [Review update] master

#70

Review in progress for https://review.opencontrail.org/48506
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message

OpenContrail Admin (ci-admin-f) wrote on 2019-01-30:

#71

Review in progress for https://review.opencontrail.org/48503
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message

OpenContrail Admin (ci-admin-f) wrote on 2019-01-30:

#72

Review in progress for https://review.opencontrail.org/49010
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message

OpenContrail Admin (ci-admin-f) wrote on 2019-02-05: A change has been merged

#73

Reviewed: https://review.opencontrail.org/49010
Committed: http://github.com/Juniper/contrail-common/commit/bafda324ce7fd1c4f4ae43972fdac60b7e66628e
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit bafda324ce7fd1c4f4ae43972fdac60b7e66628e
Author: Mateusz Jablonski <email address hidden>
Date: Wed Jan 30 12:19:05 2019 +0100

Partially fix formatting in sandesh/compiler/generate/*

Change-Id: Icc2edf2aa709e4be56fca4cfc4adb5c5849df0c3
Partial-Bug: #1800894

Revision history for this message

OpenContrail Admin (ci-admin-f) wrote on 2019-02-19:

#74

Reviewed: https://review.opencontrail.org/48503
Committed: http://github.com/Juniper/contrail-common/commit/97a14125a5d4046a407c2659554152bef12f8043
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 97a14125a5d4046a407c2659554152bef12f8043
Author: Mateusz Jablonski <email address hidden>
Date: Mon Jan 7 10:20:01 2019 +0100

Partially fix formatting in sandesh/compiler/generate/*

Change-Id: Ibc90e7f360152c05c11a9e8ec98b225ffff113ef
Partial-Bug: #1800894

Revision history for this message

OpenContrail Admin (ci-admin-f) wrote on 2019-02-20:

#75

Download full text (6.7 KiB)

Reviewed: https://review.opencontrail.org/49390
Committed: http://github.com/Juniper/contrail-common/commit/fe6ebdaec8e7c90d91c49ba344a59b42f452b8bd
Submitter: Vinay Vithal Mahuli (<email address hidden>)
Branch: R6.0-WIP

commit fe6ebdaec8e7c90d91c49ba344a59b42f452b8bd
Author: mkheni <email address hidden>
Date: Thu Nov 8 13:23:42 2018 -0800

Apply commits from master onto R6.0-WIP

Initliaze Sandesh Collector on given IP.
if not ip is provided, listen on 0.0.0.0
Partial-bug: #1802399

Contrail Stats to external Stats Collector
User can provide external collector (ip:port or local domain socket),
If the external collector is provided, contrail generators will
send the UVEs converted into JSON format to the external collector
in addition to the Contrail Collector.
Closes-bug: #1793204

Check build dependencies for Sandesh
Partial-Bug: #1806719

Fix compilation warnings for 'io' and 'sandesh'
- Add explicit casting where needed
- Change types
- Change friend function to templated function
- Fix whitespaces at end of lines
Partial-Bug: #1800894

Fix compilation warnings for 'base' directory
Partial-Bug: #1800894

ParseInt function should check for Uint also
Rapidjson sets the flag of type UnsingedInt if the MSB
is set. While retrieving such values, we need to check
for Uint values also.
Closes-Bug: #218680

Make sandesh and ssl talk TLSv1.2
Use SSLv23 client and server for SSL connections and disable the more vulnerable
versions thereby ensuring the communication happens only on TLSv1.2
This ensures introspect and sandesh services now use TLS v1.2
Partial-Bug: #1807296

JSON encoding of the sandesh UVE messages
This fix adds the file wihch provides implementation of
transport API's exposed. The transport API's will be called
by the generated sandesh code.
UT added for the JSON generator. Currently the validity of
the JSON was checked with online tools. Holding the
verification part until we export a JSON library to sandesh.
Code Change:
JSON encoding unlike the XML encoding uses comma seperation
for members, string values for keys and {} enclosure for
complex types. To accomodate this following data structure
were introduced:
A vector to keep track of the element we are currently encoding
and whether its a first member of the familt or not:
Here is an example:
If we are encoding a list within sandesh structure,
current_sandesh_context_ maintains the following members in its
list viz., sandesh->struct_s1->list_l1
is_first_element_list_ maintains whether we are processing first
list element or we not.If we were in the middle of the list,
the structure is_first_element_list_ will be as follows:
true->false->false
Here the first false, indicates that list is not the first
member of the struct and the second false indicates that we
are done encoding the first element of the list.
Partial-Bug: 1789312

Do not resolve 127.*.*.* ip to names
DNS reverse resolution some times can take seconds.. Most of BGP and XMPP UTs
run over 127...* addresses and run timers in milliseconds. If asynchronous IO
operations do not complete very fast, then they are teared down and new ones
are created. Hence, hard-code 127.* addresses to localhost.
Also mark an arg in se...

Reviewed:  https://review.opencontrail.org/49390
Committed: http://github.com/Juniper/contrail-common/commit/fe6ebdaec8e7c90d91c49ba344a59b42f452b8bd
Submitter: Vinay Vithal Mahuli (vmahuli@juniper.net)
Branch:    R6.0-WIP

commit fe6ebdaec8e7c90d91c49ba344a59b42f452b8bd
Author: mkheni <mkheni@juniper.net>
Date:   Thu Nov 8 13:23:42 2018 -0800

Apply commits from master onto R6.0-WIP

Initliaze Sandesh Collector on given IP.
if not ip is provided, listen on 0.0.0.0
Partial-bug: #1802399

Contrail Stats to external Stats Collector
User can provide external collector (ip:port or local domain socket),
If the external collector  is provided, contrail generators will
send the UVEs converted into JSON format to the external collector
in addition to the Contrail Collector.
Closes-bug: #1793204

Check build dependencies for Sandesh
Partial-Bug: #1806719

Fix compilation warnings for 'io' and 'sandesh'
- Add explicit casting where needed
- Change types
- Change friend function to templated function
- Fix whitespaces at end of lines
Partial-Bug: #1800894

Fix compilation warnings for 'base' directory
Partial-Bug: #1800894

ParseInt function should check for Uint also
Rapidjson sets the flag of type UnsingedInt if the MSB
is set. While retrieving such values, we need to check
for Uint values also.
Closes-Bug: #218680

Make sandesh and ssl talk TLSv1.2
Use SSLv23 client and server for SSL connections and disable the more vulnerable
versions thereby ensuring the communication happens only on TLSv1.2
This ensures introspect and sandesh services now use TLS v1.2
Partial-Bug: #1807296

JSON encoding of the sandesh UVE messages
This fix adds the file wihch provides implementation of
transport API's exposed. The transport API's will be called
by the generated sandesh code.
UT added for the JSON generator. Currently the validity of
the JSON was checked with online tools. Holding the
verification part until we export a JSON library to sandesh.
Code Change:
JSON encoding unlike the XML encoding uses comma seperation
for members, string values for keys and {} enclosure for
complex types. To accomodate this following data structure
were introduced:
A vector to keep track of the element we are currently encoding
and whether its a first member of the familt or not:
Here is an example:
If we are encoding a list within sandesh structure,
current_sandesh_context_ maintains the following members in its
list viz., sandesh->struct_s1->list_l1
is_first_element_list_ maintains whether we are processing first
list element or we not.If we were in the middle of the list,
the structure is_first_element_list_ will be as follows:
true->false->false
Here the first false, indicates that list is not the first
member of the struct and the second false indicates that we
are done encoding the first element of the list.
Partial-Bug: 1789312

Do not resolve 127.*.*.* ip to names
DNS reverse resolution some times can take seconds.. Most of BGP and XMPP UTs
run over 127...* addresses and run timers in milliseconds. If asynchronous IO
operations do not complete very fast, then they are teared down and new ones
are created. Hence, hard-code 127.* addresses to localhost.
Also mark an arg in set_sychronize() as const.
Closes Jira Bug: CBS-6

Refactor base/timer*
- Remove support for old boost (<1.49)
- Remove usage of auto_ptr
- Remove friend declarations
Partial-Bug: #1800894

Fix type conversion related warnings in base/timer*
Partial-Bug: #1800894

Fix warnings: comparison between signed and unsigned integer
Partial-Bug: #1800894

Python JSON encoding of the sandesh UVE messages
This fix adds the file wihch provides implementation of
transport API's exposed. The transport API's will be called
by the generated sandesh code.
UT added for the JSON generator. Currently the validity of
the JSON was checked with online tools. Holding the
verification part until we export a JSON library to sandesh.
Code Change:
JSON encoding unlike the XML encoding uses comma seperation
for members, string values for keys and {} enclosure for
complex types. To accomodate this following data structure
were introduced:
A vector to keep track of the element we are currently encoding
and whether its a first member of the familt or not:
Here is an example:
If we are encoding a list within sandesh structure,
current_sandesh_context_ maintains the following members in its
list viz., sandesh->struct_s1->list_l1
is_first_element_list_ maintains whether we are processing first
list element or we not.If we were in the middle of the list,
the structure is_first_element_list_ will be as follows:
true->false->false
Here the first false, indicates that list is not the first
member of the struct and the second false indicates that we
are done encoding the first element of the list.
Partial-Bug: 1789312

Support host check for SSL nova metadata
- for peer check there should be host name
is used in url
partial-jira-bug: JCB-218839

Fix warnings related to type conversion
Partial-Bug: #1800894

Use semicolons properly with 'while(false)' in macros
Partial-Bug: #1800894

HTTP  parsing logic changed
Previous parsing of the URL assumed that all the
entities will be in the same order always
but that can not always be the case.
Current fix parses the request and fills the
entity values as and when they are found in the request
DocImpact
Closes-bug: #1796870
closes-jira-bug: JCB-281081
enter the commit message for your changes. Lines starting

Use fqdn in CreateConnection for http
- it for peers verifications in SSl case with FQDNs
partial-jira-bug: JCB-218839

remove old constructor for CqlIf
this commit removes old constructor for CqlIf cause all changes
was made across all repositories and it's not needed now.
closes-jira-bug: JCB-218753

Add comment about incorrect definition of __cplusplus in MSVC
Partial-Bug: #1800894

Fix type conversion related warnings in base/task*
Partial-Bug: #1800894

Handle setting socket file as stats collector
A Core was seen when setting socket file as stats_collector
Instead of doing try...catch to figure out whether the stats_collector
is a socket file or ip,port, simply look for a ':' in the string
closes-jira-bug: JCB-218930

Partially fix formatting in sandesh/compiler/generate/*
Partial-Bug: #1800894

Contrail Stats to External Collector - Python Client
User can provide external collector (ip:port or local domain socket),
If the external collector  is provided, contrail generators will
send the UVEs converted into JSON format to the external collector
in addition to the Contrail Collector.
Closes-bug: #1793204

cpuinfo changes for windows : new windows specific code as well as refactoring
Partial-Bug: #1803774

Change-Id: Icd111bf92e4656fe7187726cd95ceabb80b9415f
Depends-on: I2a0b02bb4a29601025e1afb6a696baf031375c4b
Partial-jira-bug: JBE-925

Revision history for this message

OpenContrail Admin (ci-admin-f) wrote on 2019-02-20:

#77

Download full text (37.3 KiB)

Reviewed: https://review.opencontrail.org/49393
Committed: http://github.com/Juniper/contrail-controller/commit/77df3b58265b3fab414dfbc00e1ff39d19f0a99c
Submitter: Zuul v3 CI (<email address hidden>)
Branch: R6.0-WIP

commit 77df3b58265b3fab414dfbc00e1ff39d19f0a99c
Author: Shivayogi Ugaji <email address hidden>
Date: Mon Nov 5 22:07:18 2018 -0800

Apply commits from master onto R6.0-WIP

db_resync_done lock is used to indicate the amqp thread to wait for resync to
complete. In this case, when we call SchemaTransformer.destroy_instance()
due to Casandra connection failure, this lock remains locked blocking
destroy_instance. destroy_instance calls _vnc_subscribe_callback to drain the
amqp queue which waits infinitely for db_resync_done lock to be released.
This fix releases db_resync_done lock so that destroy_instance doesnt get
blocked.
Closes-Bug: #1801474

[DM] Hitless image upgrade implementation
Closes-Bug: #1799322

Provisioner for the devicemanager node.
usage:
from /opt/contrail/utils
python provision_devicemgr_node.py --host_name aio --host_ip 10.87.82.2
--oper add --admin_user admin --admin_password contrail123 --admin_tenant_name
admin --openstack_ip 10.87.82.2 --api_server_ip 10.87.82.2
Closes-Bug: #1805303

CFM: Changes for onboarding L3PNF
- Add new platform SRX240
- Add L3PNF subnet is schema
- Add new namespace, VN and IPAM for L3PNF during brownfield onboarding
Closes-Bug: 1800701

Add entrypoint to vrouter-agent service on Windows
Introduce entrypoint for agent similar in design to that from
microservice deployment. For now it will only start agent,
actual features will be added in following changes.
Partial-Bug: #1806677

Check build dependencies for tbb, SimpleAmqpClient and rabbitmq
Closes-Bug: #1806719

Make agent's entrypoint update agent's config on Windows
In future we will generate the whole config from scratch
as on Linux, but for now we only update the vhost's ifname.
It's the only field that can change upon restart.
Partial-Bug: #1806677

bgp-peer selection support for bgpaas
1. Listener BgpRouterConfig is added for BgpRouter and ControlNodeZone
2. BgpRouterConfig builds BgpRouterTree and ControlNodeZoneTree
from IFMapNode
3. BGPaaS gets BgpRouter for configured ControlNodeZone from
BgpRouterConfig and Updates bgp-peer-ip and bgp-peer-port in
the flow.
4. Step 3 is followed for xmpp based peer-selection also.
5. BGPaaS sandesh is updated with primary_control_node_zone,
secondary_control_node_zone, bgp_peer_ip and bgp_peer_port
Partial-bug: #1775872

[DM] Inside-outside workflow - lag/mH
1. Change the exisiting business logic to adhere to the new data model for lag/mH workflow
2. Multi-vlan support
Partial-Bug: #1799329

Rework nodemgr before fixing ntp issue
- move windows/linux code to separate classes instead of same condition through the code
- simplify main.py
- remove copy duplication
Closes-Bug: 1800704

[fabric] Added playbook retry support to job manager
1) When playbook return retry_devices in the output, job manager will retry the playbooks against those devices
2) remove obsolete playbooks from 5.0
3) remove obsolete ansible roles from 5.0
4) added a warning log on missing loopback interface when ...

Reviewed:  https://review.opencontrail.org/49393
Committed: http://github.com/Juniper/contrail-controller/commit/77df3b58265b3fab414dfbc00e1ff39d19f0a99c
Submitter: Zuul v3 CI (zuulv3@zuul.opencontrail.org)
Branch:    R6.0-WIP

commit 77df3b58265b3fab414dfbc00e1ff39d19f0a99c
Author: Shivayogi Ugaji <yogi@juniper.net>
Date:   Mon Nov 5 22:07:18 2018 -0800