Treat warning as errors on Windows

[Michał Cłapiński]

During compilation warnings should be treated as errors.

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/47400
Submitter: Micha? C?api?ski (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/47402
Submitter: Micha? C?api?ski (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/47405
Submitter: Micha? C?api?ski (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/47406
Submitter: Micha? C?api?ski (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/47406
Committed: http://github.com/Juniper/contrail-windows/commit/e40146ee7322cc980d093520080092002e2ccef9
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit e40146ee7322cc980d093520080092002e2ccef9
Author: Michal Clapinski <email address hidden>
Date: Wed Oct 31 19:36:38 2018 +0100

Remove unused code

Change-Id: I034ef3b128f3a5ebece37ec903cb489c939fd1e5
Partial-Bug: #1800894

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/47400
Committed: http://github.com/Juniper/contrail-common/commit/f084fef6a738f0b320afa4ded8fea50c544fe87d
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit f084fef6a738f0b320afa4ded8fea50c544fe87d
Author: Michal Clapinski <email address hidden>
Date: Wed Oct 31 19:11:01 2018 +0100

Remove old leftover pragmas

Change-Id: Icadb1935596cf70c00614f75e2f112f8afa9d5de
Partial-Bug: #1800894

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/47402
Committed: http://github.com/Juniper/contrail-vrouter/commit/70383222ea7937219e9ba9bc68d0c577f783184a
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 70383222ea7937219e9ba9bc68d0c577f783184a
Author: Michal Clapinski <email address hidden>
Date: Wed Oct 31 19:14:10 2018 +0100

Fix warnings and treat warning as errors

Change-Id: I4ad042b1e82c5048193744223006ab26bd46688b
Partial-Bug: #1800894

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/47496
Submitter: Micha? C?api?ski (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/47496
Committed: http://github.com/Juniper/contrail-windows/commit/d1ef3dc9fecfb817d9c63c6c485c459c70a3a2b5
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit d1ef3dc9fecfb817d9c63c6c485c459c70a3a2b5
Author: Michał Cłapiński <email address hidden>
Date: Tue Nov 6 10:40:24 2018 +0100

Fix undefined reference

Because of lack of a gate job, two changes merged that broke the master.
This change should fix it.

Change-Id: I6aadac70bc0c2fc1a48e0ec140c07af3322fc4d5
Partial-Bug: #1800894

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/48067
Submitter: Mateusz Jablonski (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/48099
Submitter: Mateusz Jablonski (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/48175
Submitter: Mateusz Jablonski (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/48067
Committed: http://github.com/Juniper/contrail-common/commit/220c131c1fe48f9bb90cd9a1bfa4f3e2d02c4aa5
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 220c131c1fe48f9bb90cd9a1bfa4f3e2d02c4aa5
Author: Mateusz Jablonski <email address hidden>
Date: Fri Dec 7 10:46:40 2018 +0100

Fix compilation warnings for 'io' and 'sandesh'

- Add explicit casting where needed
- Change types
- Change friend function to templated function
- Fix whitespaces at end of lines

Change-Id: I3cb98e20e0d0bb7eb5fb14338a3954266f5762aa
Partial-Bug: #1800894

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/48099
Committed: http://github.com/Juniper/contrail-common/commit/a61610d3055fd14273d59b8c36b07a7a62bc6b7d
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit a61610d3055fd14273d59b8c36b07a7a62bc6b7d
Author: Mateusz Jablonski <email address hidden>
Date: Mon Dec 10 10:19:47 2018 +0100

Fix compilation warnings for 'base' directory

Change-Id: Id12cabee2bf52f3c99f82b994c100c41be1115f5
Partial-Bug: #1800894

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/48175
Submitter: Mateusz Jablonski (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/48329
Submitter: Mateusz Jablonski (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/48330
Submitter: Mateusz Jablonski (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/48331
Submitter: Mateusz Jablonski (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/48175
Committed: http://github.com/Juniper/contrail-controller/commit/4c1c07f1ac629167d8d02bf98d4f859f20fcf29d
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 4c1c07f1ac629167d8d02bf98d4f859f20fcf29d
Author: Mateusz Jablonski <email address hidden>
Date: Thu Dec 13 14:01:24 2018 +0100

Split flow management to multiple files

Change-Id: I7b9591584f9592571acbf2956296865efb530607
Partial-Bug: #1800894

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/48330
Submitter: Mateusz Jablonski (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/48331
Submitter: Mateusz Jablonski (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/48330
Committed: http://github.com/Juniper/contrail-controller/commit/5e87ecf2135a79ed493d29b6f20c498fd9ad7b0e
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 5e87ecf2135a79ed493d29b6f20c498fd9ad7b0e
Author: Mateusz Jablonski <email address hidden>
Date: Fri Dec 21 14:40:25 2018 +0100

Fix most of level 1 warnings on Windows

- Invalid escape sequence
- Invalid unused field and getter
- Invalid preprocessor usage
- Wrong type of field
- Missing return in non-void returning functions

Change-Id: Id54b649f32845130ea29f6663f98c1adf39d65da
Partial-Bug: #1800894

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/48429
Submitter: Mateusz Jablonski (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/48430
Submitter: Mateusz Jablonski (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/48435
Submitter: Michal Clapinski (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/48441
Submitter: Mateusz Jablonski (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/48361
Submitter: Michal Clapinski (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/48441
Submitter: Mateusz Jablonski (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/48464
Submitter: Mateusz Jablonski (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/48467
Submitter: Mateusz Jablonski (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/48468
Submitter: Mateusz Jablonski (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/48469
Submitter: Mateusz Jablonski (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/48331
Committed: http://github.com/Juniper/contrail-controller/commit/68241e3400d6092a35ec2f6b4441c00a6cf6cc4e
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 68241e3400d6092a35ec2f6b4441c00a6cf6cc4e
Author: Mateusz Jablonski <email address hidden>
Date: Fri Dec 21 14:52:56 2018 +0100

Fix warning related to not called destructor

Change-Id: Ic30b29e43ec7d1270cf90f0ba3387a22971ee05d
Partial-Bug: #1800894

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/48503
Submitter: Mateusz Jablonski (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/48506
Submitter: Mateusz Jablonski (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/48329
Submitter: Mateusz Jablonski (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/50849
Submitter: Mateusz Jablonski (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/50871
Submitter: Mateusz Jablonski (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/50851
Submitter: Mateusz Jablonski (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/50850
Submitter: Mateusz Jablonski (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/50854
Submitter: Mateusz Jablonski (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/50993
Submitter: Mateusz Jablonski (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/50871
Committed: http://github.com/Juniper/contrail-vrouter/commit/657ae7db3fd48ac8d30ebd5d6b6b8923b6500084
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 657ae7db3fd48ac8d30ebd5d6b6b8923b6500084
Author: Mateusz Jablonski <email address hidden>
Date: Thu Apr 18 15:30:04 2019 +0200

Fix formatting in dp-core

Change-Id: I821e2974c4bf649770649baef835fed2c58b34de
Partial-Bug: #1800894

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/50996
Submitter: Mateusz Jablonski (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/50997
Submitter: Mateusz Jablonski (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/50998
Submitter: Mateusz Jablonski (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/50999
Submitter: Mateusz Jablonski (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/51000
Submitter: Mateusz Jablonski (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/50714
Committed: http://github.com/Juniper/contrail-common/commit/1b448d4c471b7beddd002105df5cb72b0952f833
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 1b448d4c471b7beddd002105df5cb72b0952f833
Author: Mateusz Jablonski <email address hidden>
Date: Tue Apr 9 17:39:19 2019 +0200

Remove code duplication from generate_struct_writer and generate_sandesh_writer

Introduce generate_common_struct_writer_body and
move code responsible for method body generation there.

Change-Id: I38c076320afc4cd24e32e26fa7350826d81a810e
Partial-Bug: #1800894

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/50866
Committed: http://github.com/Juniper/contrail-controller/commit/1abaa4ef883c877726d026bdcc630b8e51dececd
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 1abaa4ef883c877726d026bdcc630b8e51dececd
Author: Mateusz Jablonski <email address hidden>
Date: Thu Apr 18 12:06:12 2019 +0200

Fix warning about returning int when bool is expected

Change-Id: I8173095c1855c80b12a3d781ddfa1c2a23ac50e8
Partial-Bug: #1800894

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/50999
Committed: http://github.com/Juniper/contrail-analytics/commit/ff0d194b186d0b7a8d253f2c08cb10ba4b98d4d0
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit ff0d194b186d0b7a8d253f2c08cb10ba4b98d4d0
Author: Mateusz Jablonski <email address hidden>
Date: Tue Apr 23 16:38:26 2019 +0200

Fix formatting in all '.sandesh' files in contrail-analytics

Change-Id: I59e008119f0ca26b26c480ac71eb5570f5eecb1f
Partial-Bug: #1800894

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/50753
Committed: http://github.com/Juniper/contrail-common/commit/e817052afaa728a02d4e8726a8a8c62a57312cc0
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit e817052afaa728a02d4e8726a8a8c62a57312cc0
Author: Mateusz Jablonski <email address hidden>
Date: Thu Apr 11 14:54:47 2019 +0200

Fix warning C4065 in t_cpp_generator for Windows

Fix `Switch statement contains 'default' but
no 'case' labels` by generating just the contents
of 'default' case when there is no other 'case' labels
instead of 'switch' with just 'default' label.

Change-Id: Ief8f75b144b8f6659f3031dc45f21a5d55645951
Partial-Bug: #1800894

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/51041
Submitter: Mateusz Jablonski (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/50998
Submitter: Mateusz Jablonski (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/50997
Submitter: Mateusz Jablonski (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/50996
Submitter: Mateusz Jablonski (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/50813
Submitter: Mateusz Jablonski (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/51000
Submitter: Mateusz Jablonski (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/50854
Submitter: Mateusz Jablonski (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/50849
Committed: http://github.com/Juniper/contrail-controller/commit/85826146e9a964a2dc5a775e52b9f0339bc99ace
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 85826146e9a964a2dc5a775e52b9f0339bc99ace
Author: Mateusz Jablonski <email address hidden>
Date: Tue Apr 16 16:19:19 2019 +0200

Fix warnings C4311 and C4312 on Windows

Fix warnings about pointer <-> type conversions
which may cause truncation. Use boost::any instead.

Change-Id: I056fc9c9d74784a6643489ffee5812ce5decb779
Partial-Bug: #1800894

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/50756
Submitter: Mateusz Jablonski (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/50997
Committed: http://github.com/Juniper/contrail-common/commit/b108a458016fb1d4ab01fd827b3f1dccf30f0127
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit b108a458016fb1d4ab01fd827b3f1dccf30f0127
Author: Mateusz Jablonski <email address hidden>
Date: Tue Apr 23 16:27:05 2019 +0200

Fix 'struct' <-> 'class' mismatch

Declare ConfigClientOptions as a struct because it
is defined as a struct in other part of the code.

Change-Id: I9f8ffba7331faacff901f8734dc49fe98f5121cd
Partial-Bug: #1800894

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/50813
Committed: http://github.com/Juniper/contrail-common/commit/f6d48acaec30823073e48bc0ef301c7446be6a8d
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit f6d48acaec30823073e48bc0ef301c7446be6a8d
Author: Mateusz Jablonski <email address hidden>
Date: Mon Apr 15 11:31:56 2019 +0200

Disable incorrectly generated warning C4724: Potential mod by 0

Change-Id: Iff8940e3c8093267384275102ae98ddb865ad309
Partial-Bug: #1800894

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/50854
Committed: http://github.com/Juniper/contrail-controller/commit/348303c74d9956c42c5806da163d0ef193d702d4
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 348303c74d9956c42c5806da163d0ef193d702d4
Author: Mateusz Jablonski <email address hidden>
Date: Wed Apr 17 16:51:05 2019 +0200

Fix warning C4099 in contrail-controller

Fix 'An object declared as a structure is defined as a class,
or an object declared as a class is defined as a structure'.

Change-Id: I1bbbf041f6530675db8c1d2a631fd06482bbd9a0
Partial-Bug: #1800894

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/50775
Submitter: Mateusz Jablonski (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/51000
Committed: http://github.com/Juniper/contrail-controller/commit/4ece1c4d9ddbf3d7d7abf04b50673740f31338dc
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 4ece1c4d9ddbf3d7d7abf04b50673740f31338dc
Author: Mateusz Jablonski <email address hidden>
Date: Tue Apr 23 16:41:11 2019 +0200

Fix formatting in all '.sandesh' files in contrail-controller

Change-Id: Id294563e83b044182a384829559d19a1d86269c1
Partial-Bug: #1800894

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/50996
Committed: http://github.com/Juniper/contrail-common/commit/de1940505d030a5a1b2f67bb334a518966b490cb
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit de1940505d030a5a1b2f67bb334a518966b490cb
Author: Mateusz Jablonski <email address hidden>
Date: Tue Apr 23 16:25:07 2019 +0200

Fix formatting in all '.sandesh' files in contrail-common

Change-Id: Ic3658cca85cb78f330d4bc294ac588e0d5df3da7
Partial-Bug: #1800894

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/50756
Committed: http://github.com/Juniper/contrail-common/commit/f9f45667d75051fb29b3e14d4a7fa9d5e9f1133f
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit f9f45667d75051fb29b3e14d4a7fa9d5e9f1133f
Author: Mateusz Jablonski <email address hidden>
Date: Thu Apr 11 16:16:51 2019 +0200

Fix warning C4065 in process_signal for Windows

1. Fix `Switch statement contains 'default' but no 'case' labels`.
2. Move all OS-specific code to platform-specific files.

Change-Id: I653dffc1fd01ce5caecc1048da429ecaa9cb2ee1
Partial-Bug: #1800894

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/50775
Committed: http://github.com/Juniper/contrail-common/commit/ae99fe09db37028ddc8f31cd21fb56481bc8e331
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit ae99fe09db37028ddc8f31cd21fb56481bc8e331
Author: Mateusz Jablonski <email address hidden>
Date: Fri Apr 12 15:28:19 2019 +0200

Fix formatting in sandesh/library/cpp

Change-Id: I7188a787db5593c5ac7022bfbcd1a9f84396f920
Partial-Bug: #1800894

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/50998
Submitter: Mateusz Jablonski (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/50850
Submitter: Mateusz Jablonski (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/50850
Committed: http://github.com/Juniper/contrail-controller/commit/0f3307f595ff1e02c6a22474456b0369af680f9b
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 0f3307f595ff1e02c6a22474456b0369af680f9b
Author: Mateusz Jablonski <email address hidden>
Date: Wed Apr 17 11:08:37 2019 +0200

Fix warning about returning no value from function that should return

Change-Id: Icf1912b61d3b95c933c9b32ef86ed2cd89c85a37
Partial-Bug: #1800894

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/50851
Submitter: Mateusz Jablonski (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/51397
Submitter: Mateusz Jablonski (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/51397
Submitter: Przemys?aw Marcinkiewicz (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/50851
Submitter: Mateusz Jablonski (<email address hidden>)