Coverity issue in contrail-controller/ovsdb_client_connection_state.cc

Bug #1777411 reported by Anda Nicolae on 2018-06-18
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Juniper Openstack
Status tracked in Trunk
R5.0
Fix Committed
Medium
Anda Nicolae
Trunk
Fix Committed
Medium
Anda Nicolae
OpenContrail
New
Undecided
Unassigned

Bug Description

Hi all,

I have run Coverity on branch R5.0 and it reported the following issue in contrail-controller/ovsdb_client_connection_state.cc:PhysicalDeviceNotify()

deref_after_free: Dereferencing freed pointer state

Solution is to check if state!= NULL in "if (state->ha_stale_dev_vn_table_ != NULL) {".

Thanks,
Anda

Review in progress for https://review.opencontrail.org/43913
Submitter: Anda Nicolae (<email address hidden>)

Jeba Paulaiyan (jebap) on 2018-06-19
tags: added: contrail-control

Review in progress for https://review.opencontrail.org/44090
Submitter: Anda Nicolae (<email address hidden>)

Reviewed: https://review.opencontrail.org/43913
Committed: http://github.com/Juniper/contrail-controller/commit/820b40a672cddd9fbdd8a562e14ba4b115617b3e
Submitter: Zuul v3 CI (<email address hidden>)
Branch: R5.0

commit 820b40a672cddd9fbdd8a562e14ba4b115617b3e
Author: Anda Nicolae <email address hidden>
Date: Mon Jun 18 14:42:31 2018 +0300

Coverity issue in contrail-controller/ovsdb_client_connection_state.cc

I have run Coverity on branch R5.0 and it reported the
following issue in
contrail-controller/ovsdb_client_connection_state.cc:PhysicalDeviceNotify()

deref_after_free: Dereferencing freed pointer state

Solution is to check if state!= NULL in:
"if (state->ha_stale_dev_vn_table_ != NULL) {".

Change-Id: Iafcf498adde07483af059d2302b9101d4fe860e4
Closes-Bug: #1777411
Signed-off-by: Anda Nicolae <email address hidden>

OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/44090
Committed: http://github.com/Juniper/contrail-controller/commit/4853ef07f9b4899dd08c8234e853985749858eda
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 4853ef07f9b4899dd08c8234e853985749858eda
Author: Anda Nicolae <email address hidden>
Date: Mon Jun 18 14:42:31 2018 +0300

Coverity issue in contrail-controller/ovsdb_client_connection_state.cc

I have run Coverity on branch R5.0 and it reported the
following issue in
contrail-controller/ovsdb_client_connection_state.cc:PhysicalDeviceNotify()

deref_after_free: Dereferencing freed pointer state

Solution is to check if state!= NULL in:
"if (state->ha_stale_dev_vn_table_ != NULL) {".

Change-Id: Iafcf498adde07483af059d2302b9101d4fe860e4
Closes-Bug: #1777411
Signed-off-by: Anda Nicolae <email address hidden>

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers