Coverity issue in contrail-controller/physical_port_ovsdb.cc

Bug #1777400 reported by Anda Nicolae on 2018-06-18
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Juniper Openstack
Status tracked in Trunk
R5.0
Fix Committed
Medium
Anda Nicolae
Trunk
Fix Committed
Medium
Anda Nicolae
OpenContrail
New
Undecided
Unassigned

Bug Description

Hi all,

I have run Coverity on branch R5.0 and it reported the following issue in contrail-controller/physical_port_ovsdb.cc:EntryOvsdbUpdate()

uninit_use_in_call: Using uninitialized value key->table_ when calling VlanPortBindingEntry.

Solution is to modify in the first 2 constructors for VlanPortBindingEntry() to call OvsdbDBEntry(table) instead of OvsdbDBEntry(table_).

Thanks,
Anda

Review in progress for https://review.opencontrail.org/43910
Submitter: Anda Nicolae (<email address hidden>)

Jeba Paulaiyan (jebap) on 2018-06-19
tags: added: contrail-control

Review in progress for https://review.opencontrail.org/44091
Submitter: Anda Nicolae (<email address hidden>)

Reviewed: https://review.opencontrail.org/44091
Committed: http://github.com/Juniper/contrail-controller/commit/d1d7b263920f0da468501faf0c6680b65200bd36
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit d1d7b263920f0da468501faf0c6680b65200bd36
Author: Anda Nicolae <email address hidden>
Date: Mon Jun 18 12:15:59 2018 +0300

Coverity issue in contrail-controller/physical_port_ovsdb.cc

I have run Coverity on branch R5.0 and it reported
the following issue in
contrail-controller/physical_port_ovsdb.cc:EntryOvsdbUpdate()

uninit_use_in_call: Using uninitialized value
key->table_ when calling VlanPortBindingEntry.

Solution is to modify in the first 2 constructors for
VlanPortBindingEntry() to call OvsdbDBEntry(table)
instead of OvsdbDBEntry(table_).

Change-Id: Ic82b315e9f880cb5129e67f3a74e4004b9474bfd
Closes-Bug: #1777400
Signed-off-by: Anda Nicolae <email address hidden>

OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/43910
Committed: http://github.com/Juniper/contrail-controller/commit/c2f0bfa58a3e8823b8d2e6da4bbcd0165db7b21e
Submitter: Zuul v3 CI (<email address hidden>)
Branch: R5.0

commit c2f0bfa58a3e8823b8d2e6da4bbcd0165db7b21e
Author: Anda Nicolae <email address hidden>
Date: Mon Jun 18 12:15:59 2018 +0300

Coverity issue in contrail-controller/physical_port_ovsdb.cc

I have run Coverity on branch R5.0 and it reported
the following issue in
contrail-controller/physical_port_ovsdb.cc:EntryOvsdbUpdate()

uninit_use_in_call: Using uninitialized value
key->table_ when calling VlanPortBindingEntry.

Solution is to modify in the first 2 constructors for
VlanPortBindingEntry() to call OvsdbDBEntry(table)
instead of OvsdbDBEntry(table_).

Change-Id: Ic82b315e9f880cb5129e67f3a74e4004b9474bfd
Closes-Bug: #1777400
Signed-off-by: Anda Nicolae <email address hidden>

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers