contrail vcenter manager removes all virtual machines on startup

Bug #1776850 reported by Adrian Szczepański on 2018-06-14
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Juniper Openstack
Status tracked in Trunk
R5.0
Fix Committed
High
Adrian Szczepański
Trunk
Fix Committed
High
Adrian Szczepański
OpenContrail
Fix Committed
Undecided
Adrian Szczepański

Bug Description

While checking whether unused VM can be removed, we check for the vRouter uuid. Due to this bug the vRouter uuid is always allowing to delete the VM. We need to store vRouter uuid elsewhere, so it's compared to a proper value, not to itself as it is now.

summary: - contrail vcenter removes all virtual machines on startup
+ contrail vcenter manager removes all virtual machines on startup

Review in progress for https://review.opencontrail.org/43834
Submitter: Adrian Szczepanski (<email address hidden>)

Review in progress for https://review.opencontrail.org/43835
Submitter: Adrian Szczepanski (<email address hidden>)

Changed in opencontrail:
assignee: nobody → Adrian Szczepański (adrian.szczepanski)

Reviewed: https://review.opencontrail.org/43834
Committed: http://github.com/Juniper/contrail-vcenter-manager/commit/d403c7df96d1ee18976cdc8e8dc61440f2c07aec
Submitter: Zuul v3 CI (<email address hidden>)
Branch: R5.0

commit d403c7df96d1ee18976cdc8e8dc61440f2c07aec
Author: Adrian Szczepański <email address hidden>
Date: Thu Jun 14 11:05:50 2018 +0200

Prevent CVM from deleting all VMs on startup

Use vrouter_uuid variable in VM and VMI services
Move _can_delete_from_vnc up to parent Service class
Split sync_vms into two methods and change the order of execution

Change-Id: Iff4bba6f821f45e0b0a595e931926215d0346cc2
Depends-On: Ib4b8106828f4e254bf64129a2a7346c38a1d57ad
Closes-Bug: #1776850

OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/43835
Committed: http://github.com/Juniper/contrail-vcenter-manager/commit/1c02c21cab1068827eb5d83380d016f6f9b131b6
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 1c02c21cab1068827eb5d83380d016f6f9b131b6
Author: Adrian Szczepański <email address hidden>
Date: Thu Jun 14 11:05:50 2018 +0200

Prevent CVM from deleting all VMs on startup

Use vrouter_uuid variable in VM and VMI services
Move _can_delete_from_vnc up to parent Service class
Split sync_vms into two methods and change the order of execution

Change-Id: Iff4bba6f821f45e0b0a595e931926215d0346cc2
Depends-On: Ib4b8106828f4e254bf64129a2a7346c38a1d57ad
Closes-Bug: #1776850

Jeba Paulaiyan (jebap) on 2018-06-21
tags: added: vmware
Changed in opencontrail:
status: New → Fix Committed
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers