Contrail vCenter Manager needs unit tests

Bug #1776434 reported by Adrian Szczepański on 2018-06-12
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Juniper Openstack
Status tracked in Trunk
R5.0
Fix Committed
Undecided
Adrian Szczepański
Trunk
Fix Committed
Undecided
Adrian Szczepański
OpenContrail
New
Undecided
Unassigned

Bug Description

CVM needs more working unit tests.
Please, submit all changes which exclusively involve testing with Partial-Bug tag in the commit message.

description: updated
description: updated
description: updated
summary: - Contrail vCenter Manager needs unittests
+ Contrail vCenter Manager needs unit tests

Review in progress for https://review.opencontrail.org/43722
Submitter: Adrian Szczepanski (<email address hidden>)

Reviewed: https://review.opencontrail.org/43722
Committed: http://github.com/Juniper/contrail-vcenter-manager/commit/ba99839c79f1d7b5310594a0c117c88c3c203369
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit ba99839c79f1d7b5310594a0c117c88c3c203369
Author: Adrian Szczepański <email address hidden>
Date: Tue Jun 12 10:34:02 2018 +0200

Fix irrelevant unit tests after vMotion

Some unit tests became irrelevant or wrong and needed to be fixed
after vMotion handling implementation

Change-Id: Ib2d60b0cc1a5c658b3ad87ae29f1e3d1a603dcdc
Partial-Bug: #1776434

Review in progress for https://review.opencontrail.org/43744
Submitter: Adrian Szczepanski (<email address hidden>)

Review in progress for https://review.opencontrail.org/43773
Submitter: Adrian Szczepanski (<email address hidden>)

Reviewed: https://review.opencontrail.org/43744
Committed: http://github.com/Juniper/contrail-vcenter-manager/commit/af5d0a43938ee4f3bc40bfeb15af6e80e47c0120
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit af5d0a43938ee4f3bc40bfeb15af6e80e47c0120
Author: Adrian Szczepański <email address hidden>
Date: Tue Jun 12 15:52:32 2018 +0200

Add tests for _can_delete_from_vnc

Remove some code duplication for checking if VM can be deleted from VNC

Change-Id: I8a86a3d19269bb5d3962811f6e8282902b6aed8a
Partial-Bug: #1776434

OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/43773
Committed: http://github.com/Juniper/contrail-vcenter-manager/commit/22abcaf9ca2d58271659c56432e27247525ef94f
Submitter: Zuul v3 CI (<email address hidden>)
Branch: R5.0

commit 22abcaf9ca2d58271659c56432e27247525ef94f
Author: Adrian Szczepański <email address hidden>
Date: Tue Jun 12 15:52:32 2018 +0200

Add tests for _can_delete_from_vnc

Remove some code duplication for checking if VM can be deleted from VNC

Change-Id: I8a86a3d19269bb5d3962811f6e8282902b6aed8a
Partial-Bug: #1776434

Jeba Paulaiyan (jebap) on 2018-06-21
tags: added: vmware

Review in progress for https://review.opencontrail.org/44601
Submitter: Krzysztof Gromadzki (<email address hidden>)

Review in progress for https://review.opencontrail.org/44602
Submitter: Krzysztof Gromadzki (<email address hidden>)

Review in progress for https://review.opencontrail.org/44601
Submitter: Krzysztof Gromadzki (<email address hidden>)

Review in progress for https://review.opencontrail.org/44602
Submitter: Krzysztof Gromadzki (<email address hidden>)

Review in progress for https://review.opencontrail.org/44610
Submitter: Adrian Szczepanski (<email address hidden>)

Review in progress for https://review.opencontrail.org/44611
Submitter: Adrian Szczepanski (<email address hidden>)

Review in progress for https://review.opencontrail.org/44610
Submitter: Adrian Szczepanski (<email address hidden>)

Review in progress for https://review.opencontrail.org/44611
Submitter: Krzysztof Gromadzki (<email address hidden>)

Reviewed: https://review.opencontrail.org/44610
Committed: http://github.com/Juniper/contrail-vcenter-manager/commit/f861cb86b37c554356cf4197e9a2724b956f1491
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit f861cb86b37c554356cf4197e9a2724b956f1491
Author: Krzysztof Gromadzki <email address hidden>
Date: Fri Jul 13 15:54:35 2018 +0200

Add functional test for VM power state change

Add functional test for VM vmware tools running change
Move fixtures and util functions to separate files
Add controller fixture for functional tests
Split functional tests to separate files

Change-Id: I87cf8f4ab6d6b584b406f6240e51896324f18174
Partial-Bug: #1776434

Review in progress for https://review.opencontrail.org/44694
Submitter: Adrian Szczepanski (<email address hidden>)

Review in progress for https://review.opencontrail.org/44704
Submitter: Krzysztof Gromadzki (<email address hidden>)

Reviewed: https://review.opencontrail.org/44704
Committed: http://github.com/Juniper/contrail-vcenter-manager/commit/9c21dea87d8b4cb76638a092deefd67d742f1cd0
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 9c21dea87d8b4cb76638a092deefd67d742f1cd0
Author: Krzysztof Gromadzki <email address hidden>
Date: Tue Jul 17 13:30:23 2018 +0200

Functional test from VM remove event

Change-Id: Ie08a50b91b7d2f9ccc5d1b8e885bfbd33bff3289
Partial-Bug: #1776434

Review in progress for https://review.opencontrail.org/44694
Submitter: Adrian Szczepanski (<email address hidden>)

Review in progress for https://review.opencontrail.org/44772
Submitter: Adrian Szczepanski (<email address hidden>)

Review in progress for https://review.opencontrail.org/44772
Submitter: Krzysztof Gromadzki (<email address hidden>)

Review in progress for https://review.opencontrail.org/44694
Submitter: Adrian Szczepanski (<email address hidden>)

Review in progress for https://review.opencontrail.org/44611
Submitter: Adrian Szczepanski (<email address hidden>)

Review in progress for https://review.opencontrail.org/44856
Submitter: Adrian Szczepanski (<email address hidden>)

Review in progress for https://review.opencontrail.org/44857
Submitter: Adrian Szczepanski (<email address hidden>)

Review in progress for https://review.opencontrail.org/44772
Submitter: Adrian Szczepanski (<email address hidden>)

Reviewed: https://review.opencontrail.org/44694
Committed: http://github.com/Juniper/contrail-vcenter-manager/commit/02df1ca2c7ae8cebbae98910912e85517d943097
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 02df1ca2c7ae8cebbae98910912e85517d943097
Author: Adrian Szczepański <email address hidden>
Date: Mon Jul 16 11:12:54 2018 +0200

Unit tests in pytest

Refactor handler tests to use pytest and fixtures
Refactor database tests to use pytest and fixtures
Refactor models tests to use pytest and fixtures
Refactor monitor tests to use pytest and fixtures
Refactor clients tests to use pytest and fixtures
Refactor services tests to use pytest and fixtures
Remove unused functions and imports

Partial-Bug: #1776434
Change-Id: Ia84e0a072718d0b3c8b4be75810866e9adc52fe9

Review in progress for https://review.opencontrail.org/44961
Submitter: Adrian Szczepanski (<email address hidden>)

Reviewed: https://review.opencontrail.org/44611
Committed: http://github.com/Juniper/contrail-vcenter-manager/commit/dd1cc56ef98a1aee294d4ba1282957baba89ac11
Submitter: Zuul v3 CI (<email address hidden>)
Branch: R5.0

commit dd1cc56ef98a1aee294d4ba1282957baba89ac11
Author: Krzysztof Gromadzki <email address hidden>
Date: Fri Jul 13 15:54:35 2018 +0200

Add functional test for VM power state change

Add functional test for VM vmware tools running change
Move fixtures and util functions to separate files
Add controller fixture for functional tests
Split functional tests to separate files

Change-Id: I87cf8f4ab6d6b584b406f6240e51896324f18174
Partial-Bug: #1776434

Reviewed: https://review.opencontrail.org/44856
Committed: http://github.com/Juniper/contrail-vcenter-manager/commit/882ef9d2934bc4f05d6ce0d27e0d8b0e251983e2
Submitter: Zuul v3 CI (<email address hidden>)
Branch: R5.0

commit 882ef9d2934bc4f05d6ce0d27e0d8b0e251983e2
Author: Krzysztof Gromadzki <email address hidden>
Date: Tue Jul 17 13:30:23 2018 +0200

Functional test from VM remove event

Depends-On: I87cf8f4ab6d6b584b406f6240e51896324f18174
Change-Id: Ie08a50b91b7d2f9ccc5d1b8e885bfbd33bff3289
Partial-Bug: #1776434

Reviewed: https://review.opencontrail.org/44961
Committed: http://github.com/Juniper/contrail-vcenter-manager/commit/02e6e38568bc6a595425deb618730a6184ad7d7f
Submitter: Zuul v3 CI (<email address hidden>)
Branch: R5.0

commit 02e6e38568bc6a595425deb618730a6184ad7d7f
Author: Adrian Szczepański <email address hidden>
Date: Mon Jul 16 11:12:54 2018 +0200

Unit tests in pytest

Refactor handler tests to use pytest and fixtures
Refactor database tests to use pytest and fixtures
Refactor models tests to use pytest and fixtures
Refactor monitor tests to use pytest and fixtures
Refactor clients tests to use pytest and fixtures
Refactor services tests to use pytest and fixtures
Remove unused functions and imports

Change-Id: Ic16990d7a9c73ea338a70c068130839bf3855e61
Depends-On: Ie08a50b91b7d2f9ccc5d1b8e885bfbd33bff3289
Partial-Bug: #1776434

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers