Coverity reports memory leak in contrail-common/http_curl.cc

Bug #1770601 reported by Anda Nicolae on 2018-05-11
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Juniper Openstack
Status tracked in Trunk
R5.0
Fix Committed
High
Anda Nicolae
Trunk
Fix Committed
Undecided
Anda Nicolae
OpenContrail
New
Undecided
Unassigned

Bug Description

Hi all,

I have run Coverity on branch R5.0 and it reported the following memory leak in contrail-common/http_curl.cc:

- leaked_storage: Variable conn going out of scope leaks the storage it points to in http_curl.cc:new_conn()
Indeed, conn should be freed if the following condition is matched:
if ( !conn->easy ) {

Review in progress for https://review.opencontrail.org/42976
Submitter: Anda Nicolae (<email address hidden>)

Jeba Paulaiyan (jebap) on 2018-05-13
tags: added: config

Review in progress for https://review.opencontrail.org/43024
Submitter: Anda Nicolae (<email address hidden>)

Reviewed: https://review.opencontrail.org/43024
Committed: http://github.com/Juniper/contrail-common/commit/09f32f489babad3e90742d632f02b4ff9e46b22b
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 09f32f489babad3e90742d632f02b4ff9e46b22b
Author: Anda Nicolae <email address hidden>
Date: Fri May 11 12:32:21 2018 +0300

Coverity reports memory leak in contrail-common/http_curl.cc

I have run Coverity on branch R5.0 and it reported the following
memory leak in contrail-common/http_curl.cc:

- leaked_storage: Variable conn going out of scope leaks the storage
it points to in http_curl.cc:new_conn()
Indeed, conn should be freed if the following condition is matched:
if ( !conn->easy ) {

Change-Id: Idf4985d7806897c0f8eb7e725e19259a4adfa809
Closes-Bug: #1770601
Signed-off-by: Anda Nicolae <email address hidden>

OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/42976
Committed: http://github.com/Juniper/contrail-common/commit/aa665df4199e4f3486357d3a5db5b6eefd375098
Submitter: Zuul v3 CI (<email address hidden>)
Branch: R5.0

commit aa665df4199e4f3486357d3a5db5b6eefd375098
Author: Anda Nicolae <email address hidden>
Date: Fri May 11 12:32:21 2018 +0300

Coverity reports memory leak in contrail-common/http_curl.cc

I have run Coverity on branch R5.0 and it reported the following
memory leak in contrail-common/http_curl.cc:

- leaked_storage: Variable conn going out of scope leaks the storage
it points to in http_curl.cc:new_conn()
Indeed, conn should be freed if the following condition is matched:
if ( !conn->easy ) {

Change-Id: Idf4985d7806897c0f8eb7e725e19259a4adfa809
Closes-Bug: #1770601
Signed-off-by: Anda Nicolae <email address hidden>

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers