OpenContrail

Coverity issues in contrail-common repo

Bug #1770142 reported by Anda-Maria Nicolae
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Juniper Openstack
Status tracked in Trunk
R5.0
Fix Committed
Undecided
Anda-Maria Nicolae
Juniper Openstack r5.0.1
Trunk
Fix Committed
Undecided
Anda-Maria Nicolae
Juniper Openstack r5.1.0
OpenContrail
New
Undecided
Unassigned

Bug Description

Hi all,

I have run Coverity on branch R5.0 and it reported the following issues in contrail-common repo:

- Missing return statement in sandesh_server.cc:SandeshServer::Initialize
- Missing return statement in sandesh_message_builder.cc:SandeshSyslogMessage::Parse
- Missing return statement in t_cpp_generator.cc:generate_sandesh_base_name
- Variable fp going out of scope leaks the storage it points to in misc_utils.cc:MiscUtils::GetPlatformInfo

Tags: config
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R5.0

Review in progress for https://review.opencontrail.org/42890
Submitter: Anda Nicolae (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/42891
Submitter: Anda Nicolae (<email address hidden>)

Jeba Paulaiyan (jebap)
tags: added: config
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R5.0

Review in progress for https://review.opencontrail.org/42890
Submitter: Anda Nicolae (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/42891
Submitter: Anda Nicolae (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/42891
Committed: http://github.com/Juniper/contrail-common/commit/351374b697030ff9c03b1f6d6f9b25e9d86be8d2
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 351374b697030ff9c03b1f6d6f9b25e9d86be8d2
Author: Anda Nicolae <email address hidden>
Date: Wed May 9 14:06:20 2018 +0300

Coverity issues in contrail-common repo

- Variable fp going out of scope leaks the storage it points to in misc_utils.cc:MiscUtils::GetPlatformInfo
- Missing return statement in t_cpp_generator.cc:generate_sandesh_base_name
- Missing return statement in sandesh_message_builder.cc:SandeshSyslogMessage::Parse
- Missing return statement in sandesh_server.cc:SandeshServer::Initialize

Change-Id: I02c25ec037c73a1d4e3024e257558a4f81310a49
Closes-Bug: #1770142
Signed-off-by: Anda Nicolae <email address hidden>

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/42890
Committed: http://github.com/Juniper/contrail-common/commit/dc6fb81f4ed866cec02e592df3444052c440e24d
Submitter: Zuul v3 CI (<email address hidden>)
Branch: R5.0

commit dc6fb81f4ed866cec02e592df3444052c440e24d
Author: Anda Nicolae <email address hidden>
Date: Wed May 9 14:06:20 2018 +0300

Coverity issues in contrail-common repo

- Variable fp going out of scope leaks the storage it points to in misc_utils.cc:MiscUtils::GetPlatformInfo
- Missing return statement in t_cpp_generator.cc:generate_sandesh_base_name
- Missing return statement in sandesh_message_builder.cc:SandeshSyslogMessage::Parse
- Missing return statement in sandesh_server.cc:SandeshServer::Initialize

Change-Id: I02c25ec037c73a1d4e3024e257558a4f81310a49
Closes-Bug: #1770142
Signed-off-by: Anda Nicolae <email address hidden>

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.