contrail-controller changes for Windows

Bug #1737177 reported by Pawel Marchewka on 2017-12-08
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Juniper Openstack
Status tracked in Trunk
R5.0
High
Pawel Marchewka
Trunk
Undecided
Pawel Marchewka
OpenContrail
Undecided
Pawel Marchewka

Bug Description

Merge contrail-contrail changes for Windows from github.com/codilime/contrail-controller to Juniper/contrail-controller project on review.opencontrail.org

Initial changes:
  https://github.com/sagarkchitnis/windows/commits/master/controller/src
Further work and cleanup:
  https://github.com/codilime/contrail-controller/commits/windows3.1/src

Changed in opencontrail:
assignee: nobody → Pawel Marchewka (pawelmarchewka)

Review in progress for https://review.opencontrail.org/38302
Submitter: Michal Clapinski (<email address hidden>)

1 comments hidden view all 437 comments
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/38333
Submitter: Pawel Marchewka (<email address hidden>)

OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/38342
Submitter: Mateusz Jablonski (<email address hidden>)

OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/38333
Submitter: Pawel Marchewka (<email address hidden>)

OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/38382
Submitter: Pawel Marchewka (<email address hidden>)

2 comments hidden view all 437 comments
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/38342
Submitter: Mateusz Jablonski (<email address hidden>)

1 comments hidden view all 437 comments

Review in progress for https://review.opencontrail.org/38384
Submitter: Pawel Marchewka (<email address hidden>)

1 comments hidden view all 437 comments

Reviewed: https://review.opencontrail.org/38302
Committed: http://github.com/Juniper/contrail-controller/commit/382cccd87dd1565ec09b889cb8934592a3d60f9e
Submitter: Zuul (<email address hidden>)
Branch: master

commit 382cccd87dd1565ec09b889cb8934592a3d60f9e
Author: Michał Cłapiński <email address hidden>
Date: Wed Dec 13 17:58:20 2017 +0100

General changes for Windows

Mixed changes related to net,vnsw/agent/{cfg,controller,diag,filter,pkt}:
1. boost::array<uint8_t, X> to IpYAddress::bytes_type where applicable.
IpYAddress::bytes_type is std::array if c++11 and boost::array otherwise
and on Windows we compile with c++11.
2. addr.to_bytes().c_array() to addr.to_bytes().data()
Difference between boost::array and std::array
3. variable length arrays to dynamic allocation with smart pointers
4. s_addr to s_address, DELETE to DEL, EVENT_MAX to EVENT_MAXIMUM
s_addr, DELETE, EVENT_MAX are reserved on Windows
5. bind to ::bind
To avoid confusion with std::bind
6. and more various bugs

Initial changes:
https://github.com/sagarkchitnis/windows/commits/master/controller/src
Further work and cleanup:
https://github.com/codilime/contrail-controller/commits/windows3.1/src

Change-Id: I7b963703d6d0aefb6591bc40ab6048351bb30593
Partial-Bug: #1737177

Reviewed: https://review.opencontrail.org/38382
Committed: http://github.com/Juniper/contrail-common/commit/442663f4e8d7c15a5f1c884f4332385d066f2c53
Submitter: Zuul (<email address hidden>)
Branch: master

commit 442663f4e8d7c15a5f1c884f4332385d066f2c53
Author: Pawel Marchewka <email address hidden>
Date: Fri Dec 15 12:36:45 2017 +0100

Changes for windows

Changes for windows:
1. Do not build usock_server on windows
2. Use uint8_t instead of u_int8_t
3. Added cast in setsocktopt
4. Changed size_t to std::size_t in some methods (to match to
declaration)

Change-Id: I1336413e541e25ee95c29074f29aa6952e0f5d97
Partial-Bug: #1737177

Review in progress for https://review.opencontrail.org/38461
Submitter: Pawel Marchewka (<email address hidden>)

Review in progress for https://review.opencontrail.org/38463
Submitter: Michal Clapinski (<email address hidden>)

1 comments hidden view all 437 comments

Review in progress for https://review.opencontrail.org/38464
Submitter: Katarzyna Rybacka (<email address hidden>)

Review in progress for https://review.opencontrail.org/38463
Submitter: Michal Clapinski (<email address hidden>)

1 comments hidden view all 437 comments

Review in progress for https://review.opencontrail.org/38465
Submitter: Mateusz Jablonski (<email address hidden>)

Review in progress for https://review.opencontrail.org/38466
Submitter: Michal Clapinski (<email address hidden>)

3 comments hidden view all 437 comments

Reviewed: https://review.opencontrail.org/38342
Committed: http://github.com/Juniper/contrail-controller/commit/05212ee13413504f0384c6d8169cff1749994079
Submitter: Zuul (<email address hidden>)
Branch: master

commit 05212ee13413504f0384c6d8169cff1749994079
Author: Mateusz Jablonski <email address hidden>
Date: Thu Dec 14 17:04:12 2017 +0100

General changes for Windows

Mixed changes related to schema, xmpp, vnsw/agent/{kstate, vgw, test-xml}:
1. boost::array<uint8_t, X> to IpYAddress::bytes_type where applicable.
IpYAddress::bytes_type is std::array if c++11 and boost::array
otherwise and on Windows we compile with c++11.
2. add linking with advapi32 and gdi32 on Windows
(needed by OpenSSL)
3. do not link with librt on Windows
4. use multiplatform boost::filesystem instead of open/stat/read
5. add missing 'return' to some functions
6. add missing include
7. and more various bugs

Initial changes:
https://github.com/sagarkchitnis/windows/commits/master/controller/src
Further work and cleanup:
https://github.com/codilime/contrail-controller/commits/windows3.1/src

Change-Id: Ifa9a6182300a16c4210d3dc866a333048317b944
Partial-Bug: #1737177

Review in progress for https://review.opencontrail.org/38464
Submitter: Katarzyna Rybacka (<email address hidden>)

Review in progress for https://review.opencontrail.org/38485
Submitter: Mateusz Jablonski (<email address hidden>)

Review in progress for https://review.opencontrail.org/38465
Submitter: Mateusz Jablonski (<email address hidden>)

Review in progress for https://review.opencontrail.org/38485
Submitter: Mateusz Jablonski (<email address hidden>)

Review in progress for https://review.opencontrail.org/38487
Submitter: Katarzyna Rybacka (<email address hidden>)

Review in progress for https://review.opencontrail.org/38384
Submitter: Pawel Marchewka (<email address hidden>)

Review in progress for https://review.opencontrail.org/38487
Submitter: Katarzyna Rybacka (<email address hidden>)

1 comments hidden view all 437 comments

Reviewed: https://review.opencontrail.org/38463
Committed: http://github.com/Juniper/contrail-controller/commit/e83c61b714058b476494dd91a67f2e6745ecc6e7
Submitter: Zuul (<email address hidden>)
Branch: master

commit e83c61b714058b476494dd91a67f2e6745ecc6e7
Author: Michał Cłapiński <email address hidden>
Date: Tue Dec 19 15:53:04 2017 +0100

src/vnsw/agent changes for Windows

1. Created empty class VnswInterfaceListenerWindows
2. Disabled some libs and flags in SConscript for Windows

Initial changes:
https://github.com/sagarkchitnis/windows/commits/master/controller/src/vnsw/agent
Further work and cleanup:
https://github.com/codilime/contrail-controller/commits/windows3.1/src/vnsw/agent

Change-Id: Ifa57e5a2b3f0e8129dbd647e7e6e378ca8996a86
Partial-Bug: #1737177

Reviewed: https://review.opencontrail.org/38461
Committed: http://github.com/Juniper/contrail-controller/commit/1a587b0ae3877175b30aa94d69b1d2f0dcb521b7
Submitter: Zuul (<email address hidden>)
Branch: master

commit 1a587b0ae3877175b30aa94d69b1d2f0dcb521b7
Author: Pawel Marchewka <email address hidden>
Date: Tue Dec 19 14:36:11 2017 +0100

Agent services changes for Windows

Agent services changes for Windows:
1. Variable length arrays is only supported in gcc and it is not a part
of C++ standard. We decided to use dynamic allocation and scoped_array.
2. Empty (zero element) array at the end of structure is not portable.
3. Use boost::asio::ip::address_v*::bytes_type, boost from C++0x
uses std::array instead of boost::array

Initial changes:
https://github.com/sagarkchitnis/windows/commits/master/controller/src/vnsw/agent/services
Further work and cleanup:
https://github.com/codilime/contrail-controller/commits/windows3.1/src/vnsw/agent/services

Change-Id: I938ae8b6b9e1744046c763ecdc40473cc3b56369
Partial-Bug: #1737177

Reviewed: https://review.opencontrail.org/38384
Committed: http://github.com/Juniper/contrail-controller/commit/50c2fdbe648edd244886e8cd88d057f3f82a08dc
Submitter: Zuul (<email address hidden>)
Branch: master

commit 50c2fdbe648edd244886e8cd88d057f3f82a08dc
Author: Pawel Marchewka <email address hidden>
Date: Fri Dec 15 14:48:33 2017 +0100

Don't build nexthop_client and nexthop_server on Windows.

NexthopDBServer uses UnixDomainSocketServer which is not supported on
Windows.

Change-Id: Ibf117424629b66c220c5513da440b73706a0b251
Partial-Bug: #1737177

Review in progress for https://review.opencontrail.org/38485
Submitter: Katarzyna Rybacka (<email address hidden>)

Review in progress for https://review.opencontrail.org/38516
Submitter: Pawel Marchewka (<email address hidden>)

Review in progress for https://review.opencontrail.org/38465
Submitter: Mateusz Jablonski (<email address hidden>)

tags: added: vrouter windows
357 comments hidden view all 437 comments

Review in progress for https://review.opencontrail.org/44164
Submitter: Arkadiusz Kudan (<email address hidden>)

Review in progress for https://review.opencontrail.org/44244
Submitter: Mateusz Jablonski (<email address hidden>)

Review in progress for https://review.opencontrail.org/44164
Submitter: Arkadiusz Kudan (<email address hidden>)

Review in progress for https://review.opencontrail.org/44164
Submitter: Dariusz Sosnowski (<email address hidden>)

Review in progress for https://review.opencontrail.org/44313
Submitter: Mateusz Jablonski (<email address hidden>)

Review in progress for https://review.opencontrail.org/44164
Submitter: Mateusz Jablonski (<email address hidden>)

Review in progress for https://review.opencontrail.org/44244
Submitter: Mateusz Jablonski (<email address hidden>)

Review in progress for https://review.opencontrail.org/44164
Submitter: Arkadiusz Kudan (<email address hidden>)

Review in progress for https://review.opencontrail.org/44313
Submitter: Mateusz Jablonski (<email address hidden>)

Review in progress for https://review.opencontrail.org/44164
Submitter: Arkadiusz Kudan (<email address hidden>)

Review in progress for https://review.opencontrail.org/44458
Submitter: Mateusz Jablonski (<email address hidden>)

Reviewed: https://review.opencontrail.org/44253
Committed: http://github.com/Juniper/contrail-controller/commit/390b9c39ea69e98eaaa933fa75ec13a1766828da
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 390b9c39ea69e98eaaa933fa75ec13a1766828da
Author: Michal Clapinski <email address hidden>
Date: Fri Jun 29 19:05:02 2018 +0200

Don't send ARP probes

When we leave the SPA (source IP) field empty in an ARP request, the
request begins to be an ARP probe. When container tries to assign
itself an IP address and receives an ARP probe, it thinks that somebody
else has that address already assigned and the address is marked as a
duplicate. To stop this behavior we should send ARP requests from normal
IP address. The idea to use service address was taken from
ArpEntry::SendArpRequest.

Change-Id: Iceec678ed125664711e1c13714514290b37e7c96
Partial-Bug: #1737177

Review in progress for https://review.opencontrail.org/44492
Submitter: Micha? C?api?ski (<email address hidden>)

Reviewed: https://review.opencontrail.org/44132
Committed: http://github.com/Juniper/contrail-vrouter/commit/0625ce33a43d6ad4e9034248a3aa2800917d76b2
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 0625ce33a43d6ad4e9034248a3aa2800917d76b2
Author: Dariusz Sosnowski <email address hidden>
Date: Tue Jun 26 14:08:40 2018 +0200

Introduce WinPacketClone with unit tests

- Divide win_packet.c into two files
- win_packet.c - for NDIS-independent logic
- win_packet_raw.c - only NDIS-dependent code
- Extend WIN_PACKET interface to allow cloning and establishing
parent/child relationships
- Implement WinPacketClone unit tests

Change-Id: I468772725236a1f7bc69f1a7cddaefe21b486790
Depends-On: I1ff3d749b6d94747c89e9a520e56a59daa4c7b6f
Partial-Bug: #1737177

Reviewed: https://review.opencontrail.org/44244
Committed: http://github.com/Juniper/contrail-vrouter/commit/2d527e5716e639d31eea88875a581055b1c3dfe5
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 2d527e5716e639d31eea88875a581055b1c3dfe5
Author: Dariusz Sosnowski <email address hidden>
Date: Fri Jun 29 12:37:12 2018 +0200

Introduce WinPacketFreeRecursive with unit tests

This change is a part of Windows NBLs refactoring.
- Implement WinPacketFreeRecursive with all required dependencies
- Implement WinPacketFreeRecursive unit tests

Change-Id: I349da7e9f002de1a2c47c1f1ff632239d80ffbfe
Partial-Bug: #1737177

Reviewed: https://review.opencontrail.org/44313
Committed: http://github.com/Juniper/contrail-vrouter/commit/cd6f3a2b0d3659c7b760bf3ba03912adf5ef7e7a
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit cd6f3a2b0d3659c7b760bf3ba03912adf5ef7e7a
Author: Mateusz Jablonski <email address hidden>
Date: Tue Jul 3 13:10:42 2018 +0200

Use WinPacketFreeRecursive

Change-Id: I0ac93523b1f829eb1a4738e8448979897e0b976a
Partial-Bug: #1737177

Reviewed: https://review.opencontrail.org/44164
Committed: http://github.com/Juniper/contrail-vrouter/commit/b3d243e3108bdb5ec5600211475395cd778dbd29
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit b3d243e3108bdb5ec5600211475395cd778dbd29
Author: Mateusz Jablonski <email address hidden>
Date: Wed Jun 27 15:31:53 2018 +0200

win_pclone/win_pfree refactor and unit tests

Change-Id: I120f06f4e030f33a1578edd41d5c414fe5c22b32
Partial-Bug: #1737177

Review in progress for https://review.opencontrail.org/44545
Submitter: Mateusz Jablonski (<email address hidden>)

3 comments hidden view all 437 comments

Review in progress for https://review.opencontrail.org/44604
Submitter: Mateusz Jablonski (<email address hidden>)

Review in progress for https://review.opencontrail.org/44605
Submitter: Mateusz Jablonski (<email address hidden>)

Review in progress for https://review.opencontrail.org/44653
Submitter: Dariusz Sosnowski (<email address hidden>)

Reviewed: https://review.opencontrail.org/44492
Committed: http://github.com/Juniper/contrail-controller/commit/02a40d9333f9d1cbc1388dbdb767a8ddf3aca01e
Submitter: Zuul v3 CI (<email address hidden>)
Branch: R5.0

commit 02a40d9333f9d1cbc1388dbdb767a8ddf3aca01e
Author: Michal Clapinski <email address hidden>
Date: Fri Jun 29 19:05:02 2018 +0200

Don't send ARP probes

When we leave the SPA (source IP) field empty in an ARP request, the
request begins to be an ARP probe. When container tries to assign
itself an IP address and receives an ARP probe, it thinks that somebody
else has that address already assigned and the address is marked as a
duplicate. To stop this behavior we should send ARP requests from normal
IP address. The idea to use service address was taken from
ArpEntry::SendArpRequest.

Change-Id: Iceec678ed125664711e1c13714514290b37e7c96
Partial-Bug: #1737177
(cherry picked from commit 390b9c39ea69e98eaaa933fa75ec13a1766828da)

Review in progress for https://review.opencontrail.org/44732
Submitter: Mateusz Jablonski (<email address hidden>)

Review in progress for https://review.opencontrail.org/44653
Submitter: Jarek Lukow (<email address hidden>)

Reviewed: https://review.opencontrail.org/44458
Committed: http://github.com/Juniper/contrail-vrouter/commit/50c8296222079ddb19129d2ff4374a1cf3bbefcd
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 50c8296222079ddb19129d2ff4374a1cf3bbefcd
Author: Mateusz Jablonski <email address hidden>
Date: Mon Jul 9 12:30:53 2018 +0200

Refactor SConscript for test/windows directory

Change-Id: I2d2c4d955abf40d7617006ce1e0b7a32ecad2222
Partial-Bug: #1737177

Reviewed: https://review.opencontrail.org/44604
Committed: http://github.com/Juniper/contrail-vrouter/commit/8582f487c67476776e3b396e2a51a54fd1c16667
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 8582f487c67476776e3b396e2a51a54fd1c16667
Author: Mateusz Jablonski <email address hidden>
Date: Fri Jul 13 16:23:02 2018 +0200

Refactor WinPacket

- Add WinPacketRaw for all OS-dependent operations
- Refactor WinPacket

Change-Id: I74d2b92e565f2e219eee0a583e8a021bdbcd333d
Partial-Bug: #1737177

Reviewed: https://review.opencontrail.org/44605
Committed: http://github.com/Juniper/contrail-vrouter/commit/b6e1aeca6b4b22be1b42a5400c5a46afc27b5bd5
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit b6e1aeca6b4b22be1b42a5400c5a46afc27b5bd5
Author: Mateusz Jablonski <email address hidden>
Date: Fri Jul 13 16:35:00 2018 +0200

Refactor NBL splitting

- Add WinMultiPacket
- Add WinSubPacket
- Add WinPacketList
- Add WinPacketSplitMultiPacket function

Change-Id: I011b572bfad03591d11a5d54f8e40727e3ea9f13
Partial-Bug: #1737177

Reviewed: https://review.opencontrail.org/44732
Committed: http://github.com/Juniper/contrail-vrouter/commit/32b751950ae56929040d590f533f7d66444276a9
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 32b751950ae56929040d590f533f7d66444276a9
Author: Mateusz Jablonski <email address hidden>
Date: Wed Jul 18 12:18:17 2018 +0200

Post-refactor changes

- Change Fake_WinPacketListRawFree implementation to use production function
- Remove dead code
- Add comment with logic explanation
- Remove unused packets definitions
- Update .gitignore

Change-Id: Ib4d4d3f063ca961a6e65a09a7a371264016b38b4
Partial-Bug: #1737177

Review in progress for https://review.opencontrail.org/45261
Submitter: Micha? C?api?ski (<email address hidden>)

Review in progress for https://review.opencontrail.org/45263
Submitter: Micha? C?api?ski (<email address hidden>)

Review in progress for https://review.opencontrail.org/45441
Submitter: Mateusz Jablonski (<email address hidden>)

1 comments hidden view all 437 comments

Review in progress for https://review.opencontrail.org/45522
Submitter: Dariusz Sosnowski (<email address hidden>)

3 comments hidden view all 437 comments

Review in progress for https://review.opencontrail.org/45558
Submitter: Micha? C?api?ski (<email address hidden>)

Displaying first 40 and last 40 comments. View all 437 comments or add a comment.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers