contrail-controller changes for Windows

Bug #1737177 reported by Pawel Marchewka on 2017-12-08
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Juniper Openstack
Status tracked in Trunk
R5.0
Undecided
Pawel Marchewka
Trunk
Undecided
Pawel Marchewka
OpenContrail
Undecided
Pawel Marchewka

Bug Description

Merge contrail-contrail changes for Windows from github.com/codilime/contrail-controller to Juniper/contrail-controller project on review.opencontrail.org

Initial changes:
  https://github.com/sagarkchitnis/windows/commits/master/controller/src
Further work and cleanup:
  https://github.com/codilime/contrail-controller/commits/windows3.1/src

Changed in opencontrail:
assignee: nobody → Pawel Marchewka (pawelmarchewka)

Review in progress for https://review.opencontrail.org/38302
Submitter: Michal Clapinski (<email address hidden>)

1 comments hidden view all 344 comments
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/38333
Submitter: Pawel Marchewka (<email address hidden>)

OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/38342
Submitter: Mateusz Jablonski (<email address hidden>)

OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/38333
Submitter: Pawel Marchewka (<email address hidden>)

OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/38382
Submitter: Pawel Marchewka (<email address hidden>)

2 comments hidden view all 344 comments
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/38342
Submitter: Mateusz Jablonski (<email address hidden>)

1 comments hidden view all 344 comments

Review in progress for https://review.opencontrail.org/38384
Submitter: Pawel Marchewka (<email address hidden>)

1 comments hidden view all 344 comments

Reviewed: https://review.opencontrail.org/38302
Committed: http://github.com/Juniper/contrail-controller/commit/382cccd87dd1565ec09b889cb8934592a3d60f9e
Submitter: Zuul (<email address hidden>)
Branch: master

commit 382cccd87dd1565ec09b889cb8934592a3d60f9e
Author: Michał Cłapiński <email address hidden>
Date: Wed Dec 13 17:58:20 2017 +0100

General changes for Windows

Mixed changes related to net,vnsw/agent/{cfg,controller,diag,filter,pkt}:
1. boost::array<uint8_t, X> to IpYAddress::bytes_type where applicable.
IpYAddress::bytes_type is std::array if c++11 and boost::array otherwise
and on Windows we compile with c++11.
2. addr.to_bytes().c_array() to addr.to_bytes().data()
Difference between boost::array and std::array
3. variable length arrays to dynamic allocation with smart pointers
4. s_addr to s_address, DELETE to DEL, EVENT_MAX to EVENT_MAXIMUM
s_addr, DELETE, EVENT_MAX are reserved on Windows
5. bind to ::bind
To avoid confusion with std::bind
6. and more various bugs

Initial changes:
https://github.com/sagarkchitnis/windows/commits/master/controller/src
Further work and cleanup:
https://github.com/codilime/contrail-controller/commits/windows3.1/src

Change-Id: I7b963703d6d0aefb6591bc40ab6048351bb30593
Partial-Bug: #1737177

Reviewed: https://review.opencontrail.org/38382
Committed: http://github.com/Juniper/contrail-common/commit/442663f4e8d7c15a5f1c884f4332385d066f2c53
Submitter: Zuul (<email address hidden>)
Branch: master

commit 442663f4e8d7c15a5f1c884f4332385d066f2c53
Author: Pawel Marchewka <email address hidden>
Date: Fri Dec 15 12:36:45 2017 +0100

Changes for windows

Changes for windows:
1. Do not build usock_server on windows
2. Use uint8_t instead of u_int8_t
3. Added cast in setsocktopt
4. Changed size_t to std::size_t in some methods (to match to
declaration)

Change-Id: I1336413e541e25ee95c29074f29aa6952e0f5d97
Partial-Bug: #1737177

Review in progress for https://review.opencontrail.org/38461
Submitter: Pawel Marchewka (<email address hidden>)

Review in progress for https://review.opencontrail.org/38463
Submitter: Michal Clapinski (<email address hidden>)

1 comments hidden view all 344 comments

Review in progress for https://review.opencontrail.org/38464
Submitter: Katarzyna Rybacka (<email address hidden>)

Review in progress for https://review.opencontrail.org/38463
Submitter: Michal Clapinski (<email address hidden>)

1 comments hidden view all 344 comments

Review in progress for https://review.opencontrail.org/38465
Submitter: Mateusz Jablonski (<email address hidden>)

Review in progress for https://review.opencontrail.org/38466
Submitter: Michal Clapinski (<email address hidden>)

3 comments hidden view all 344 comments

Reviewed: https://review.opencontrail.org/38342
Committed: http://github.com/Juniper/contrail-controller/commit/05212ee13413504f0384c6d8169cff1749994079
Submitter: Zuul (<email address hidden>)
Branch: master

commit 05212ee13413504f0384c6d8169cff1749994079
Author: Mateusz Jablonski <email address hidden>
Date: Thu Dec 14 17:04:12 2017 +0100

General changes for Windows

Mixed changes related to schema, xmpp, vnsw/agent/{kstate, vgw, test-xml}:
1. boost::array<uint8_t, X> to IpYAddress::bytes_type where applicable.
IpYAddress::bytes_type is std::array if c++11 and boost::array
otherwise and on Windows we compile with c++11.
2. add linking with advapi32 and gdi32 on Windows
(needed by OpenSSL)
3. do not link with librt on Windows
4. use multiplatform boost::filesystem instead of open/stat/read
5. add missing 'return' to some functions
6. add missing include
7. and more various bugs

Initial changes:
https://github.com/sagarkchitnis/windows/commits/master/controller/src
Further work and cleanup:
https://github.com/codilime/contrail-controller/commits/windows3.1/src

Change-Id: Ifa9a6182300a16c4210d3dc866a333048317b944
Partial-Bug: #1737177

Review in progress for https://review.opencontrail.org/38464
Submitter: Katarzyna Rybacka (<email address hidden>)

Review in progress for https://review.opencontrail.org/38485
Submitter: Mateusz Jablonski (<email address hidden>)

Review in progress for https://review.opencontrail.org/38465
Submitter: Mateusz Jablonski (<email address hidden>)

Review in progress for https://review.opencontrail.org/38485
Submitter: Mateusz Jablonski (<email address hidden>)

Review in progress for https://review.opencontrail.org/38487
Submitter: Katarzyna Rybacka (<email address hidden>)

Review in progress for https://review.opencontrail.org/38384
Submitter: Pawel Marchewka (<email address hidden>)

Review in progress for https://review.opencontrail.org/38487
Submitter: Katarzyna Rybacka (<email address hidden>)

1 comments hidden view all 344 comments

Reviewed: https://review.opencontrail.org/38463
Committed: http://github.com/Juniper/contrail-controller/commit/e83c61b714058b476494dd91a67f2e6745ecc6e7
Submitter: Zuul (<email address hidden>)
Branch: master

commit e83c61b714058b476494dd91a67f2e6745ecc6e7
Author: Michał Cłapiński <email address hidden>
Date: Tue Dec 19 15:53:04 2017 +0100

src/vnsw/agent changes for Windows

1. Created empty class VnswInterfaceListenerWindows
2. Disabled some libs and flags in SConscript for Windows

Initial changes:
https://github.com/sagarkchitnis/windows/commits/master/controller/src/vnsw/agent
Further work and cleanup:
https://github.com/codilime/contrail-controller/commits/windows3.1/src/vnsw/agent

Change-Id: Ifa57e5a2b3f0e8129dbd647e7e6e378ca8996a86
Partial-Bug: #1737177

Reviewed: https://review.opencontrail.org/38461
Committed: http://github.com/Juniper/contrail-controller/commit/1a587b0ae3877175b30aa94d69b1d2f0dcb521b7
Submitter: Zuul (<email address hidden>)
Branch: master

commit 1a587b0ae3877175b30aa94d69b1d2f0dcb521b7
Author: Pawel Marchewka <email address hidden>
Date: Tue Dec 19 14:36:11 2017 +0100

Agent services changes for Windows

Agent services changes for Windows:
1. Variable length arrays is only supported in gcc and it is not a part
of C++ standard. We decided to use dynamic allocation and scoped_array.
2. Empty (zero element) array at the end of structure is not portable.
3. Use boost::asio::ip::address_v*::bytes_type, boost from C++0x
uses std::array instead of boost::array

Initial changes:
https://github.com/sagarkchitnis/windows/commits/master/controller/src/vnsw/agent/services
Further work and cleanup:
https://github.com/codilime/contrail-controller/commits/windows3.1/src/vnsw/agent/services

Change-Id: I938ae8b6b9e1744046c763ecdc40473cc3b56369
Partial-Bug: #1737177

Reviewed: https://review.opencontrail.org/38384
Committed: http://github.com/Juniper/contrail-controller/commit/50c2fdbe648edd244886e8cd88d057f3f82a08dc
Submitter: Zuul (<email address hidden>)
Branch: master

commit 50c2fdbe648edd244886e8cd88d057f3f82a08dc
Author: Pawel Marchewka <email address hidden>
Date: Fri Dec 15 14:48:33 2017 +0100

Don't build nexthop_client and nexthop_server on Windows.

NexthopDBServer uses UnixDomainSocketServer which is not supported on
Windows.

Change-Id: Ibf117424629b66c220c5513da440b73706a0b251
Partial-Bug: #1737177

Review in progress for https://review.opencontrail.org/38485
Submitter: Katarzyna Rybacka (<email address hidden>)

Review in progress for https://review.opencontrail.org/38516
Submitter: Pawel Marchewka (<email address hidden>)

Review in progress for https://review.opencontrail.org/38465
Submitter: Mateusz Jablonski (<email address hidden>)

tags: added: vrouter windows
264 comments hidden view all 344 comments

Review in progress for https://review.opencontrail.org/41965
Submitter: Dariusz Sosnowski (<email address hidden>)

1 comments hidden view all 344 comments

Review in progress for https://review.opencontrail.org/41878
Submitter: Pawel Marchewka (<email address hidden>)

Review in progress for https://review.opencontrail.org/41878
Submitter: Mateusz Jablonski (<email address hidden>)

Review in progress for https://review.opencontrail.org/42014
Submitter: Michal Clapinski (<email address hidden>)

Review in progress for https://review.opencontrail.org/42017
Submitter: Michal Clapinski (<email address hidden>)

Review in progress for https://review.opencontrail.org/42019
Submitter: Michal Clapinski (<email address hidden>)

Review in progress for https://review.opencontrail.org/42021
Submitter: Michal Clapinski (<email address hidden>)

Review in progress for https://review.opencontrail.org/42022
Submitter: Michal Clapinski (<email address hidden>)

Review in progress for https://review.opencontrail.org/42023
Submitter: Michal Clapinski (<email address hidden>)

Review in progress for https://review.opencontrail.org/42024
Submitter: Michal Clapinski (<email address hidden>)

Review in progress for https://review.opencontrail.org/42025
Submitter: Michal Clapinski (<email address hidden>)

Review in progress for https://review.opencontrail.org/42026
Submitter: Michal Clapinski (<email address hidden>)

Review in progress for https://review.opencontrail.org/42027
Submitter: Michal Clapinski (<email address hidden>)

Reviewed: https://review.opencontrail.org/42022
Committed: http://github.com/Juniper/contrail-vrouter/commit/663137715e288e8d0a87332c810832f2dd3eb143
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 663137715e288e8d0a87332c810832f2dd3eb143
Author: Michal Clapinski <email address hidden>
Date: Tue Apr 17 16:24:35 2018 +0200

Add python3 support

Since cpython 2 has bugs that won't be fixed on Windows, we have to move
to python 3

Change-Id: I4042246eabd9f81accf973c6624f10f3f4a31a81
Partial-Bug: #1737177

Reviewed: https://review.opencontrail.org/42026
Committed: http://github.com/Juniper/contrail-build/commit/0460741b8eacbd319fa18b799d2d62f5fef7905f
Submitter: Zuul v3 CI (<email address hidden>)
Branch: R5.0

commit 0460741b8eacbd319fa18b799d2d62f5fef7905f
Author: Michal Clapinski <email address hidden>
Date: Tue Apr 17 16:19:57 2018 +0200

Add python3 support

Since cpython 2 has bugs that won't be fixed on Windows, we have to move
to python 3

Change-Id: I9c71f1558154e902693c6175969a8895663ccbef
Partial-Bug: #1737177

Reviewed: https://review.opencontrail.org/42014
Committed: http://github.com/Juniper/contrail-controller/commit/499694a627be0a22de888dd409bb73c5eb003bff
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 499694a627be0a22de888dd409bb73c5eb003bff
Author: Michal Clapinski <email address hidden>
Date: Tue Apr 17 16:07:03 2018 +0200

Add python3 support

Since cpython 2 has bugs that won't be fixed on Windows, we have to move
to python 3

Change-Id: I765f17008d1470d6eacb69d259211847a5fbecaf
Partial-Bug: #1737177

Reviewed: https://review.opencontrail.org/41892
Committed: http://github.com/Juniper/contrail-third-party/commit/22a4f3cecc25a434f561033d7f19837c38d3008b
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 22a4f3cecc25a434f561033d7f19837c38d3008b
Author: Mateusz Jablonski <email address hidden>
Date: Fri Apr 13 17:06:03 2018 +0200

Change Boost and OpenSSL paths in Thrift project on Windows

Boost and OpenSSL libraries will be moved from third-party to system directory.

Change-Id: I1556be2892aae056bd08b25280d1b380ff887dce
Partial-Bug: #1737177

Review in progress for https://review.opencontrail.org/42063
Submitter: Pawel Marchewka (<email address hidden>)

Review in progress for https://review.opencontrail.org/42069
Submitter: Mateusz Jablonski (<email address hidden>)

Review in progress for https://review.opencontrail.org/41878
Submitter: Pawel Marchewka (<email address hidden>)

Review in progress for https://review.opencontrail.org/42063
Submitter: Pawel Marchewka (<email address hidden>)

Reviewed: https://review.opencontrail.org/42069
Committed: http://github.com/Juniper/contrail-third-party/commit/e7bf0fca7bafd83e204dae7a6c0e51f4478faf93
Submitter: Zuul v3 CI (<email address hidden>)
Branch: R5.0

commit e7bf0fca7bafd83e204dae7a6c0e51f4478faf93
Author: Mateusz Jablonski <email address hidden>
Date: Fri Apr 13 17:06:03 2018 +0200

Change Boost and OpenSSL paths in Thrift project on Windows

Boost and OpenSSL libraries will be moved from third-party to system directory.

Change-Id: I1556be2892aae056bd08b25280d1b380ff887dce
Partial-Bug: #1737177
(cherry picked from commit 22a4f3cecc25a434f561033d7f19837c38d3008b)

Reviewed: https://review.opencontrail.org/41965
Committed: http://github.com/Juniper/contrail-vrouter/commit/b6f73f06db29114b3f013a60a50db31217bf0f89
Submitter: Zuul v3 CI (<email address hidden>)
Branch: R5.0

commit b6f73f06db29114b3f013a60a50db31217bf0f89
Author: Pawel Marchewka <email address hidden>
Date: Mon Apr 16 17:50:45 2018 +0200

windows: fix held udp flows

Change-Id: I76e7a967bb499aff1a47196bc52ccd548ef71be7
Closes-Bug: #1737177

Reviewed: https://review.opencontrail.org/41964
Committed: http://github.com/Juniper/contrail-vrouter/commit/2cc691779b3c3802fb04a1567fabd2a9b81aeb54
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 2cc691779b3c3802fb04a1567fabd2a9b81aeb54
Author: Pawel Marchewka <email address hidden>
Date: Mon Apr 16 17:50:45 2018 +0200

windows: fix held udp flows

Change-Id: I76e7a967bb499aff1a47196bc52ccd548ef71be7
Closes-Bug: #1737177

Reviewed: https://review.opencontrail.org/42019
Committed: http://github.com/Juniper/contrail-common/commit/68898872c17d9f71b5b64c5af0e2ae2820b544c2
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 68898872c17d9f71b5b64c5af0e2ae2820b544c2
Author: Michal Clapinski <email address hidden>
Date: Tue Apr 17 16:17:51 2018 +0200

Add python3 support

Since cpython 2 has bugs that won't be fixed on Windows, we have to move
to python 3

Change-Id: Icf690ad6cac40a5886947085e16abf5535b4f293
Partial-Bug: #1737177

Reviewed: https://review.opencontrail.org/42023
Committed: http://github.com/Juniper/contrail-controller/commit/7740346693d7315508373c52f15172ed870bef15
Submitter: Zuul v3 CI (<email address hidden>)
Branch: R5.0

commit 7740346693d7315508373c52f15172ed870bef15
Author: Michal Clapinski <email address hidden>
Date: Tue Apr 17 16:07:03 2018 +0200

Add python3 support

Since cpython 2 has bugs that won't be fixed on Windows, we have to move
to python 3

Change-Id: I765f17008d1470d6eacb69d259211847a5fbecaf
Partial-Bug: #1737177

Reviewed: https://review.opencontrail.org/42025
Committed: http://github.com/Juniper/contrail-common/commit/3708ee56ff69ac87b89c68a3bcc8be8d7b63005f
Submitter: Zuul v3 CI (<email address hidden>)
Branch: R5.0

commit 3708ee56ff69ac87b89c68a3bcc8be8d7b63005f
Author: Michal Clapinski <email address hidden>
Date: Tue Apr 17 16:17:51 2018 +0200

Add python3 support

Since cpython 2 has bugs that won't be fixed on Windows, we have to move
to python 3

Change-Id: Icf690ad6cac40a5886947085e16abf5535b4f293
Partial-Bug: #1737177

Reviewed: https://review.opencontrail.org/42024
Committed: http://github.com/Juniper/contrail-api-client/commit/a0f7b5acb0b38779bc5d06455a6087299007c7a0
Submitter: Zuul v3 CI (<email address hidden>)
Branch: R5.0

commit a0f7b5acb0b38779bc5d06455a6087299007c7a0
Author: Michal Clapinski <email address hidden>
Date: Tue Apr 17 16:14:43 2018 +0200

Add python3 support

Since cpython 2 has bugs that won't be fixed on Windows, we have to move
to python 3

Change-Id: I02fe6dcee44e90f60dd68c4a94d8f0319a682b7b
Partial-Bug: #1737177

Reviewed: https://review.opencontrail.org/42027
Committed: http://github.com/Juniper/contrail-vrouter/commit/c4152505c450932778cfb050eea3ec449b944051
Submitter: Zuul v3 CI (<email address hidden>)
Branch: R5.0

commit c4152505c450932778cfb050eea3ec449b944051
Author: Michal Clapinski <email address hidden>
Date: Tue Apr 17 16:24:35 2018 +0200

Add python3 support

Since cpython 2 has bugs that won't be fixed on Windows, we have to move
to python 3

Change-Id: I4042246eabd9f81accf973c6624f10f3f4a31a81
Partial-Bug: #1737177

Reviewed: https://review.opencontrail.org/42021
Committed: http://github.com/Juniper/contrail-build/commit/8c874075d10dbda9b9c0972139210e329a19b450
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 8c874075d10dbda9b9c0972139210e329a19b450
Author: Michal Clapinski <email address hidden>
Date: Tue Apr 17 16:19:57 2018 +0200

Add python3 support

Since cpython 2 has bugs that won't be fixed on Windows, we have to move
to python 3

Change-Id: I9c71f1558154e902693c6175969a8895663ccbef
Partial-Bug: #1737177

Reviewed: https://review.opencontrail.org/42063
Committed: http://github.com/Juniper/contrail-controller/commit/16006ee8ecfad443da2e74bf72f4a2a7cfb9224d
Submitter: Zuul v3 CI (<email address hidden>)
Branch: R5.0

commit 16006ee8ecfad443da2e74bf72f4a2a7cfb9224d
Author: Pawel Marchewka <email address hidden>
Date: Fri Apr 13 12:16:48 2018 +0200

Use boost and openssl from system on windows

Use boost and openssl from system instead of third_party on windows

Change-Id: Id798344bd11b021946d13ed1576a70cba5cfeba2
Partial-Bug: #1737177

Reviewed: https://review.opencontrail.org/41878
Committed: http://github.com/Juniper/contrail-controller/commit/403a95ab1c1830d415e7db82d4197259ab6cc31e
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 403a95ab1c1830d415e7db82d4197259ab6cc31e
Author: Pawel Marchewka <email address hidden>
Date: Fri Apr 13 12:16:48 2018 +0200

Use boost and openssl from system on windows

Use boost and openssl from system instead of third_party on windows

Change-Id: Id798344bd11b021946d13ed1576a70cba5cfeba2
Partial-Bug: #1737177

Review in progress for https://review.opencontrail.org/42393
Submitter: Pawel Marchewka (<email address hidden>)

Review in progress for https://review.opencontrail.org/42394
Submitter: Pawel Marchewka (<email address hidden>)

Reviewed: https://review.opencontrail.org/42017
Committed: http://github.com/Juniper/contrail-api-client/commit/302dcf27334f908e154dbfbaa6fa8a6b7a96ede2
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 302dcf27334f908e154dbfbaa6fa8a6b7a96ede2
Author: Michal Clapinski <email address hidden>
Date: Tue Apr 17 16:14:43 2018 +0200

Add python3 support

Since cpython 2 has bugs that won't be fixed on Windows, we have to move
to python 3

Change-Id: I02fe6dcee44e90f60dd68c4a94d8f0319a682b7b
Partial-Bug: #1737177

Review in progress for https://review.opencontrail.org/42502
Submitter: Pawel Marchewka (<email address hidden>)

Review in progress for https://review.opencontrail.org/42511
Submitter: Pawel Marchewka (<email address hidden>)

Review in progress for https://review.opencontrail.org/42512
Submitter: Pawel Marchewka (<email address hidden>)

Review in progress for https://review.opencontrail.org/42513
Submitter: Pawel Marchewka (<email address hidden>)

Displaying first 40 and last 40 comments. View all 344 comments or add a comment.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers