Possible memory leak in KSyncSockTcpSession constructor

Bug #1735174 reported by Andrei Bunghez on 2017-11-29
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Juniper Openstack
Status tracked in Trunk
R3.2
Fix Committed
Medium
Nagendra E S
R4.0
Won't Fix
Medium
Nagendra E S
R4.1
Fix Committed
Medium
Nagendra E S
R5.0
Fix Committed
Undecided
Nagendra E S
Trunk
Fix Committed
Undecided
Nagendra E S
OpenContrail
Won't Fix
Undecided
Nagendra E S

Bug Description

OpenContrail 3.2

Hi everybody,

Coverity reports a possible memory leak in ksync_sock.cc:967, in constructor
KSyncSockTcpSession::KSyncSockTcpSession(TcpServer *server, Socket *sock,bool async_ready);

The 'reader_' private field is allocated here and never deleted.

Regards,
Andrei

(56142)

Ashok Singh (ashoksr) on 2018-07-02
Changed in opencontrail:
assignee: nobody → Nagendra E S (esnagendra)

Review in progress for https://review.opencontrail.org/44837
Submitter: Nagendra E S (<email address hidden>)

Reviewed: https://review.opencontrail.org/44837
Committed: http://github.com/Juniper/contrail-controller/commit/1a6091af7981972f403520f44972cce89ed5bf19
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 1a6091af7981972f403520f44972cce89ed5bf19
Author: Nagendra E S <email address hidden>
Date: Wed Jul 11 14:43:58 2018 +0530

Releasing reader_ memory for KSyncSockTcpSession.

Change-Id: Ic37b941a36d880e96616ff787563f7c1fcb21531
Partial-Bug: #1735174

Review in progress for https://review.opencontrail.org/44885
Submitter: Nagendra E S (<email address hidden>)

Reviewed: https://review.opencontrail.org/44885
Committed: http://github.com/Juniper/contrail-controller/commit/7bd3259f2b9b0b3333ad3f270721766ff5fd4a45
Submitter: Zuul v3 CI (<email address hidden>)
Branch: R5.0

commit 7bd3259f2b9b0b3333ad3f270721766ff5fd4a45
Author: Nagendra E S <email address hidden>
Date: Wed Jul 11 14:43:58 2018 +0530

Releasing reader_ memory for KSyncSockTcpSession.

Change-Id: Ic37b941a36d880e96616ff787563f7c1fcb21531
Partial-Bug: #1735174
(cherry picked from commit 1a6091af7981972f403520f44972cce89ed5bf19)

Review in progress for https://review.opencontrail.org/45516
Submitter: Nagendra E S (<email address hidden>)

Review in progress for https://review.opencontrail.org/45519
Submitter: Nagendra E S (<email address hidden>)

Changed in opencontrail:
status: New → Won't Fix

Reviewed: https://review.opencontrail.org/45516
Committed: http://github.com/Juniper/contrail-controller/commit/7ca4873192ace8ab97b20e28cffbabdd4f8f3b7a
Submitter: Zuul (<email address hidden>)
Branch: R3.2

commit 7ca4873192ace8ab97b20e28cffbabdd4f8f3b7a
Author: Nagendra E S <email address hidden>
Date: Fri Aug 3 09:53:52 2018 +0530

Releasing reader_ memory for KSyncSockTcpSession.

Change-Id: Ic773d0a5531ab0d327d28eacf58beb3e9f52aa2f
Partial-Bug: #1735174

OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/45519
Committed: http://github.com/Juniper/contrail-controller/commit/69381c62dacf9d618c07bb6dcfdaa7d4117296d4
Submitter: Zuul (<email address hidden>)
Branch: R4.1

commit 69381c62dacf9d618c07bb6dcfdaa7d4117296d4
Author: Nagendra E S <email address hidden>
Date: Fri Aug 3 18:37:05 2018 +0530

Releasing reader_ memory for KSyncSockTcpSession.

Change-Id: Ica7c732b1e7a8ca730147daf0cd10dd47ebf8858
Partial-Bug: #1735174

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers