SYMC: "endpoint_type" should be a config item in svc monitor nova client

Bug #1546356 reported by Rudrajit Tapadar
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Juniper Openstack
Status tracked in Trunk
R2.21.x
Fix Committed
Medium
Rudrajit Tapadar
R2.22.x
Fix Committed
Medium
Rudrajit Tapadar
R3.0
Fix Committed
Medium
Rudrajit Tapadar
Trunk
Fix Committed
Medium
Rudrajit Tapadar
OpenContrail
Fix Committed
Medium
Rudrajit Tapadar

Bug Description

https://github.com/Juniper/contrail-controller/blob/master/src/config/svc-monitor/svc_monitor/nova_client.py#L25

Creating or using the "internalURL" endpoint is not mandatory and it should be a config item with default as "internalURL".

summary: - "endpoint_type" should be a config item in svc monitor nova client
+ SYMC: "endpoint_type" should be a config item in svc monitor nova client
tags: added: config service-chain
Changed in opencontrail:
importance: Undecided → Medium
assignee: nobody → Rudra Rugge (rudrarugge)
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/21245
Submitter: Rudrajit Tapadar (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R2.21.x

Review in progress for https://review.opencontrail.org/21249
Submitter: Rudrajit Tapadar (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R2.22.x

Review in progress for https://review.opencontrail.org/21251
Submitter: Rudrajit Tapadar (<email address hidden>)

Changed in opencontrail:
assignee: Rudra Rugge (rudrarugge) → Rudrajit Tapadar (rtapadar)
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R3.0

Review in progress for https://review.opencontrail.org/21252
Submitter: Rudrajit Tapadar (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/21252
Committed: http://github.org/Juniper/contrail-controller/commit/2b18ab96d22f2b876336d9e2c45449c7d7d38f26
Submitter: Zuul
Branch: R3.0

commit 2b18ab96d22f2b876336d9e2c45449c7d7d38f26
Author: Rudrajit Tapadar <email address hidden>
Date: Thu Jun 16 17:08:44 2016 -0700

Adds configurable nova endpoint type in svc monitor

The current code of svc mon uses internalURL of the nova endpoint.
In practice, the internalURL is not a mandatory endpoint type.
Hence the code fails whenever internalURL is not configured.
This change makes it configurable.

Closes Bug: #1546356

Change-Id: I1a529f3b3ad416784559ec6a04d4775c0c43bcf9

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/21251
Committed: http://github.org/Juniper/contrail-controller/commit/720977cc63b9a3feef5b45e28ed8c4d818501269
Submitter: Zuul
Branch: R2.22.x

commit 720977cc63b9a3feef5b45e28ed8c4d818501269
Author: Rudrajit Tapadar <email address hidden>
Date: Thu Jun 16 17:08:44 2016 -0700

Adds configurable nova endpoint type in svc monitor

The current code of svc mon uses internalURL of the nova endpoint.
In practice, the internalURL is not a mandatory endpoint type.
Hence the code fails whenever internalURL is not configured.
This change makes it configurable.

Closes Bug: #1546356

Change-Id: I1a529f3b3ad416784559ec6a04d4775c0c43bcf9

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/21245
Committed: http://github.org/Juniper/contrail-controller/commit/1e2ba114138d01911124838e592ae7e92737e1f1
Submitter: Zuul
Branch: master

commit 1e2ba114138d01911124838e592ae7e92737e1f1
Author: Rudrajit Tapadar <email address hidden>
Date: Thu Jun 16 17:08:44 2016 -0700

Adds configurable nova endpoint type in svc monitor

The current code of svc mon uses internalURL of the nova endpoint.
In practice, the internalURL is not a mandatory endpoint type.
Hence the code fails whenever internalURL is not configured.
This change makes it configurable.

Closes Bug: #1546356

Change-Id: I1a529f3b3ad416784559ec6a04d4775c0c43bcf9

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/21249
Committed: http://github.org/Juniper/contrail-controller/commit/9de89977ee474332a6ec87c987ba7cfca0352988
Submitter: Zuul
Branch: R2.21.x

commit 9de89977ee474332a6ec87c987ba7cfca0352988
Author: Rudrajit Tapadar <email address hidden>
Date: Thu Jun 16 17:08:44 2016 -0700

Adds configurable nova endpoint type in svc monitor

The current code of svc mon uses internalURL of the nova endpoint.
In practice, the internalURL is not a mandatory endpoint type.
Hence the code fails whenever internalURL is not configured.
This change makes it configurable.

Closes Bug: #1546356

Change-Id: I1a529f3b3ad416784559ec6a04d4775c0c43bcf9

Changed in opencontrail:
status: New → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.