Create cluster doesn't handle user variable additions at end of file

[Samuel Matzek]

Between running bootstrap-cluster and create-cluster I modified /etc/openstack_deploy/user_variables.yml and added my used IP ranges at the bottom of the file. When I run create-cluster it ran through the ceph cluster creation and then failed with this error:

Variable files: "-e @/etc/openstack_deploy/user_secrets_trove.yml -e @/etc/openstack_deploy/user_secrets.yml -e @/etc/openstack_deploy/user_var_ceilometer.yml -e @/etc/openstack_deploy/user_var_ceph.yml -e @/etc/openstack_deploy/user_var_haproxy.yml -e @/etc/openstack_deploy/user_variables_trove.yml -e @/etc/openstack_deploy/user_variables.yml "
ERROR: Syntax Error while loading YAML script, /etc/openstack_deploy/user_variables.yml
Note: The error may actually appear before this position: line 185, column 33

  - "172.29.240.1,172.29.240.50"
  - "172.29.244.1,172.29.244.50"apply_security_hardening: false

My guess is that this is because my edit did not have a new line at the end of the file.

This should be fixed and we should seriously consider running the syntax check command at the head of create-cluster, before the user walks away during Ceph cluster creation or anything else that runs before the OSA run. The syntax check is documented here [1].

[1] http://docs.openstack.org/developer/openstack-ansible/install-guide/installation.html

[Luke Browning (lukebrowning-y)]

https://github.com/open-power-ref-design/os-services/commit/6f3a626775985edce4c72cb048a25cac8b6db2bc