ooi

ooi throws misleading error if token is not scoped

Bug #1678060 reported by Alvaro Lopez
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
ooi
Fix Released
Medium
Alvaro Lopez

Bug Description

When we receive a token that is not scoped, we simply throw back:

    Malformed request URL: URL's project_id 'None' doesn't match Context's project_id 'None'

Alvaro Lopez (aloga)
Changed in ooi:
importance: Undecided → Medium
Alvaro Lopez (aloga)
Changed in ooi:
status: New → Confirmed
assignee: nobody → Alvaro Lopez (aloga)
milestone: none → 1.0.0
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ooi (master)

Fix proposed to branch: master
Review: https://review.openstack.org/452161

Changed in ooi:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ooi (master)

Reviewed: https://review.openstack.org/452161
Committed: https://git.openstack.org/cgit/openstack/ooi/commit/?id=0549ee16cb52d46bdc598943e2fa985ad9442339
Submitter: Jenkins
Branch: master

commit 0549ee16cb52d46bdc598943e2fa985ad9442339
Author: Alvaro Lopez Garcia <email address hidden>
Date: Fri Mar 31 13:34:36 2017 +0200

    Check if project id is None from headers

    To check if the user was providing a scoped token we were relying on the
    "HTTP_X_PROJECT_ID" environment variable, relying on a KeyError
    exception when accessing the dictionary. However, the variable can be
    empty, resulting in a dictionary key "HTTP_X_PROJECT_ID":None. As a
    consequence, we were using None as the project ID, resulting in
    misleading errors.

    Closes-bug: #1678060
    Change-Id: I1956fd99be5771371b1d3401e335528c5cc6455e

Changed in ooi:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.