slide for keyboard broken in 3.26

Bug #1726289 reported by Ritesh Raj Sarraf
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Onboard
New
Undecided
Unassigned

Bug Description

The GNOME Shell extension provided by Onboard allowed an addition feature, Slide from Bottom. This was very handy with applications like Qt Based ones and Chromium.

Unfortunately, GNOME 3.26 made interface changes that broke it further. This was reported in the old upstream recently.
https://github.com/schuhumi/gnome-shell-extension-onboard-integration/issues/7

The bug is because of an interface change.

Oct 23 09:39:10 priyasi gnome-shell[15016]: JS ERROR: TypeError: Main.keyboard.Show is not a function
                                            Onboard<.ShowAnyKeyboard@/<email address hidden>/extension.js:193:9
                                            wrapper@resource:///org/gnome/gjs/modules/_legacy.js:82:22
                                            enable_show_gesture/<@/<email address hidden>/extension.js:225:17
                                            EdgeDragAction<.vfunc_gesture_end@resource:///org/gnome/shell/ui/edgeDragAction.js:82:13
                                            wrapper@resource:///org/gnome/gjs/modules/_legacy.js:82:22

Removing the line following line seems to get slider work again.

https://github.com/schuhumi/gnome-shell-extension-slide-for-keyboard/blob/f930f2e1cea3c621389dd443a2a353d21e03bc15/src/extension.js#L19

Revision history for this message
Ritesh Raj Sarraf (rrs) wrote :

There are other issues too. The Onboard shell extension was designed to trap keyboard input signals and show Onboard keyboard instead of Caribou. With GNOME 3.26, it ends up showing both. Will attach screenshot soon.

Revision history for this message
Ritesh Raj Sarraf (rrs) wrote :

        //Main.keyboard.Show(global.get_current_time());
        Main.keyboard.show(global.get_current_time());

I'm no good at JS, but going through the GNOME Shell JS code, this seems to be the change I needed.
With this change in place, sliding for the keyboard from the bottom does show Onboard.

But now leads in the following non-fatal exception:

Oct 23 15:36:29 priyasi gnome-shell[3160]: JS ERROR: TypeError: this.keyboardMonitor is undefined
                                           LayoutManager<._updateKeyboardBox@resource:///org/gnome/shell/ui/layout.js:468:9
                                           wrapper@resource:///org/gnome/gjs/modules/_legacy.js:82:22
                                           set keyboardIndex@resource:///org/gnome/shell/ui/layout.js:566:9
                                           Onboard<.enable/KeyboardShow/<@/<email address hidden>/extension.js:136:17
                                           Keyboard<.show/this._keyboardRestingId<@resource:///org/gnome/shell/ui/keyboard.js:638:56

Revision history for this message
Ritesh Raj Sarraf (rrs) wrote :

Sorry about the formatting mess. I don't see how to do code formatting in LP.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.