[AWS] Network deletion is failing

[Pratik Shah]

Using CLI to delete network throws an Exception "Error in update subnet precommit: AWS Error: 'NeutronError' - 'Required parameter id not set'"

CLI command: openstack network delete <network_id>

Stacktrace: Please check attachment for stacktrace

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/491500

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/491500
Committed: https://git.openstack.org/cgit/openstack/omni/commit/?id=3c2185aac391f05e2221f0c5b054865fcfe773ec
Submitter: Jenkins
Branch: master

commit 3c2185aac391f05e2221f0c5b054865fcfe773ec
Author: Pratik Shah <email address hidden>
Date: Mon Aug 7 19:33:20 2017 +0530

    Added a fix to delete a network.

    Description:
    Deleting network was raising an Exception
    "AWS Error: 'NeutronError' - 'Required parameter id not set'"

    Issue:
    When VPC and Subnet are deleted, neutron core code notifies the change.
    But since VPC is already deleted, "create_tags_for_vpc()" doesn't get
    VPC ID. Hence it raises AWS Exception when it tries to create tags.

    Neutron core code calls "update_network_precommit()" when notifying the
    change which eventually calls "create_tags_for_vpc()"

    Fix:
    Added a check for VPC ID in "create_tags_for_vpc()"

    Closes-Bug: #1709046

    Change-Id: I6a94911e41bc194b98ddaf51cf9585ac3f4ed07e