Fails to launch after running setup from branch

Bug #632336 reported by Stuart Colville on 2010-09-07
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Olive
High
Unassigned

Bug Description

I used to have olive installed but it seems to have disappeared after an update.

I've attempted to run it having checked out the branch and running setup.py install however I get the following traceback due to missing image files which aren't present in the branch:

Traceback (most recent call last):
  File "/home/scol/canonical/olive/olive-gtk", line 93, in <module>
    app = OliveGtk()
  File "/home/scol/canonical/olive/olive/__init__.py", line 90, in __init__
    self.window = OliveGui(calling_app = self)
  File "/home/scol/canonical/olive/olive/window.py", line 37, in __init__
    self.set_icon_list(gtk.gdk.pixbuf_new_from_file(icon_path("oliveicon2.png")),
TypeError: pixbuf_new_from_file() argument 1 must be string, not None

Related branches

Lee Hyde (anubeon) wrote :

I am experiencing the same error having installed from latest branch (lp:olive) today, under Ubuntu 10.10 (x86-64). The traceback at this end is identical c.f. that detailed in the initial bug report, excepting the locations (mine are located in /usr/local/...).

Pavlo Shchelokovskyy (pshchelo) wrote :

I have experienced the same bug and found the following solution, which is actually 2 steps:

1) the icons are clearly missing in the branch, probably due to recent departure from bzr-gtk project. You have to create an "icons" folder next to "olive" folder in the installation base and put there 2 files from "images" folder of bzr-gtk - "olive-gtk.png" and "oliveicon2.png". Then the installation succeeds.

2) even after having icons and installing olive one fails to launch it, because olive can not find those icons when starting. Reason - olive now installs those icons in its own path (share/pixmaps) but uses the icon_path() function provided by bzr-gtk to find them (in share/bzr-gtk/icons), and latest bzr-gtk no more installs these icons (although they are still present in the source...). Possible solutions:
 - change olive's setup.py to install olive icons to the same place where bzr-gtk icons are, as it was before split from bzr-gtk (see attached patch)
 - if the idea is to separate olive from bzr-gtk as much as possible, one should then have separat set of functions for locating olive-specific resources (images etc) apart from bzr-gtk ones. I will try to do it and submit a merge proposal.

Lee Hyde (anubeon) wrote :

Greetings Pavlo,

Thanks for the information, that seems to have solved it for me. Incidentally how does one apply a patch? I had to amend setup.py manually because I'm ignorant of the correct means of applying patches.

Kind Regards,

Lee Hyde.

Pavlo Shchelokovskyy (pshchelo) wrote :

Hi Lee,

if on Linux, there is literally a command named "patch", see its options. On Windows you would need GnuWin32 or Cygwin (these will give you the same Linux "patch" command), or probably some other third-party merge program can do that.

Hope this helps. Cheers,
Pavlo.

Pavlo Shchelokovskyy (pshchelo) wrote :

I've made the branch with the appropriate changes, linked it here and proposed for merging

Jelmer Vernooij (jelmer) on 2011-02-28
Changed in olive:
status: New → Confirmed
importance: Undecided → High
Jelmer Vernooij (jelmer) on 2011-06-28
Changed in olive:
status: Confirmed → Fix Committed
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers