LexbuilderSlaveServer.api_startBuild is missing SSH key and LP ID arguments

Bug #917361 reported by Guilherme Salgado on 2012-01-16
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Offspring
High
Kevin McDermott

Bug Description

Looks like we missed that when backporting stuff from the linaro branch. Because of this, if the master tries to build a private project it will probably crash because api_startBuild() will be called with more arguments than it expects.

This also means we're lacking some tests

Related branches

description: updated
Changed in offspring:
status: New → Triaged
importance: Undecided → High
Changed in offspring:
assignee: nobody → Kevin McDermott (bigkevmcd)
Changed in offspring:
status: Triaged → Fix Committed
Timothy R. Chavez (timrchavez) wrote :

This was marked Fix Committed quite a while ago but never got changed to Fix Released. Didn't the SSH stuff Linaro did get moved to the linaro-privacy feature branch? I'd like to take some sort of action on this bug (if only to get more info into it). Thanks.

Kevin McDermott (bigkevmcd) wrote :

So, this area proved the most contentious, the security benefits are debatable, and I guess we need to think about the implications of storing a _private_ key on an untrusted builder.

Changed in offspring:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers